mirror of
https://github.com/facebook/sapling.git
synced 2024-10-08 15:57:43 +03:00
f1c575a099
Summary:
This check is useful and detects real errors (ex. fbconduit). Unfortunately
`arc lint` will run it with both py2 and py3 so a lot of py2 builtins will
still be warned.
I didn't find a clean way to disable py3 check. So this diff tries to fix them.
For `xrange`, the change was done by a script:
```
import sys
import redbaron
headertypes = {'comment', 'endl', 'from_import', 'import', 'string',
'assignment', 'atomtrailers'}
xrangefix = '''try:
xrange(0)
except NameError:
xrange = range
'''
def isxrange(x):
try:
return x[0].value == 'xrange'
except Exception:
return False
def main(argv):
for i, path in enumerate(argv):
print('(%d/%d) scanning %s' % (i + 1, len(argv), path))
content = open(path).read()
try:
red = redbaron.RedBaron(content)
except Exception:
print(' warning: failed to parse')
continue
hasxrange = red.find('atomtrailersnode', value=isxrange)
hasxrangefix = 'xrange = range' in content
if hasxrangefix or not hasxrange:
print(' no need to change')
continue
# find a place to insert the compatibility statement
changed = False
for node in red:
if node.type in headertypes:
continue
# node.insert_before is an easier API, but it has bugs changing
# other "finally" and "except" positions. So do the insert
# manually.
# # node.insert_before(xrangefix)
line = node.absolute_bounding_box.top_left.line - 1
lines = content.splitlines(1)
content = ''.join(lines[:line]) + xrangefix + ''.join(lines[line:])
changed = True
break
if changed:
# "content" is faster than "red.dumps()"
open(path, 'w').write(content)
print(' updated')
if __name__ == "__main__":
sys.exit(main(sys.argv[1:]))
```
For other py2 builtins that do not have a py3 equivalent, some `# noqa`
were added as a workaround for now.
Reviewed By: DurhamG
Differential Revision: D6934535
fbshipit-source-id: 546b62830af144bc8b46788d2e0fd00496838939
|
||
|---|---|---|
| .. | ||
| benchmarks | ||
| builddeb_fb | ||
| chg | ||
| debian | ||
| docker | ||
| hgsh | ||
| hgsubversion/tools | ||
| macosx | ||
| plan9 | ||
| python-zstandard | ||
| vagrant | ||
| vim | ||
| win32 | ||
| wix | ||
| all-revsets.txt | ||
| asv.conf.json | ||
| base-revsets.txt | ||
| bash_completion | ||
| bdiff-torture.py | ||
| build-linux-wheels.sh | ||
| builddeb | ||
| buildrpm | ||
| casesmash.py | ||
| check-code.py | ||
| check-config.py | ||
| check-py3-compat.py | ||
| clang-format-blacklist | ||
| debugcmdserver.py | ||
| dirstatenonnormalcheck.py | ||
| dockerdeb | ||
| dockerlib.sh | ||
| dockerrpm | ||
| dumprevlog | ||
| editmerge | ||
| editmergeps.bat | ||
| editmergeps.ps1 | ||
| fixpax.py | ||
| genosxversion.py | ||
| git-sl | ||
| hg-new-workdir | ||
| hg-ssh | ||
| hg-test-mode.el | ||
| hgclient.py | ||
| hggitperf.py | ||
| hgk | ||
| hgperf | ||
| hgweb.fcgi | ||
| hgweb.wsgi | ||
| import-checker.py | ||
| lint.py | ||
| linux-wheel-centos5-blacklist | ||
| logo-droplets.svg | ||
| Makefile.python | ||
| memory.py | ||
| mercurial.el | ||
| mercurial.spec | ||
| mq.el | ||
| packagelib.sh | ||
| perf.py | ||
| phabricator.py | ||
| pylintrc | ||
| python3-ratchet.py | ||
| python3-whitelist | ||
| python-hook-examples.py | ||
| revsetbenchmarks.py | ||
| scm-prompt.sh | ||
| showstack.py | ||
| simplemerge | ||
| synthrepo.py | ||
| tcsh_completion | ||
| tcsh_completion_build.sh | ||
| traceprof.py | ||
| undumprevlog | ||
| unit.py | ||
| utils.py | ||
| with-hg-dev | ||
| xml.rnc | ||
| zsh_completion | ||
