Summary:
Release notes: none
This fixes a React reconciliation bug where lazy ReactElement temporals were not correctly being put into the correct branches. Previously, `wrapReactElementInBranchOrReturnValue` was only called on the "result" of an `applyBranchedLogicValue` where it should have been applied after each ReactElement creation given that `applyBranchedLogicValue` is recursive.
Pull Request resolved: https://github.com/facebook/prepack/pull/2597
Differential Revision: D10298262
Pulled By: trueadm
fbshipit-source-id: 4868ab7f2514734913a626e4e7e7e3259e4199b5
Summary:
Release notes: adds `createdAbstracts` `Set` to both `Effects` and `Realm`.
For a feature I'm working on, where we can optionally inline function calls depending on a bunch of pre-defined heuristics, I've run into the need for a feature for tracking abstract values. When we use `evaluateForEffects` we currently get quite a bit of information of what occurred, nicely packaged up in effects. One of those is `createdObjects`, which is super useful for many cases, but I believe we also need, is a way of knowing what `AbstractValue`s were created in effects too. This PR adds that functionality.
Pull Request resolved: https://github.com/facebook/prepack/pull/2593
Differential Revision: D10276125
Pulled By: trueadm
fbshipit-source-id: 299b0f91d93b1491987b10e769ca77f17e64716d
Summary:
Release Notes: `--initializeMoreModules` can take a JSON file of module ids to initialize
Allows testing this in `test-internal` with a new `.modules` file.
Also fixes ReproPackageManager to not exit prepack if a file can't be found while zipping a repro.
Pull Request resolved: https://github.com/facebook/prepack/pull/2590
Differential Revision: D10208977
Pulled By: cblappert
fbshipit-source-id: 7a5620f16829c39f2d8f936c6beb8b66e7c102be
Summary:
Adds optimized operator support for `Array.filter`, and makes compositions in which `Array.filter` is called on a mapped array correct. Aliasing information kept in the mapped array is exposed to the `Array.filter` call, which collects it in the resulting array.
Resolves#2580
Pull Request resolved: https://github.com/facebook/prepack/pull/2582
Differential Revision: D10204091
Pulled By: sb98052
fbshipit-source-id: a365d3d7120cbae344c64c540e5b63a889b6c699
Summary:
* Fix referentialization of optimized functions
* Fix serialization issues for nested optimized functions
* Model aliasing effects for array loop operators
* Fix dependency issues with cyclic prototype dependencies
* Fix problem where a bind call can use a variable before its definition
* Speed up visitor by skipping redundant generator scopes
Reviewed By: trueadm
Differential Revision: D10191866
fbshipit-source-id: 669d6c7a49f10f3222c3dd56537e0f76a4e9d2c6
Summary:
Release notes: none
When testing our internal React Native bundle, we need to supply a string reference to `RCTActivityIndicatorView` for JSX elements.
Pull Request resolved: https://github.com/facebook/prepack/pull/2588
Differential Revision: D10193281
Pulled By: trueadm
fbshipit-source-id: ce7785d9c71ea4c278118e08c1438dbb5259f8b8
Summary:
Release Notes: None
Changes the logic for determining which ModifiedBindings need serialization to work properly in the face of nested optimized functions. We should only serialize `ModifiedBinding`s if their environment was not created by the optimized function or its children (i.e. the binding should not be local to the optimized function).
This also solves the issue that React components don't have a parent chain which is important for properly handling nested optimized functions. Solves #2550.
Solves #2430, Solves #2426, Solves #2423, Solves #2422 (some were solved by previous PRs, just adding the tests here as well).
Pull Request resolved: https://github.com/facebook/prepack/pull/2551
Differential Revision: D10010048
Pulled By: cblappert
fbshipit-source-id: 2a855017514832a70d024f1ae9a91e9f07736ce0
Summary:
Release notes: none
When working on a separate issue that involved touching `evaluatePure`, I ran into a bug where `createdObjectsTrackedForLeaks` were not being populated by any objects returned from nested `evalautePure` calls. This fixes it and adds a helper function to `__evaluatePureFunction ` for testing this.
Pull Request resolved: https://github.com/facebook/prepack/pull/2585
Differential Revision: D10162545
Pulled By: trueadm
fbshipit-source-id: a2fcdcf19545a036aa5fbd003ea0929722ab7bde
Summary:
This PR guarantees the correctness of optimized `Array.map` operators, even in the face of aliasing effects. It does four things:
1. Trigger generic leaking if an array operator is re-specialized in the non-Instant Render use case.
2. Tracks aliasing effects created by specialized operators, and triggers leaking or materialization when needed to ensure correct behavior
3. Deactivates immediate transitive materialization following the use of specialized operators, instead deferring this to the leaking implementation. The leaking implementation reaches aliased objects via a new arg added to widened numeric arrays. The arg is an abstract value of kind "mayAliasSet" that is set to top, but whose may alias set is tracked. If leaking does not happen, then materialization is avoided.
4. It permits benign mutations in Instant Render, where the mutations do not cause references to non-final snapshots of the object.
Follow up:
- Model aliasing effects losslessly via widened objects: #2569
- Add support for `filter` and `reduce`
Resolves#2449
Pull Request resolved: https://github.com/facebook/prepack/pull/2570
Differential Revision: D10149117
Pulled By: sb98052
fbshipit-source-id: eb686982574c8ef868934472903c405f3d63bbed
Summary:
Release notes: none
Some internal changes to the `react-mocks` where side-effects were observed in small cases that needed tweaking (only affects internal React testing).
Pull Request resolved: https://github.com/facebook/prepack/pull/2584
Differential Revision: D10147064
Pulled By: trueadm
fbshipit-source-id: bb4c196ae6f03abdc1c2e39b27b740a21989b61f
Summary:
Release notes: none
This PR cleans up some of the `onArrayWithWidenedNumericProperty` logic, making it more generic for cases where we want to use concrete derived object values. Furthermore, it strengthens the validation process by checking for existence of `isScopedTemplate` on the internal object.
Pull Request resolved: https://github.com/facebook/prepack/pull/2581
Differential Revision: D10141954
Pulled By: trueadm
fbshipit-source-id: 8de828080b8a41357830cdbf7e49359512bc7244
Summary:
Release notes: none
Fixes https://github.com/facebook/prepack/issues/2574. This PR adds abstract value support to `Object.getOwnPropertySymbols` like we have done other internal methods (like `Object.keys` and `Array.from`) where we know the internal method creates an array with unknown numeric properties.
Pull Request resolved: https://github.com/facebook/prepack/pull/2575
Differential Revision: D10114237
Pulled By: trueadm
fbshipit-source-id: 07301147e2dff1ab370243a8dc9648745bbbbb96
Summary:
…pecify modules
Release Notes: None
Sometimes it'll be useful to allow the user to specify which specific modules you want to speculatively execute. This allows that by turning `--initializeMoreModules` into `--modulesToInitialize <ALL | comma separated list of modules>`
Updated tests as well.
Pull Request resolved: https://github.com/facebook/prepack/pull/2576
Differential Revision: D10092554
Pulled By: cblappert
fbshipit-source-id: bf601e14c2be59c865ae9513c914f39325521945
Summary:
Release notes: none
This PR fixes issues with the React hoisting and equivalence system mechanics and serialization where previous, there was no support for abstract length arrays. This includes an optimization for when the React serializer outputs ReactElement children that are conditionals with one side being an empty value (in this case, we can use an empty string instead).
Tests attached that focus on the areas covered in this PR.
Pull Request resolved: https://github.com/facebook/prepack/pull/2571
Differential Revision: D10082133
Pulled By: trueadm
fbshipit-source-id: d7de1834e10a5c4b3f35a90b9676ec72c6e797e2
Summary:
Release notes: None
Dumping happened before `processCollectedNestedOptimizedFunctions`,
which caused them to not be included. This is being fixed, plus some
minor refactoring to hide implementation details.
Pull Request resolved: https://github.com/facebook/prepack/pull/2568
Differential Revision: D10023363
Pulled By: NTillmann
fbshipit-source-id: 6abe2b5358f23705b501fc818536fb30d42a3b17
Summary:
Release notes: none
All these changes are only internal changes related to React.
This PR adds the `pe-functional-components` benchmark as tests to the React reconciler. The test was taken from: https://github.com/facebook/react/tree/master/scripts/bench/benchmarks/pe-functional-components.
In order to make the server side renderer test pass, a few TODOs had to be filled in (logic was missing) and the JSON logic has to be updated to account for empty strings in children that the compiler merges.
Pull Request resolved: https://github.com/facebook/prepack/pull/2560
Differential Revision: D10008375
Pulled By: trueadm
fbshipit-source-id: 3b39a3e6387e23e17532a2343bd84ebebb7ee9cd
Summary:
Release notes: None
There's no need to re-visit deep value chains in nested generators,
if a value was already visited in a parent generator.
This greatly speeds up certain internal RN scenarios.
Pull Request resolved: https://github.com/facebook/prepack/pull/2562
Differential Revision: D10001612
Pulled By: NTillmann
fbshipit-source-id: a4f66b1a4835121cef4e3bc424f507f5b2c843f9
Summary:
Release notes: None
To avoid all kinds of serialization issues, generators should form
a tree, and not a DAG. This is an attempt to establish that.
Pull Request resolved: https://github.com/facebook/prepack/pull/2434
Differential Revision: D9887684
Pulled By: NTillmann
fbshipit-source-id: c11c50c56dcd6eff02bd03448756bf79f6e2c820
Summary:
Release note: none
A large internal test case came up with a situation where an optimized function is rewritten with a version that early binds a yet to be declared value to one of its parameters.
This should probably never happen, so the if condition guarding this code path has been strengthened to prevent this.
Pull Request resolved: https://github.com/facebook/prepack/pull/2558
Reviewed By: trueadm
Differential Revision: D9967064
Pulled By: hermanventer
fbshipit-source-id: bf56872ea42ee8faefc347a6393cdcd9b3c518e9
Summary:
Release notes: none
This fixes#2555.
We were waiting on the wrong thing in the serializer.
Adding regression tests.
Pull Request resolved: https://github.com/facebook/prepack/pull/2556
Differential Revision: D9949808
Pulled By: NTillmann
fbshipit-source-id: a4ef5ece8c5dab6fa579a20dbb35ce7bf794bfc0
Summary:
Release Notes: None
Optimized functions will now be evaluated with the path condition at the time of function closure creation.
Resolves issue #2422
Pull Request resolved: https://github.com/facebook/prepack/pull/2537
Differential Revision: D9886282
Pulled By: cblappert
fbshipit-source-id: cae0282903d639ff0d94d0f4091c6f8ef9ef9a98
Summary:
Release Notes: None
Before, during referentialization, we would always default to the global scope if the value was accessed in more than one optimized function scope. Now we look for the outermost optimized function.
This logic already existed in ResidualHeapSerializer, so I refactored it out into `serializer/utils.js`.
Fixes#2428
Pull Request resolved: https://github.com/facebook/prepack/pull/2544
Differential Revision: D9926077
Pulled By: cblappert
fbshipit-source-id: c4ee6c07c7409534e9be14df25b582078a7ec77c
Summary:
This is a helper for inspecting values at a particular node in the AST. E.g.
```js
let n = global.__abstract ? __abstract("number", "10") : 10;
let x = {foo:1};
let y = {foo:2};
let c = __abstract("boolean", "c");
let i = 0;
let obj = {};
do {
i++;
obj.j = i;
obj.foo = c ? x : y;
} while (i < n);
__debugValue(obj); // Breaks with obj in context
inspect = function() {
return i + " " + obj.j;
};
```
Pull Request resolved: https://github.com/facebook/prepack/pull/2554
Differential Revision: D9922908
Pulled By: sb98052
fbshipit-source-id: dab9cae64a461283d8dec7f0bb7f8fae87a01c78
Summary:
The following test case currently fails:
```js
function F() {
this.a = 1;
this.b = 2;
if (global.__abstract) return global.__abstract(undefined, "undefined");
}
const result = new F();
global.inspect = () => JSON.stringify(result);
```
We hit this bug in our internal React Native bundle. I only added support for `base` construction kinds since the template for `derived` construction kinds would get more complicated.
Pull Request resolved: https://github.com/facebook/prepack/pull/2535
Differential Revision: D9906309
Pulled By: trueadm
fbshipit-source-id: 49a71ceaf30a851075879295e63e98ce7e1bbe2d
Summary: Now that babel 7 is stable we can use caret as we use from other tools (like Metro). `yarn.lock will make sure it does not get updated until we want
Reviewed By: pvdz
Differential Revision: D9861594
fbshipit-source-id: 9d27d9c91f2b4e28d8a3c914e9b578eb9f0dc90e
Summary:
Release notes: User-level stack overflows no longer crash Prepack.
This fixes#2552, and actually a bit more:
- We used to piggy-back on `pushContext` to count stack frames. However, there is no one-to-one correspondance of calls and context, so that wasn't a very good proxy. (In fact, there seem to be calls that don't push a context.) So we now count calls and constructs explicitly.
- Instead of just throwing a `FatalError` when the stack space is exceeded, which in turn causes an invariant violation since there must not be a `FatalError` thrown without a compiler diagnostics having beein issue. Now there is a regular error code PP0045.
Added error handler regression test.
Pull Request resolved: https://github.com/facebook/prepack/pull/2553
Differential Revision: D9889090
Pulled By: NTillmann
fbshipit-source-id: f6f863ee9ef73f258692f215ef75b63b737f5394
Summary:
This change ensures that the code generated via optimized array loop operators is correct in the InstantRender setting. It enables the optimization of such functions when the `--instantRender` option is set. Materialization is prevented by ensuring that post-optimization, objects that are reachable from the function are not mutated. Recoverable errors are issued. We also degrade all InstantRender bailouts to recoverable errors, to facilitate debugging. We add a constraint that optimized functions may not be reused.
Resolves#2451#2448
Pull Request resolved: https://github.com/facebook/prepack/pull/2547
Differential Revision: D9816268
Pulled By: sb98052
fbshipit-source-id: 2112b199de50b80a7a9852a794c082be3bf122e9
Summary:
In support of #2547. Sometimes, it is more desirable (less costly, better for debugging) to flag a warning for a possibly anomalous condition, than to assume that it is anomalous and enforce it as an error. This change exposes warnings that a user upgrades to errors, so that they can then be enforced as such.
Pull Request resolved: https://github.com/facebook/prepack/pull/2548
Differential Revision: D9884632
Pulled By: sb98052
fbshipit-source-id: c47b57a21aa047b0f3fa2672508f8fb23c04942a
Summary:
Release note: none
When a new path condition is added to an existing path conditions object, the negative caches must be cleared since the new condition might allow previously failed implications to now succeed. This was already done in one case, but a few others were missed. The clearing code is now centralized and all cases go through it.
While debugging the internal test case that failed because of the caching mistake, I also realized that PathConditions.implies and PathConditions.impliesNot can profitably deconstruct expressions of the form !x before doing the implication check. This also has the advantage that it eliminates a subtle endless recursion situation in a nicer way than the current code.
I've also added some comments in places that caught my eye during debugging.
Pull Request resolved: https://github.com/facebook/prepack/pull/2549
Differential Revision: D9883127
Pulled By: hermanventer
fbshipit-source-id: 06faa709dfecaa4f98b7d0ce5e1c7a9efb6b805f
Summary:
cc NTillmann
Following up https://github.com/facebook/prepack/issues/2285, website shows the generated coded even when there are some warnings.
Lot of changes because prettier wasn't applied to the files, but I basically only checked for the error buffer containing only items with `severity === 'Warning'` and create the `warning` result type to behave the same than `success` one.
Next step would be to show the code AND warning messages. Either using the same display than error messages or creating a variation of it (changing text color to yellow for example). I can do it if you want.
Let me know if this is what you were looking for.
Have a nice day !
P.S: not sure if this PR was supposed to be into `gh-pages` or `master`. Let me know if that needs to be changed.
Pull Request resolved: https://github.com/facebook/prepack/pull/2528
Differential Revision: D9882040
Pulled By: NTillmann
fbshipit-source-id: bc8266a673e6def023bfa65b93b94ea9c7ad5b1d
Summary:
Release Notes: None
This PR makes it so we no longer report conflicts for child optimized functions reading from values that their parents have written.
Couple of things for discussion:
- This creates somewhat confusing behavior because the child functions will take the concrete value after the parent functions' effects have been applied:
```javascript
(function () {
let obj = {p: 42};
function f() {
obj.p += 3;
function g() { return obj.p; } // Will optimize to `return 47;`
obj.p += 1;
__optimize(g);
obj.p += 1;
return g;
}
__optimize(f);
global.f = f;
})();
```
- This PR creates the Parent/Child relationship based off `AdditionalFunctionEffects.parentAdditionalFunction` which goes off of syntactic nesting of functions instead of nesting of `__optimize` calls as in the issue. I believe basing the nesting off of `__optimize` calls could lead to somewhat unintuitive results (especially considering we store `parentAdditionalFunction` in `AdditionalFunctionEffects` to be the syntactic parent).
I am not sure if it is needed by Instant Render NTillmann? If it is, we may want to consider changing `AdditionalFunctionEffects.parentAdditionalFunction` to be based off of `__optimize` call nesting as well for consistency.
As an example a slight modification on the example above:
```javascript
(function () {
let obj = {p: 42};
function g() { return obj.p; }
function f() {
obj.p += 3;
__optimize(g);
obj.p += 1;
return [g, obj];
}
__optimize(f);
global.f = f;
})();
```
With this PR, we report an error. Based off of `__optimize` nesting, we would optimize `g` to `return 46;`. I would expect to see `return 42;` `return 45;` or `return obj.p;` in this case.
- To resolve the above issues, in the future, we could make any values modified by parent optimized functions into abstract values during evaluation for child optimized functions to force their accesses to be recorded in generators .
Resolves#2351
Pull Request resolved: https://github.com/facebook/prepack/pull/2542
Differential Revision: D9803741
Pulled By: cblappert
fbshipit-source-id: baca233c8de81633332b25f0776ed1a9d6c95a60
Summary:
This can be a possible fix for https://github.com/facebook/prepack/issues/2509
I have removed the `invariant` method call and added a value check as used for the _invariantMode_ option.
`node lib/prepack-cli.js --debugDiagnosticSeverity foo`
will now generate
`Unsupported debugDiagnosticSeverity: foo`
Pull Request resolved: https://github.com/facebook/prepack/pull/2545
Differential Revision: D9800485
Pulled By: hermanventer
fbshipit-source-id: edc24b4a812b4e32f9c48e05a0799bf4af431991
Summary:
Release notes: None
Otherwise, this could cause issues, as path conditions get captured e.g. in generators.
Pull Request resolved: https://github.com/facebook/prepack/pull/2538
Reviewed By: hermanventer
Differential Revision: D9762541
Pulled By: NTillmann
fbshipit-source-id: 4d12681e3921d2c0f10f3c9f3f0702823a2b0d99
Summary:
Release notes: Fixes invariant violation regression when using webpack-prepack-plugin
This fixes#2540.
I didn't actually test it end-to-end webpack-prepack-plugin, would be great if someone could do that. We need some kind of end-to-end test for this to avoid regressions in the future.
Pull Request resolved: https://github.com/facebook/prepack/pull/2541
Differential Revision: D9756803
Pulled By: NTillmann
fbshipit-source-id: 2bded0dcb0a16369f3d3ff41c2f4d5181c75d67c
Summary:
Release note: none
Closes#2435Closes#1829
Join.composeWithEffects composes a forked completion with subsequent effects. When two or more forks could end normally, this could result in shallow copies of the subsequent effects. These were then joined together and applied, so it was mostly OK. The generator of the subsequent effects, however, ended up being joined with itself and thus transformed the generator tree to a DAG, which is not desirable for the serializer.
The new approach is to extract a join condition from the forked completion and using it to join the subsequent effects with a newly constructed empty effects. The condition ensures that the subsequent effects are applied only in situations where the forked completion is not abrupt.
Extracting this condition makes for complicated abstract expressions and this uncovered some existing bugs and limitations that are also addressed in this pull request. As a side effect, path conditions are now longer and the time to compile unrolled loops with conditional abrupt completions inside their bodies has gone up so much that the unroll limit had to be lowered.
Please note that the expected output React tests has changed because of re-ordering. I'm none too sure that this re-ordering is necessarily benign, so please review carefully.
Pull Request resolved: https://github.com/facebook/prepack/pull/2523
Differential Revision: D9623729
Pulled By: hermanventer
fbshipit-source-id: 737096bba54a7a2ad300dc29882ea1b7829ac745
Summary:
Release notes: providing __replaceFunctionImplementation_unsafe built-in
This new built-in allows replacing the method implementation (capture environment, body, ...) of source functions.
As a result, all method calls executed by the Prepack interpreter will be redirected,
and the replacement will carry over to the prepacked code.
Pull Request resolved: https://github.com/facebook/prepack/pull/2533
Reviewed By: hermanventer
Differential Revision: D9693654
Pulled By: NTillmann
fbshipit-source-id: bd28997965e641f58f89f7119fa477c535c0e539
Summary:
Release note: none
This attempts to reduce exponential blowup in the simplifier by doing more caching while computing implications and by imposing a depth limit on the number of simplify and implies calls.
It also tries to make implies and impliesNot more symmetrical, so that things are less ad-hoc.
Pull Request resolved: https://github.com/facebook/prepack/pull/2530
Differential Revision: D9664026
Pulled By: hermanventer
fbshipit-source-id: f7a9135b06298a2b77ad05bf377982a9b37e4ad1
Summary:
Release notes: none
Fixes a bug where `reactFailOnUnsupportedSideEffects` should evaluate to `false` if passed as false. Also fixes a lint issue on `master`.
Pull Request resolved: https://github.com/facebook/prepack/pull/2532
Differential Revision: D9662462
Pulled By: trueadm
fbshipit-source-id: 1ffeea55e55a2bde9f1d44c64ac85d7e1b1727cf
