Kiril Videlov
50577f3865
remove inappropriate path function from repo actions trait
2024-07-07 23:12:43 +02:00
Kiril Videlov
6dcbb8bddb
move conflicts module to branches crate
2024-07-07 22:58:48 +02:00
Kiril Videlov
0924b506d7
remove deps towards repository actions from remotes controller
2024-07-07 22:38:33 +02:00
Kiril Videlov
ca2ffaac68
separate complex actions on Project repo in a separate trait
2024-07-07 22:28:27 +02:00
Kiril Videlov
143b3252a7
rename Repository type to ProjectRepo
...
Less misleading this way..
2024-07-07 22:09:45 +02:00
Kiril Videlov
b72e3de178
Merge pull request #4262 from gitbutlerapp/feature-add-virtual-branches-access-trait
...
Move branch state to a separate crate
2024-07-07 21:48:38 +02:00
Kiril Videlov
9258614a64
adds ci for branchstate crate
2024-07-07 21:29:20 +02:00
Kiril Videlov
e2bfb03fa9
remove irrelevant test
...
This test used to exercise the custom iterator that existed before
2024-07-07 21:27:09 +02:00
Kiril Videlov
00a77d9327
move branch state into a separate crate
2024-07-07 21:26:07 +02:00
Kiril Videlov
71809fc882
remove project dependency on oplog
2024-07-07 21:10:31 +02:00
Kiril Videlov
1c9b702993
Merge pull request #4261 from gitbutlerapp/move-vb-files-to-crate
...
move vb files to crate
2024-07-07 21:09:27 +02:00
Kiril Videlov
a7aa9b0e10
move remote module to the branch crate
2024-07-07 20:48:12 +02:00
Kiril Videlov
3d0455f12b
move virtual branch files impl our of core
2024-07-07 20:35:26 +02:00
Kiril Videlov
da9f495816
Merge pull request #4260 from gitbutlerapp/move-oplog-to-own-crate
...
move oplog to its own crate
2024-07-07 20:33:19 +02:00
Kiril Videlov
6d5ef6b03e
adds a ci job for oplog crate
2024-07-07 20:18:40 +02:00
Kiril Videlov
c36f67f148
move oplog to its own crate
...
This protects us from cyclic dependencies. Unfortunatelly as part of this, i had to introduce the imp Project as trait implementations since now Project is foreign
2024-07-07 20:00:01 +02:00
Kiril Videlov
b286a6e2d3
Merge pull request #4259 from gitbutlerapp/add-gitbutler-sync-crate
...
move cloud sync functionality to its own crate
2024-07-07 19:38:25 +02:00
Kiril Videlov
68c6fe1c04
add ci for the sync crate
2024-07-07 19:24:35 +02:00
Kiril Videlov
d456ba5e77
move cloud sync functionality to its own crate
2024-07-07 19:22:41 +02:00
Kiril Videlov
832ef485c4
Merge pull request #4258 from gitbutlerapp/Move-virtual-branches-implementation-out-of-core-and-into-gitbutler-branch-crate
...
Move virtual branches implementation out of core and into gitbutler-branch crate
2024-07-07 17:43:03 +02:00
Kiril Videlov
9dc82e8fe9
move virtual, integration and base modules to gitbutler-branch crate
2024-07-07 17:30:18 +02:00
Kiril Videlov
f224207029
move remaining integration constants to core
2024-07-07 16:49:25 +02:00
Kiril Videlov
0865521f90
move GITBUTLER_INTEGRATION_REFERENCE constant outside of integration rs
...
This allows integration implementation to be extracted out of core
2024-07-07 16:34:20 +02:00
Kiril Videlov
9eaab28a48
move base branch implementation to branches crate
2024-07-07 16:29:24 +02:00
Kiril Videlov
41f28383a0
move author to core
2024-07-07 16:13:06 +02:00
Kiril Videlov
7627a41c89
remove unused method on the assets proxy impl
2024-07-07 16:06:26 +02:00
Kiril Videlov
ce130dcf12
move normalize_branch_name to core
2024-07-07 16:04:01 +02:00
Kiril Videlov
948c89e8be
move virtual outside of core
2024-07-07 15:51:07 +02:00
Kiril Videlov
2cd91be6f4
Merge pull request #4256 from gitbutlerapp/sep-vb-crate
...
start moving virtual_branches to separate crate
2024-07-07 14:03:42 +02:00
Kiril Videlov
9b13eb62d3
add CI for gitbutler-branc
...
This is getting out of hand - we need a better way of setting up the CI for a the crates we wanna have
2024-07-07 13:38:33 +02:00
Kiril Videlov
7d078de52f
start moving virtual_branches to separate crate
...
We want to move towards having each functional domain in a separate crate.
The main benefit of that for our project is that this will enforce a unidirectional dependency graph (i.e. no cycles).
Starting off with virutal_branches - a lot of the implementation is still in core (i.e. virtual.rs), that will be moved in a separate PR.
Furthermore, the virtual branches controller (as well as virtual.rs) contain functions not directly related to branches (e.g. commit reordering etc). That will be furthe separate in a crate.
2024-07-07 13:32:35 +02:00
Kiril Videlov
ef3e6afdc9
Merge pull request #4252 from gitbutlerapp/disable-project-semaphore-usage
...
feature flag for disabling the project semaphore
2024-07-06 19:11:15 +02:00
Kiril Videlov
532b51bade
feature flag for disabling the project semaphore
...
It's possible that the sempahore state in the virtual branches controller is completely unnecessary. This feature flag allows us to test this hypothesis
2024-07-06 18:57:58 +02:00
Kiril Videlov
66d0ba2ac2
Merge pull request #4251 from gitbutlerapp/create-virtual-branch-changes
...
virtual branches controller - remove state dependency to credentials controller
2024-07-06 17:15:00 +02:00
Kiril Videlov
819b327973
virtual branches controller - remove state dependency to credentials controller
2024-07-06 17:03:46 +02:00
Kiril Videlov
3d0953e50c
Merge pull request #4250 from gitbutlerapp/deprecate-generated-key
...
remove the gitbutler generated key flow
2024-07-06 16:23:16 +02:00
Kiril Videlov
c777431363
remove the gitbutler generated key flow
2024-07-05 15:56:24 +02:00
Kiril Videlov
d3b4900fd1
Merge pull request #4246 from gitbutlerapp/refactor-remove-with_verify_branch-middleware-closures
...
remove with_verify_branch middleware closures
2024-07-04 17:26:04 +02:00
Kiril Videlov
3e01e86701
remove with_verify_branch middleware closures
2024-07-04 17:12:20 +02:00
Kiril Videlov
43afdfe559
Merge pull request #4245 from gitbutlerapp/Virtual-branch
...
move the updating of "last fetch timestamp" logic
2024-07-04 16:48:21 +02:00
Mattias Granlund
cf78a5b58b
Work around bug in PR status after branch push
...
- gh can incorrectly report checks as completed even though they just started
- can be marked completed because not all checks are initially included in the check suite
- for GitButler specifically somtimes check-runs includes only a single completed GitGuardian check
2024-07-04 17:34:58 +03:00
Kiril Videlov
82dd580c27
move the updating of "last fetch timestamp" logic
...
Removing the updating of project from the virtual branch controller - this is the only dependency between the two controllers and likely indicates that the "last fetched at" should live somewhere else.
It will serve us well to not mutate the project state from the virtual branches domain
2024-07-04 16:34:53 +02:00
Kiril Videlov
ec52598f62
Merge pull request #4243 from gitbutlerapp/simplify-virtual-branches-controller-deps-graph
...
simplify virtual branches controller deps graph
2024-07-04 15:50:51 +02:00
Kiril Videlov
dfd15dc821
remove unused function
2024-07-04 15:36:36 +02:00
Kiril Videlov
fe7f1167bf
virtua branches controller - rm deps on project controller
2024-07-04 15:26:10 +02:00
Kiril Videlov
f1f7039053
Merge pull request #4241 from gitbutlerapp/simplify-vbranches-deps-graph
...
simplify vbranches deps graph
2024-07-04 13:49:22 +02:00
Kiril Videlov
babfa974ce
remove unnecessary lifetime annotations
2024-07-04 13:31:08 +02:00
Kiril Videlov
3dded08458
simplify virtual branches controller deps graph
...
users controller is not a real dependency
2024-07-04 13:28:17 +02:00
Mattias Granlund
2bc8ff1d03
Decrease metrics polling frequency
...
- it's unclear what the ideal window length is
- small window likely means tracking each change
- small window currently not beneficial in answering product questions
- will re-evaluate based on findings
2024-07-04 14:10:01 +03:00
Kiril Videlov
6add0a40cc
remove unnecessary user dependency
2024-07-04 13:09:04 +02:00