Commit Graph

850 Commits

Author SHA1 Message Date
Caleb Owens
62f87863af Improve commit message guidelines for Haiku
- Adds guideline to not use hash symbols before commit message lines
- Wraps commit message lines at 72 characters
- Specifies that only the commit message should be returned in the response
2024-03-18 19:20:18 +01:00
Caleb Owens
7cb17e9180 Fix: Correctly pass model kind to API 2024-03-18 19:20:18 +01:00
Caleb Owens
9ac44479a5 Pass model_kind to API 2024-03-18 19:20:18 +01:00
Caleb Owens
2cc474d2f9 Test toast error messages 2024-03-18 19:20:18 +01:00
Caleb Owens
4a36585f0d return undefined when git config value is null 2024-03-18 19:20:18 +01:00
Caleb Owens
5e524f4ed0 Fix regex and refactor
`/\n+(.*?)\w*/s` wasn't behaving correctly so I used `/\n+(.*)/s` from CommitDialog.svelte.
I want to consolidate this logic at some point because we've
got similar logic multiple times.

The ORing to empty strings isn't required and we can use the falsey nature of "" to
see if we should be showing just the summary or both
2024-03-18 19:20:18 +01:00
Caleb Owens
ff6f9a73e7 use ConfigKeys enum for dummy GitConfig keys
Change git config access to use the ConfigKeys enum instead of
string literals.

Also update import paths to use the new $lib alias for better modularity.
2024-03-18 19:20:18 +01:00
Mattias Granlund
c90d887ab7 Some suggestions for improvement 2024-03-18 19:20:18 +01:00
Caleb Owens
6c2d98d2f4 Refactor to use new context patterns 2024-03-18 19:20:18 +01:00
Caleb Owens
8b9b573b98 Added some tests to cover the aiService 2024-03-18 19:20:18 +01:00
Caleb Owens
d80a334bbd Improve AI client error handling 2024-03-18 19:20:18 +01:00
Caleb Owens
2a1ab3cdec Use default paramaters rather than doing an OR 2024-03-18 19:20:18 +01:00
Caleb Owens
721b9d13fa Add test:watch script to package.json files
Add a test:watch script to the package.json files in the root
and ui directories. This script runs vitest in watch mode for
the development environment, allowing developers to run tests
continuously while making changes to the codebase.
2024-03-18 19:20:18 +01:00
Caleb Owens
1e5c418bd2 Add support for Anthropic's Haiku model
Add a new enum value for Anthropic's Haiku model, which was released
on 2023-03-07. Update the default model to Haiku in the loadConfig
function. Add Haiku to the list of available models in the
configureAnthropicModel function.
2024-03-18 19:20:18 +01:00
Caleb Owens
f50dd13844 Rename model to modelName 2024-03-18 19:20:18 +01:00
Caleb Owens
52427bbed8 Rename AI Provider to AI Client 2024-03-18 19:20:18 +01:00
Caleb Owens
74e3d475ac initial pass of aiService as discussed 2024-03-18 19:20:18 +01:00
Caleb Owens
5457068e3e Small tweaks 2024-03-18 19:20:18 +01:00
Caleb Owens
8fee75762d Ensure set isn't called after initial load 2024-03-18 19:20:18 +01:00
Caleb Owens
5ece49ad41 Fix formatting issues 2024-03-18 19:20:18 +01:00
Caleb Owens
b86b46662c feat: use aiService for commit message generation
Refactor commit message generation to use the summarizer from the
aiService context instead of building it locally. This allows the
summarizer to be shared across components and avoids unnecessary
rebuilds.

Also update the branch name generation in the branch view to use the
summarizer from the aiService context.

Add the aiService to the page context and retrieve the summarizer
observable in the components that need it.

No leaked keys found in the provided git diff.
2024-03-18 19:20:18 +01:00
Caleb Owens
8ddfbd0ffd (non atomic) Moved to storing gitConfig settings with a writable 2024-03-18 19:20:18 +01:00
Caleb Owens
0ca1d9a895 refactor: Refactor code to use onMount for asynchronous data retrieval and setting properties in SummarizerSettings class. Update setters for OpenAIModel in SummarizerSettings class. 2024-03-18 19:20:18 +01:00
Caleb Owens
cfe7369661 refactor: Extracted configuration keys into constants 2024-03-18 19:20:18 +01:00
Caleb Owens
c34a0047ee Spread comment on multiple lines 2024-03-18 19:20:18 +01:00
Caleb Owens
32854787fb Remove typecast 2024-03-18 19:20:18 +01:00
Caleb Owens
7437b2f860 refactor: extract summarizer settings to use gitConfig
The summarizer settings are extracted to a new class
`SummarizerSettings` that takes a `GitConfig` instance in its
constructor. This allows the settings to be built using the
`GitConfig` methods, removing the need for individual functions to
get and set each setting. The `GitConfig` instance is injected in
the `+page.svelte` file.
2024-03-18 19:20:18 +01:00
Caleb Owens
58b0eb2324 fix: Changed icon name from "stat" to "search" in AI Options button
Updated the icon displayed in the AI Options button from "stat" to "search" to accurately represent the functionality.
2024-03-18 19:20:18 +01:00
Caleb Owens
c22cef4631 feat: improve AI settings UI and copy
* Update "Yes, I'll use my own key" to "Yes, I'll provide my own key"
in the AI settings
* Add copy explaining GitButler's AI provider support and the
requirement to be logged in to use the GitButler API
* Remove unnecessary line breaks and simplify JSX in the AI settings
* Add copy about Anthropic's Opus and Sonnet models
2024-03-18 19:20:18 +01:00
Caleb Owens
bdcd2a47f0 feat: add radio buttons for model selection
- Change model kind selection from a dropdown to radio buttons
- Update copy for key option selection
- Conditionally show model version and API key inputs based on 
  selected model kind
- Add form element to handle model kind changes
- Update layout and styling of settings page

The most significant changes are:
- Switching from a dropdown to radio buttons for selecting the model 
  kind (OpenAI or Anthropic)
- Conditionally rendering the model version and API key inputs based
  on the selected model kind
- Adding a form to handle changes to the selected model kind

This refactors the settings page to improve the user experience when
selecting the model configuration. The radio buttons make the options
clearer, and conditionally showing fields reduces clutter.
2024-03-18 19:20:18 +01:00
Caleb Owens
3ded414a5a Code review updates
- Use await instead of then when calling the summarizer.branch
method to get the branch message
- Update the condition to check the currentSection value using ==
instead of ===
2024-03-18 19:20:18 +01:00
Caleb Owens
6b61b068a7 Update imports 2024-03-18 19:20:18 +01:00
Caleb Owens
305f17accc feat: Improve key leak warning in commit message instructions
Update the instructions for generating commit messages to clarify
that a warning should be given if any leaked keys are found in the
provided git diff, rather than a more general warning about leaked
keys.

This change improves the specificity and accuracy of the instructions,
making it clear that a warning is only necessary if keys are actually
detected in the diff under analysis.
2024-03-18 19:20:18 +01:00
Caleb Owens
1a059d885d refactor: rename summarizer_settings → summarizerSettings 2024-03-18 19:20:18 +01:00
Caleb Owens
7b6e92f22d refactor: remove cloud object from branch and commit components
The main changes in this commit are:

- Remove the `cloud` object from various branch and commit
  components, including:
  - BranchList.svelte
  - Branch.svelte
  - MiniCommitInfo.svelte
  - CommitMessageBox.svelte
- Update the corresponding type imports to only import the `User` type
  instead of also importing `getCloudApiClient`
- Remove the `cloud` prop from the usages of these components
- Adjust the indentation of the `<AiSettings>` component in the
  settings page

These changes were made to remove the unused `cloud` object from
several components related to branches and commits. The `cloud` prop
was being passed down to these components but was not actually being
used within them. Removing this unnecessary prop helps simplify the
components and their usage.
2024-03-18 19:20:18 +01:00
Caleb Owens
12aefe73a3 feat: add model and key configuration options
Add UI components for configuring the model kind (OpenAI or
Anthropic), key option (Butler API or bring your own key),
and associated settings.

The model kind can be set to either OpenAI or Anthropic. The
key option allows using the Butler API proxy or providing
your own API key.

When using your own key, the API key and model version can
be specified for the selected model kind (OpenAI or
Anthropic).

The selected options are persisted and loaded from the
backend settings.
2024-03-18 19:20:18 +01:00
Caleb Owens
15956c0729 refactor: Update AIProvider classes and add model options
Refactor AIProvider classes to include model options for OpenAIProvider
and AnthropicAIProvider. Also, add functions to get and set the model
for both providers to allow for more flexibility in model selection.
2024-03-18 19:20:18 +01:00
Caleb Owens
7890f3cf56 Updated Summarizer to use different AI providers based on settings
- Modified Summarizer to use different AI providers based on the selected model
  kind and token option.
- Added functionality to build Summarizer contextually based on user and settings.
- Introduced OpenAIProvider and AnthropicAIProvider for specific AI services.
- Integrated gitGetConfig and gitSetConfig functions for potential future use.
2024-03-18 19:20:18 +01:00
Caleb Owens
a43cdb4060 Set up dependencies for anthropics and open AI in client
I've been able to use the OpenAI library as they support being in the browser if you pass the "dangerouslyAllowBrowser" flag.

Anthropics don't have any interest in supporting browers making API calls and causes sugnificant CORS problems, so I've made use of the Tauri HTTP library, so this commit also sets that up
2024-03-18 19:20:18 +01:00
Caleb Owens
8b58ab3c54 Generate commit messages from diff
Add instructions to only respond with the commit message and to warn
about any leaked keys. This improves the specificity and security of
the assistant's output.
2024-03-18 19:20:18 +01:00
Mattias Granlund
98a0229e1b Fix mistake that broke previewing stashed branches 2024-03-18 18:25:49 +01:00
Pavel Laptev
16bc897442 UI tweak: Profile sidebar paddings 2024-03-18 16:50:21 +01:00
Pavel Laptev
8357dc0986 refactor: Updated empty board layout 2024-03-18 02:14:34 +01:00
Pavel Laptev
3eb198e552 styles: updated empty board layout 2024-03-18 01:48:33 +01:00
Pavel Laptev
8d7cb1c853 style: Add left padding to the board container 2024-03-18 01:42:54 +01:00
Pavel Laptev
2587ab5ee7 styles: empty board 2024-03-18 01:33:33 +01:00
Pavel Laptev
a39029531e refactor: remove unused ImgThemed component 2024-03-18 01:32:07 +01:00
Pavel Laptev
dad4f843f4 refactor: empty board image and layout update 2024-03-18 01:32:07 +01:00
Pavel Laptev
dd29f558fd refactor: DecorativeSplitView, imgs, welcome view
- updated `DecorativeSplitView` in order to get raw SVG
- updated `DecorativeSplitView` layout
- replaced raster WebP images with SVG
- updated icons for the Welcome screen
2024-03-18 01:32:07 +01:00
Pavel Laptev
a58623197f fix: empty state didn't showed if filter branches 2024-03-18 01:32:07 +01:00
Pavel Laptev
5d2a5736a9 refactor: replace empty state images with SVG 2024-03-18 01:32:07 +01:00
Pavel Laptev
c11d19e1cd refactor: Remove unused file 2024-03-18 01:32:07 +01:00
Pavel Laptev
b02dacb539 refactor: "create new branch" images updated with svg files
Svelte components with SVG inside were replaced with `@html` rule in irder to paste SVG files directly without convert them into Svelte files.
2024-03-18 01:32:07 +01:00
Pavel Laptev
e009ccb667 refactor: support image replaced with SVG 2024-03-18 01:32:07 +01:00
Pavel Laptev
45aa3a9d0a refacor: old logo asset removed 2024-03-18 01:32:07 +01:00
Pavel Laptev
6f70d6eb69 style: width changed for some Modal
for modals with less content width changed to `small`
2024-03-18 01:32:07 +01:00
Pavel Laptev
e4839a6538 fix(ui): Change size of update button to medium 2024-03-18 01:27:48 +01:00
Pavel Laptev
351a672183 refactor: remove unused ImgThemed component 2024-03-18 01:15:17 +01:00
Pavel Laptev
c0219ab2e5 refactor: empty board image and layout update 2024-03-18 01:12:26 +01:00
Pavel Laptev
693e2e9840 refactor: DecorativeSplitView, imgs, welcome view
- updated `DecorativeSplitView` in order to get raw SVG
- updated `DecorativeSplitView` layout
- replaced raster WebP images with SVG
- updated icons for the Welcome screen
2024-03-18 00:34:22 +01:00
Pavel Laptev
d74fc4a227 fix: empty state didn't showed if filter branches 2024-03-17 22:50:16 +01:00
Pavel Laptev
1817879788 refactor: replace empty state images with SVG 2024-03-17 18:55:55 +01:00
Pavel Laptev
12309e0c9e refactor: Remove unused file 2024-03-17 18:03:05 +01:00
Pavel Laptev
99ba7d9e37 refactor: "create new branch" images updated with svg files
Svelte components with SVG inside were replaced with `@html` rule in irder to paste SVG files directly without convert them into Svelte files.
2024-03-17 17:59:01 +01:00
Pavel Laptev
bc9e38b30e refactor: support image replaced with SVG 2024-03-17 17:55:34 +01:00
Pavel Laptev
5b8f7918e7 refacor: old logo asset removed 2024-03-17 17:12:53 +01:00
Pavel Laptev
28e6680db2 style: width changed for some Modal
for modals with less content width changed to `small`
2024-03-17 03:21:09 +01:00
Pavel Laptev
5632d8ac2b Design tokens updates
- Neutral colors updated
- `Space` renamed to `size`
- `size-btn` renamed to `size-control`
- Sizes in PX automatically generated to REM
- Design tokens file now fully generated without manual editing
- Moved dialog styles background to the `main.css` file
2024-03-17 03:12:07 +01:00
Mattias Granlund
4f2dfca322 Clean up variable assigment
- just making the code more readable
2024-03-16 15:48:41 +01:00
Mattias Granlund
e49bf7a4ef Fix broken project switching
- related to `observableToStore` functionality
2024-03-16 14:40:51 +01:00
Mattias Granlund
fee036fc7d Bug fix new base branch context store
- imported component instead of type
2024-03-16 13:48:29 +01:00
Mattias Granlund
52df5e5ec8 Put base branch into context as well 2024-03-16 13:19:47 +01:00
Mattias Granlund
09d20e8d5c Get BranchService with getContextByClass 2024-03-16 13:19:47 +01:00
Mattias Granlund
0084929959 Get BranchService with getContextByClass 2024-03-16 12:46:44 +01:00
Mattias Granlund
2bad7efa26 Get BranchController with getContextByClass 2024-03-16 12:39:06 +01:00
Mattias Granlund
f1987884d5 Get BranchController with getContextByClass
- elimnates prop drilling
- more of these commits to come
2024-03-16 12:30:30 +01:00
Mattias Granlund
c2d2147194 Get GitHubService with getContextByClass everywhere
- remvoes the need for prop drilling
2024-03-16 11:58:11 +01:00
Mattias Granlund
374fc4c869 Get UserService with getContextByClass everywhere
- remvoes the need for prop drilling
2024-03-16 11:58:11 +01:00
Mattias Granlund
dfe6886475 feat: Added function to convert observable to Svelte store. 2024-03-16 11:58:11 +01:00
Mattias Granlund
cb85baafa9 Move first service from prop drilling to Svelte context
- adds custom `getContext` to avoid extra typing when using classes as key
- project service no longer passed through component hierarchy
- switching projects require recreating components (already the case)
2024-03-16 10:53:36 +01:00
Mattias Granlund
035e2fbbcf Fix pr card title margin to prevent overlap with refresh button 2024-03-16 10:48:50 +01:00
Mattias Granlund
647b49e45e Use check suites to mitigate slow checks GitHub API
If we get `total_count == 0` for checks we load check suites to see if `total_count`
was > 0 on the last run as well. If so we retry until the API response becomes
eventually consistent.
2024-03-16 10:30:57 +01:00
Mattias Granlund
f7fdc260df Split out time ago store from component
- this way we can use it in more places
2024-03-16 10:24:30 +01:00
Mattias Granlund
6b74b5302b Make tooltip update if input updates
- helpful for tooltips that use input from timeAgo.ts
2024-03-16 09:52:18 +01:00
Mattias Granlund
bca71dce6d Small fixes to ResizeObserver
- disconnect takes no argument and unobserves everything
- prevents accidentally unobserving the wrong element
2024-03-16 09:52:18 +01:00
Mattias Granlund
717186a3e4 Small improvement to commit dialog data binding 2024-03-16 09:52:18 +01:00
Mattias Granlund
1475f06958 Miscellaneous fixes
- some things I found while working
2024-03-16 01:55:53 +01:00
Pavel Laptev
39434bede4 style: Update button size design token 2024-03-16 01:12:09 +01:00
Mattias Granlund
8a83e01ce0 Fix dev problem when hot reloading
- must check if element is still connected before manipulating element
2024-03-16 00:22:18 +01:00
Mattias Granlund
5d927abfcc Simplify GitHub service a little
- this branch will be force pushed again
2024-03-15 23:27:52 +01:00
Pavel Laptev
180d0eebd5 Commit box: race condition fixeed 2024-03-15 15:13:45 +01:00
Pavel Laptev
546e60c433 Merged origin/master into Commit box two fields 2024-03-15 14:32:48 +01:00
Scott Chacon
5afa391dfe wrong lint order 2024-03-15 05:45:34 +01:00
Scott Chacon
7fc51b775e Add GitButler app version 2024-03-15 05:45:34 +01:00
Scott Chacon
cec15bcdd0 send more context with feedback (OS, browser, index size) 2024-03-15 05:45:34 +01:00
Kiril Videlov
e0b0b85ad8 refactor: Update email input placeholder text and add required attribute to improve user experience 2024-03-14 20:31:21 +01:00
Pavel Laptev
ddee80788b style: add white-space: nowrap to label class
In order to prevent line breaks on the Tag component
2024-03-14 20:31:21 +01:00
Pavel Laptev
558340d17b refactor: Remove unused code 2024-03-14 20:31:21 +01:00
Mattias Granlund
82650a5500 Switch to new style of upstream commit list
- this work was left uncompleted a month back
2024-03-14 20:31:21 +01:00
Mattias Granlund
263ef78ed6 Refactor a couple of things for clarity 2024-03-14 14:29:06 +01:00