github/semantic
1
1
Fork 0
mirror of https://github.com/github/semantic.git synced 2024-12-20 21:31:48 +03:00
Code Issues Projects Releases Wiki Activity
28,455 Commits 19 Branches 16 Tags 46 MiB
086947ade5
Commit Graph

28455 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Patrick Thomson
086947ade5 Add golden tests for parse --proto-symbols output. 
This should help us ensure that we don't break CLI output, since our
CLI is an API.

This was made super-easy thanks to `tasty-golden`. I literally added
those two lines of code and it automatically created the reference
`.protobuf.bin` files. Slick as hell.
 2019-06-20 01:33:51 -04:00
Patrick Thomson
b62277f9b6
Merge pull request #167 from github/quiet-test-spew 
Quiet debug spew in specs.
 2019-06-19 21:37:15 -04:00
Patrick Thomson
b17a2c0ee8 Better nomenclature. 2019-06-19 17:56:37 -04:00
Patrick Thomson
4de36c5f0e Rewrite the Stat tests so they're not racy. 2019-06-19 17:54:53 -04:00
Patrick Thomson
0a3c11d5db Better formatting by keeping description lines shorter 2019-06-19 17:42:53 -04:00
Patrick Thomson
bb86469f56 Fix unused imports. 2019-06-19 17:35:37 -04:00
Patrick Thomson
43e3fb4533 Remove unnecessary use of parallel. 2019-06-19 17:22:09 -04:00
Patrick Thomson
6306f07cc1 Better story for handling JSON exceptions. 2019-06-19 17:14:52 -04:00
Patrick Thomson
6d599a5c7b Forgot that Exception doesn't imply Eq. 2019-06-19 12:58:40 -04:00
Patrick Thomson
9e2b0e3071
Merge branch 'master' into quiet-test-spew 2019-06-19 12:12:12 -04:00
Patrick Thomson
8ae90e53c5 Quiet debug spew in specs. 
This console barf makes reading though backscrolls unpleasant. Using
Shelly rather than an abomination of a `system` call and adding a
helper function to parse files quietly improved the situation greatly.

This also contains changes to Util that make the file significantly
easier to navigate, thanks to the power of `PartialTyepSignatures`.

Fixes #140.
 2019-06-19 12:09:37 -04:00
Patrick Thomson
5796962ecd
Merge pull request #161 from github/please-dont-just-review-our-PRs 
Add language detailing policy re. PR approvals/change requests.
 2019-06-17 18:23:45 -04:00
Patrick Thomson
91c2b2b2ba
Merge branch 'master' into please-dont-just-review-our-PRs 2019-06-17 17:15:24 -04:00
Rob Rix
0d2452fb1c
Merge pull request #162 from github/add-script-bootstrap 
Add script/bootstrap file.
 2019-06-17 16:56:14 -04:00
Rob Rix
8df0fdff42
Merge pull request #163 from github/really-advise-people-to-use-ghcup 
Emphasize `ghcup` and discourage use of system GHCs.
 2019-06-17 16:55:55 -04:00
Patrick Thomson
992c84c031 better language 2019-06-17 13:52:00 -04:00
Patrick Thomson
7f77ab6e12 Emphasize ghcup and discourage use of system GHCs. 
In #109, we encountered Arch users whose build failed because Arch
installs a GHC configured to use dynamic linking by default, and GHC
is relatively reluctant to use dynamic linking (and sensibly, too,
given that ABIs vary between releases of GHC). Though Arch users
should be able to work around this problem with careful use of
`new-configure` flags, I submit that we should strongly encourage
people to use sandboxed, statically-linked GHCs, rather than contort
our code to account for questionable decisions on the part of the OS.
 2019-06-17 13:34:36 -04:00
Patrick Thomson
2d4c889011 Add script/bootstrap file. 
Fixes #135.
 2019-06-17 13:23:05 -04:00
Patrick Thomson
fd2ba55d36 Address @dcreager's suggestions. 2019-06-17 12:43:58 -04:00
Patrick Thomson
e60cf727b1 Add language detailing policy re. PR approvals/change requests. 
We've seen some members of the public come in and leave distracting
reviews on our pull requests. This patch adds a clause to our
contributing documentation that outlines why we don't want people to
continue doing this.
 2019-06-17 09:59:18 -04:00
Patrick Thomson
23df12a74a
Merge pull request #159 from jhrcek/fixHlintWarnings 
Fix some hlint warnings
 2019-06-16 14:30:19 -04:00
Jan Hrček
ade8e8b265 Use isJust where applicable 2019-06-16 17:14:03 +02:00
Jan Hrček
915937c4be Fix some hlint warnings 2019-06-16 13:40:13 +02:00
Rob Rix
02e56c9251
Merge pull request #157 from jhrcek/fix-test-warnings 
Fix warnings in tests
 2019-06-15 12:38:36 -04:00
Patrick Thomson
93cb2d3f07
Merge branch 'master' into fix-test-warnings 2019-06-15 09:04:05 -04:00
Patrick Thomson
41b956ebbd
Merge pull request #158 from iporsut/master 
Remove unused NamedFieldPuns extension in Data.Source.Spec
 2019-06-15 09:03:32 -04:00
Weerasak Chongnguluam
32ba68e2d1 Remove unused NamedFieldPuns extension in Data.Source.Spec 2019-06-15 16:57:16 +07:00
Jan Hrček
ec4248cbb4 Fix warnings in tests 
27 [-Wunused-matches]
 7 [-Wmissing-export-lists]
 6 [-Wunused-imports]
 5 [-Wmissing-signatures]
 2 [-Wincomplete-uni-patterns]
 1 [-Wunused-top-binds]
 1 [-Wtype-defaults]
 2019-06-15 08:56:59 +02:00
Patrick Thomson
78dad094fa
Merge pull request #152 from github/remove-orphan-bytestring-listable 
Remove orphan ByteString Listable instance.
 2019-06-14 17:06:12 -04:00
Patrick Thomson
50424cfbec
Merge branch 'master' into remove-orphan-bytestring-listable 2019-06-14 16:51:16 -04:00
Patrick Thomson
12274038ef
Merge pull request #131 from github/document-adding-new-langs 
Document the process of adding new languages. (#126)
 2019-06-14 16:50:59 -04:00
Patrick Thomson
23194cf4f1 Draw correspondence between CLI and language stages. 2019-06-14 16:50:06 -04:00
Rob Rix
30fd1b4abf
Merge branch 'master' into remove-orphan-bytestring-listable 2019-06-14 16:34:13 -04:00
Patrick Thomson
3ab02f2f87
Merge branch 'master' into document-adding-new-langs 2019-06-14 16:10:39 -04:00
Patrick Thomson
1afb36c3bb
Merge pull request #149 from jhrcek/warnings-in-tests 
Enable warnings in tests
 2019-06-14 14:12:42 -04:00
Patrick Thomson
35fbd2a6c6
Merge branch 'master' into warnings-in-tests 2019-06-14 12:50:20 -04:00
Rob Rix
342a9393da
Merge pull request #151 from github/cache-dist-newstyle 
Cache the dist-newstyle directory.
 2019-06-14 12:48:45 -04:00
Patrick Thomson
01ec755c68 Address @dcreager's changes. 2019-06-14 12:47:53 -04:00
Patrick Thomson
1bffcb540b
Merge branch 'master' into cache-dist-newstyle 2019-06-14 12:39:13 -04:00
Patrick Thomson
02b36d2570 Port Leancheck+Hspec properties to Tasty.Hedgehog. 2019-06-14 12:33:28 -04:00
Patrick Thomson
e1d94f07d1 Remove Listable instance for Source. 
This was created with a whole mess of Leancheck combinators. A
Hedgehog approach makes things easier.
 2019-06-14 11:53:42 -04:00
Patrick Thomson
497bc507c5 Cache the dist-newstyle directory. 
This should address #88. We might even be able to turn -O1 on again.
 2019-06-14 11:39:18 -04:00
Jan Hrček
a644674a54 Fix -Wredundant-constraints warning 2019-06-14 15:56:07 +02:00
Jan Hrček
8959d4d1d6 Fix -Wdodgy-imports warnings 2019-06-14 15:46:06 +02:00
Jan Hrček
7aa0d8b3d9 Enable GHC warnings in tests 2019-06-14 15:35:18 +02:00
Rob Rix
440b182717
Merge pull request #147 from github/mention-cabal-2.4 
Document that Cabal 2.4 is necessary.
 2019-06-14 08:26:49 -04:00
Patrick Thomson
19b040cff6
Document that Cabal 2.4 is necessary. 
Fixes #145. Also removes some language about Stackage versions which isn’t accurate anymore.
 2019-06-14 08:25:49 -04:00
Patrick Thomson
cbf59c82c6
Merge branch 'master' into document-adding-new-langs 2019-06-14 08:22:48 -04:00
Rob Rix
0af79d0a42
Merge pull request #143 from iporsut/master 
Remove unused RankNTypes extension
 2019-06-14 07:09:58 -04:00
Weerasak Chongnguluam
da56c8b8a5 Remove unused RankNTypes extension 2019-06-14 13:39:00 +07:00