Rick Winfrey
13429a632d
Merge pull request #878 from github/if-else-if
...
Support else-if JavaScript clauses
2016-10-13 17:14:01 -05:00
Rick Winfrey
383573aa3d
Merge branch 'master' into if-else-if
2016-10-13 17:01:23 -05:00
Rick Winfrey
80ebddae5c
Bump tests
2016-10-13 16:44:36 -05:00
Rick Winfrey
5cc26fcc34
Remove BranchInfo for If Syntaxes
...
Although this allowed us to report a list of summary statements for
each if / else-if condition, we don’t append parent contexts to
Patches. Because we lose that parent context, it makes replacement
summary statements devoid of context. Taking a step back, @joshvera and
I decided to leave if summary statements as they are now, but revisit
this when we explore rollups. Although diff summary statements do not
include else-if clauses now in Syntax If accurately. So we have the
info, but as it stands, a long list of summary statements for each
else-if clause we determined to be less helpful, but will set us up for
success when we add rollups.
2016-10-13 16:42:49 -05:00
Rick Winfrey
59a2531889
Update toElseIf so we don't drop the elseClause for non If syntax clauses
2016-10-13 16:33:57 -05:00
Rick Winfrey
a80cb67b89
Extract toLeafInfo function
2016-10-13 12:36:18 -05:00
Rick Winfrey
62db2939f8
Clean and retain elseClause for If statements that are not If statements
2016-10-13 12:34:48 -05:00
Timothy Clem
ea28f0d8b0
Merge pull request #879 from github/hide-comments-in-summaries
...
Hide comments in summaries
2016-10-13 08:51:16 -07:00
Timothy Clem
148aa3024b
Bring back Commented, even if it isn't used yet
2016-10-13 08:37:44 -07:00
Timothy Clem
d9288f7e78
Note what HideInfo is used for
2016-10-13 08:37:29 -07:00
Rick Winfrey
649155c784
Merge branch 'if-else-if' of github.com:github/semantic-diff into if-else-if
2016-10-12 17:18:37 -05:00
Timothy Clem
1859df9500
Test to no longer expect summaries for comments
2016-10-12 14:21:40 -07:00
Timothy Clem
3815e713b5
Capture comments and hide them for summaries only
2016-10-12 14:21:25 -07:00
Rick Winfrey
e3f672674c
Remove previous idea
2016-10-12 15:35:09 -05:00
Rick Winfrey
6894bdcd55
<> over ++
2016-10-12 15:34:46 -05:00
Rick Winfrey
13980ba092
Merge branch 'master' into if-else-if
2016-10-12 15:07:06 -05:00
Rick Winfrey
1234f5dbc3
++javascript tests
2016-10-12 14:59:58 -05:00
Rick Winfrey
d222090c37
Update if-else.json tests
2016-10-12 14:55:59 -05:00
Rick Winfrey
17e29de931
📝
2016-10-12 14:55:34 -05:00
Rick Winfrey
d12a8d8e1b
Recursively construct If Syntaxes for nested If Terms
...
- Also adds Data.List (head)
2016-10-12 14:55:25 -05:00
Rick Winfrey
e4ac39547b
Construct BranchInfo for If nodes containing else-if clauses
...
- If a If node does not contain else-if clauses, we fall through and
construct LeafInfos
2016-10-12 12:38:21 -05:00
Rick Winfrey
a9d28f95c1
Break apart else clauses for If syntax nodes
...
- This is an intermediate step and not complete. We currently only
handle one level of else-if, rather than arbitrary levels of else-if.
2016-10-12 12:35:20 -05:00
Rick Winfrey
ddb39bdbcc
Update If Syntax to use a list to represent else conditions
...
- This lets us use a simple structure to break apart nested else-ifs
2016-10-12 12:32:55 -05:00
Timothy Clem
4fa10104c4
Merge pull request #873 from github/fix-benchmark-nm-call
...
Fix call to nm on benchmark build
2016-10-12 08:33:41 -07:00
Timothy Clem
e4504806c9
Merge branch 'master' into fix-benchmark-nm-call
2016-10-12 08:16:35 -07:00
Rick Winfrey
55e2b7b1f9
Merge branch 'master' into if-else-if
2016-10-12 09:41:16 -05:00
Rick Winfrey
76bba89d3c
WIP updates
2016-10-12 09:39:48 -05:00
Josh Vera
2e6ca19522
Merge pull request #872 from github/development-mode
...
Add development mode
2016-10-11 19:13:41 -04:00
Rick Winfrey
d1b22c231d
Merge branch 'development-mode' of github.com:github/semantic-diff into development-mode
2016-10-11 17:07:43 -05:00
Rick Winfrey
5cfe719141
Fix the order of the then else conditions
2016-10-11 17:06:51 -05:00
Rick Winfrey
1b715da024
Merge branch 'master' into development-mode
2016-10-11 16:42:08 -05:00
Rick Winfrey
8e0cc3374d
++javascript
2016-10-11 16:41:53 -05:00
Timothy Clem
f40f995e56
Merge pull request #863 from github/add-source-spans
...
Add source spans to diff summaries
2016-10-11 14:34:47 -07:00
Rick Winfrey
d5d1a7fbab
++javascript
2016-10-11 15:33:38 -05:00
Rick Winfrey
e7c09831bc
Add development mode
...
When developing locally, especially when using break to look at
structure, the timeout is too quick. Instead of manually updating the
timeout to a long duration, I figure disabling it when needed in the
context of ghci would be nicer.
2016-10-11 15:22:37 -05:00
joshvera
3012594a7d
Merge branch 'improve-memory-usage' into add-source-spans
2016-10-11 16:18:38 -04:00
joshvera
6ba48666ed
bump files
2016-10-11 16:18:26 -04:00
joshvera
1bfdeb7f06
Merge remote-tracking branch 'origin/improve-memory-usage' into add-source-spans
2016-10-11 15:38:30 -04:00
joshvera
440d168273
bump tests
2016-10-11 15:13:51 -04:00
joshvera
deb5a0f018
Fix SourceSpan in tests
2016-10-11 15:12:48 -04:00
joshvera
098655b1d9
Remove filepath from SourceSpan
2016-10-11 15:09:24 -04:00
joshvera
c0ae593a06
Remove filepath from SourceSpan
2016-10-11 13:08:12 -04:00
joshvera
007a1580fe
Merge remote-tracking branch 'origin/master' into add-source-spans
2016-10-11 13:03:43 -04:00
Rick Winfrey
d4ac4427d3
Add comment
2016-10-11 12:02:52 -05:00
Rick Winfrey
4611283966
Merge pull request #869 from github/pull-first
...
Pull from remote when generating test cases
2016-10-11 12:01:10 -05:00
Rick Winfrey
9c7707297b
Clean up error handler
2016-10-11 11:55:28 -05:00
joshvera
e57c80940e
bump tests
2016-10-11 12:52:26 -04:00
joshvera
70d39544cb
Rename to filepath
2016-10-11 12:46:40 -04:00
Rick Winfrey
329ce63a8e
++tests
2016-10-11 11:07:57 -05:00
Rick Winfrey
1b80b748d7
Checkout master before attempting to pull from remote
2016-10-11 11:07:51 -05:00
