Rick Winfrey
1e187d2f57
Use unknown for default Ruby assignment access control
...
Public is too open here, nicely spotted @joshvera
2019-01-23 14:51:27 -08:00
Rick Winfrey
381dd17494
Update wording to be less confusing
2019-01-23 14:50:37 -08:00
Rick Winfrey
4180cd7f4c
Remove pragma
2019-01-22 17:30:33 -08:00
Rick Winfrey
d1a9d56dfb
Comment out other AccessControl constructors
...
I'm not sure why this is causing problems for the proto roundtrip tests
2019-01-22 16:58:18 -08:00
Rick Winfrey
736ead4ade
Update fixtures
2019-01-18 18:21:36 -08:00
Rick Winfrey
e7c984182c
Update specs
2019-01-18 18:21:24 -08:00
Rick Winfrey
2eccafcecb
Rename fields from visibility -> accessControl
2019-01-18 18:21:07 -08:00
Rick Winfrey
27feb45a4b
Regen protos
2019-01-18 18:20:36 -08:00
Rick Winfrey
ffc9437891
Fix order of Ruby's Declaration.Method parameters
2019-01-18 17:34:58 -08:00
Rick Winfrey
056fd8eddf
Regenerate protos
2019-01-18 15:43:04 -08:00
Rick Winfrey
c99dfc6d0f
Clean up old fixture
2019-01-18 14:09:00 -08:00
Rick Winfrey
b79638ab7d
Add string based private method spec for now
2019-01-18 14:08:48 -08:00
Rick Winfrey
30ef3ab52b
Imports
2019-01-18 14:08:36 -08:00
Rick Winfrey
0639353cd1
Add private method fixture
2019-01-17 17:51:27 -08:00
Rick Winfrey
9c887e7eee
Ensure private static field definitions are not accessible by external member access
2019-01-17 17:21:16 -08:00
Rick Winfrey
a5fcc3f1df
Ensure private field definitions throw when accessed via external syntax
2019-01-17 17:17:53 -08:00
Rick Winfrey
4998421038
Compare directly against SomeError ... rather than String values
...
Co-Authored-By: Rob Rix <robrix@github.com>
2019-01-17 14:02:54 -08:00
Rick Winfrey
548cfb9dd3
Add AccessControlError to Eq1 instance of EvalError
...
This was preventing the specs from allowing an equality check of `AccessControlError`s, resulting in a strange null diff that appeared to be wrong (but was defaulting to `False` because `AccessControlError` was in the fall through case)
Co-Authored-By: Rob Rix <robrix@github.com>
2019-01-17 14:01:58 -08:00
Rick Winfrey
c7b1d13ab0
Compare against strings
2019-01-17 12:50:33 -08:00
Rick Winfrey
ad57ac0967
Add missing case
2019-01-17 10:45:58 -08:00
Rick Winfrey
d4abe75456
Merge branch 'master' into visibility-resolution
2019-01-16 18:31:44 -08:00
Rick Winfrey
bf3ff6154a
Update tests for new AccessControl / Relation split
2019-01-16 18:20:33 -08:00
Rick Winfrey
12e63cac6d
Comment this for now
2019-01-16 18:19:51 -08:00
Rick Winfrey
2ba74ef97d
Fix lints
2019-01-16 18:19:38 -08:00
Rick Winfrey
b407882093
Provide convenience function for loookup of declaration info within a scope by name
2019-01-16 18:05:18 -08:00
Rick Winfrey
17e43eb226
Add AccessControlError
2019-01-16 18:04:24 -08:00
Rick Winfrey
39b056df47
Update name to be more accurate
2019-01-16 17:26:39 -08:00
Rick Winfrey
5076caa2d5
Reflow
2019-01-16 17:25:49 -08:00
Rick Winfrey
5f5df139ed
Update lookupDeclaration to lookupSlot
...
The old name can be confusing, but we are actually returning `Slot` values from this function, not a `Declaration` or `Info`.
2019-01-16 17:25:18 -08:00
Ayman Nadeem
da6dd46bfe
Merge pull request #2299 from github/factor-abstract-value-as-value-effects
...
Factor AbstractValue as value effects
2019-01-16 14:18:12 -05:00
Ayman Nadeem
cef0b1cdb6
make sure haskell-tree-sitter reflects master
2019-01-16 13:53:07 -05:00
Ayman Nadeem
b9f4d36272
fix accidental revert of patrick's changes
2019-01-16 12:57:30 -05:00
Rick Winfrey
8675f7485f
Define a specialized Ord instance for AccessControl
...
This makes it possible to express an order specification for AccessControl. The leftward entity's AccessControl is evaluated according to the order specification defined by `(<=)` with the rightward entity's AccessControl. Private is the bottom most AccessControl (implying anything that is Private can see anything above it), and Public is the topmost Access Control.
Public <= Private -- False
Private <= Public -- True
Public <= Protected -- False
Protected <= Public -- True
Unknown <= _ -- Always true
_ <= Unknown -- Always true
2019-01-15 18:56:06 -08:00
Rick Winfrey
73d98bc2f9
Use declarationsByRelation
2019-01-15 17:22:30 -08:00
Rick Winfrey
0fc01f2149
💅
2019-01-15 17:22:15 -08:00
Rick Winfrey
89ad50eb9a
Rename for clarity
2019-01-15 17:22:04 -08:00
Rick Winfrey
11b670b2ee
Simplify logic b/c relation and access control are no longer intertwined
2019-01-15 17:21:34 -08:00
Rick Winfrey
03375eff11
Add helper function for retrieving declarations by AccessControl
2019-01-15 17:20:24 -08:00
Rick Winfrey
5e56ae63d8
Correct applications of declare to use AccessControl
2019-01-15 17:19:04 -08:00
Rick Winfrey
78fe6e33e2
Update applications of define to include AccessControl as a separate parameter
2019-01-15 17:13:49 -08:00
Rick Winfrey
28fc303de4
Parameterize defineBuiltIn with AccessControl
2019-01-15 17:13:12 -08:00
Rick Winfrey
3371b46b0b
Parameterize define with AccessControl
2019-01-15 17:12:44 -08:00
Rick Winfrey
df18a4fa07
Construct info with access control
2019-01-15 17:12:11 -08:00
Rick Winfrey
71646b50db
Parameterize declare with AccessControl
2019-01-15 17:11:53 -08:00
Rick Winfrey
dd85e414d6
Remove access control from Relation
2019-01-15 17:11:36 -08:00
Rick Winfrey
7326df0c65
Define access control on Info
2019-01-15 17:11:24 -08:00
Ayman Nadeem
896cfe983c
Reference Data.Abstract.Value.Concrete and not Control.Abstract.Value
2019-01-15 16:54:00 -05:00
Ayman Nadeem
2f29c9a566
disambiguate
2019-01-15 16:47:40 -05:00
Ayman Nadeem
790bf4dd1c
refactor do block using monad laws
2019-01-15 16:35:10 -05:00
Ayman Nadeem
12ad3a8a37
remove superfluous parens
2019-01-15 16:33:39 -05:00
