github/semantic
1
1
Fork 0
mirror of https://github.com/github/semantic.git synced 2024-12-24 07:25:44 +03:00
Code Issues Projects Releases Wiki Activity
27,789 Commits 19 Branches 16 Tags 46 MiB
2eb1280681
Commit Graph

27789 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rick Winfrey
f8645c43b5 Add test case 2019-02-08 17:41:16 -08:00
Rick Winfrey
2c5aeebf3e Fix assignment bug 
The following Python code:

class WatchInformation(NamedTuple):
    reason: str
    actor_id: Optional[int]
    inserted_at: Optional[str]

Is valid and parses correctly, but we failed to assign because we expected a value (and not just a type) for the assignment statements (e.g. `reason: str`).
 2019-02-08 17:25:11 -08:00
joshvera
4f388cdbf2 Move nameTerm eval until after we've evaluated the module 2019-02-08 16:59:44 -05:00
Timothy Clem
6083803d68 Bring in twirp-haskell and generate everything from protos 2019-02-08 13:52:34 -08:00
joshvera
e9d90c0404 Map identifiers in functions to required parameters 2019-02-08 16:41:14 -05:00
joshvera
25fea11c13 remove Data.GitHub.Spec 2019-02-08 15:52:48 -05:00
joshvera
e7ea1aa204 Fix Alias and Import instances 2019-02-08 15:47:03 -05:00
joshvera
867d1867c0 remove Data.GitHub.Spec 2019-02-08 15:46:46 -05:00
Patrick Thomson
7db320f6a5 Consolidate a number of unused modules. 2019-02-08 14:43:15 -05:00
joshvera
74c7737672 more hints 2019-02-08 14:29:01 -05:00
Patrick Thomson
6b5f5c11de Gut Semantic.Lens and move lensy declarations near their datatypes 2019-02-08 14:14:19 -05:00
joshvera
6ad4152935 Fix references to names 2019-02-08 14:10:17 -05:00
joshvera
95487929db lints 2019-02-08 13:40:56 -05:00
Patrick Thomson
fbf4b443b4 Move tag to its own file and add a couple lenses 2019-02-08 12:05:59 -05:00
Patrick Thomson
6a498f3d67 Merge branch 'indexer-tags' of github.com:github/semantic into indexer-tags 2019-02-08 11:38:15 -05:00
Timothy Clem
7485aa8252 Merge pull request #2375 from github/remove-extraneous-proto-encoding 
Remove extraneous Message(1), Named(1), and other Proto instances
 2019-02-08 08:16:27 -08:00
joshvera
4618ec8882 remove import 2019-02-07 18:19:16 -05:00
joshvera
5d428d22be Add type sig to evalAliasNameAndSpan 2019-02-07 18:19:11 -05:00
joshvera
993037483f Use paramSpan for params 2019-02-07 18:18:54 -05:00
joshvera
87ce3a8851 hlints 2019-02-07 18:13:11 -05:00
Timothy Clem
fbeb32de67 Can remove -fno-warn-orphans now 2019-02-07 11:20:54 -08:00
Timothy Clem
50bedeb689 Remove extraneous proto encoding/decode from our internal datatypes 2019-02-06 14:55:43 -08:00
Timothy Clem
bfb7806632 Merge pull request #2372 from github/remove-grpc-from-dockerfiles 
Remove grpc dependencies from dockerfiles
 2019-02-06 13:11:08 -08:00
Timothy Clem
b662421c67 Merge branch 'master' into remove-grpc-from-dockerfiles 2019-02-06 11:19:00 -08:00
Timothy Clem
780fdf0b11 Merge pull request #2373 from github/twirp-specs 
Integration tests for Twirp RPC endpoints + Twirp errors
 2019-02-06 11:18:42 -08:00
Timothy Clem
2ec1b74bfb Merge pull request #2374 from github/remove-grpc-doc-references 
Update docs to remove grpc references
 2019-02-06 09:46:36 -08:00
Timothy Clem
ee700b465d Oh yeah, don't need these 2019-02-06 09:44:04 -08:00
Timothy Clem
1342f2f52f Merge branch 'master' into twirp-specs 2019-02-06 09:06:27 -08:00
Timothy Clem
e15553a97c Merge pull request #2369 from github/second-wait 
Block on async parsing thread after timeout
 2019-02-06 08:58:51 -08:00
Timothy Clem
ee8d406c58 Merge branch 'master' into twirp-specs 2019-02-06 08:47:11 -08:00
Rick Winfrey
8f57b5d08b Don't need _ <- pattern 2019-02-05 13:56:55 -08:00
Patrick Thomson
cd7aaf6c17 Export lists and comments. 2019-02-05 16:29:46 -05:00
Timothy Clem
27b242a2cf Test a bunch of failure cases 2019-02-05 11:16:21 -08:00
Timothy Clem
f48d1ecf04 Not using this 2019-02-05 11:15:12 -08:00
Timothy Clem
ccc67eb355 Test only flag to force failure of parsing 2019-02-05 11:15:03 -08:00
Patrick Thomson
5f719f7d17 Restore deleted comment. 2019-02-05 13:54:07 -05:00
Patrick Thomson
ba2a270072 Document the Wrapped newtype. 2019-02-05 13:52:29 -05:00
Rick Winfrey
9f2820feaa Merge branch 'second-wait' of https://github.com/github/semantic into second-wait 2019-02-05 10:43:54 -08:00
Rick Winfrey
7b9ca2a0b0 Split over two lines 2019-02-05 10:43:16 -08:00
Timothy Clem
11560b473b Minor rename 2019-02-05 10:05:10 -08:00
Timothy Clem
3de377b6da Better handling of partial errors 2019-02-05 10:04:37 -08:00
Timothy Clem
2cb4d44f4a Align the :: 2019-02-05 10:04:05 -08:00
Rick Winfrey
ca04fb6495 Merge branch 'master' into second-wait 2019-02-04 19:12:16 -08:00
Rick Winfrey
3d125791ab Wait and block on the async parsing thread 
If we timeout an async parsing thread and return, but the parsing thread is still running, we can force a race condition in which we delete the parser before it's completed on the async thread. This patch blocks on the parsing thread until it is complete before we clean up the parser. But this might have unintended consequences for the downstream consumer (i.e. github/github).

Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2019-02-04 16:23:36 -08:00
Timothy Clem
8267613081 Merge pull request #2366 from github/refactor-runTask-log-request-ids 
Refactor runTask always log request ids
 2019-02-04 16:07:52 -08:00
Timothy Clem
ed47f27c1f Fix lints now that we are on a newer version of hlint 2019-02-04 15:19:21 -08:00
Timothy Clem
edc9adb197 Install and use hlint directly 2019-02-04 15:19:10 -08:00
Timothy Clem
b2ae020f26 Merge branch 'master' into refactor-runTask-log-request-ids 2019-02-04 14:54:43 -08:00
joshvera
e99f85e7a1 Merge remote-tracking branch 'origin/master' into indexer-prototype 2019-02-04 17:17:45 -05:00
Patrick Thomson
76a6b21d77 Better benchmarks + strategic inlining. 2019-02-04 16:56:31 -05:00