Commit Graph

1803 Commits

Author SHA1 Message Date
Peter Wicks Stringfield
5737f5185f
Delete unused utilities for controlling logging. (#764)
* Delete unused utilities for controlling logging.

Delete withFileLogging, logConfig, and noLogConfig.

Logging is turned on by hlsCommand. Should we ever want to disable it for a
certain test, we would create a new version of hlsCommand, say, hlsCommandNoLog.

* Delete unused import.

Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>
Co-authored-by: Junyoung Clare Jang <jjc9310@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-01-06 09:11:28 +00:00
Potato Hatsue
bf76edbb51
Fix wrong splice plugin component name in hie.yaml (#1162) 2021-01-06 05:47:32 +00:00
Ben Simms
7878c0ca0e
Fix #723 (Instance declarations in hs-boot files result in GHC errors) (#781)
* Fix #723

* Update boot test to have instance declarations

* Correct expected location of 'f' in boot-def-test

* Missed TemplateHaskell pragma from boot test

* Fix comment placement

Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>
Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-01-05 18:17:39 +00:00
Hiromi Ishii
8d5cbe1ea2
Splice Plugin: expands TH splices and QuasiQuotes (#759)
* Implements splice location detection

* Corrects detection logic

* Changed to use (bogus) message for code action

* Splice location

* Extract `Ide.TreeTransform` as an independent package

* It once worked, but stops...

* Now it works for inplace expansion for expressions

* generalises tree transformation to general AST element

* Done for Types and Patterns!

* Disabled "commented" style of expansion

* kills redundant imports

* Updates cabal.project

* Nix fix

* Nix fix, fix

* Throws away loading hacks entirely

* Type adjusted for inverse dependency

* Resolves merge conflicts

* WIP: Support hover and goto definition for top-level splices

I can't work out how to properly integrate this information into the
.hie file machinery. Perhaps it would be better to upstream this.

* Modifies splice information to store both spliced expression and expanded ones as well

* Avoid name collision

* formatting erros

* Safer error handling

* Rewrote using updated ghcide  `TypeCheck` results

* Use `liftRnf rwhnf` to force spine of lists

* Stop using `defaultRunMeta` directly to avoid override of preexisting hooks

* Error report

* Add splice information into HIE generation.

* Resolves interace conflict

* Add test

* Changes to use ParsedModule to detect Splice CodeLens

* formatted

* Implements golden test

* mzero for HsDecl

* Decl Splice

* Workaround for Decl expansion and support type-errored macro expansion.

* Only setting up dflags correcly would suffice

* Removes lines accidentally added

* Regression tests for Declaration splice and kind-error ones

* Workaround for GHC 8.8

* Revert "Workaround for GHC 8.8"

This reverts commit 056f76971f.

* Unsupport pattern splices GHC 8.8

* Corrects line position in GoToHover

* Increases wait time

* Includes only related changes only

* Optimises `something'`

* Adds hie.yaml

* circie ci: Modifies stack-8.10.3.yaml

* Forgot to update dflags in auto-expansion with default strategy

* Forgot to add golden file

* A dummy commit to run CI

* Workaround for GHC 8.8 pattern splices

Co-authored-by: Matthew Pickering <matthewtpickering@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-01-05 15:34:06 +00:00
Thomas Winant
8b7090fb94
Also suggest importing methods without parent class (#766)
* Make it possible to choose the code action in extendImportTests

Let the order of the expected code actions dictate which one to execute, i.e.,
the first one. This means we no longer test the *order* of the suggested code
actions. Through this simple change, we can now test the execution of a code
action that doesn't come first in the list of suggested code actions.

* Suggest imports without the parent class

When suggesting to import a method `m` of class `C` from module `M`, in addition
to the suggestions `import M` and `import M (C(m))`, also suggest importing the
method without mentioning the enclosing class: `import M (m)`.

Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-01-05 10:54:49 +00:00
Peter Wicks Stringfield
840dd3d3cb
Delete unused testdata (#763)
* Delete test/testdata/wrapper/*.

This is all dead code. It was brought over from haskell ide engine, but we don't
use it.

Note:
We are deleting test/testdata/wrapper
We are NOT deleting test/wrapper/testdata

wrapper/testdata contains live testdata, which is being used to test that
haskell-language-server-wrapper can load the appropriate version of
haskell-language-server based on the environment that it is running in.

* Delete HaRe test files.

These are dead code, they are very simple so they aren't likely to be useful
when writing new tests, and they have "HaRe" in the name even though HaRe is
gone, which adds mental burden.

* Delete unused test datafiles.

These all came over from Haskell IDE Engine, and we aren't using them. So lets
clean up by deleting them.

Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>
Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-01-05 07:14:37 +00:00
Peter Wicks Stringfield
24ec53a2ab
Update links to issues/PRs in ghcide tests. (#1142)
All ghcide issues have been transferred to HLS.

All PRs open at ghcide archive time were transferred, but closed and merged
ghcide PRs were left behind.

Before this commit we have:
1. Full links.
2. Numbers like "#xxx" or "-- xxx", referring to ghcide issues/PRs.

After this commit we have:
1. Full links.
2. Numbers like "#xxx" or "-- xxx", referring to HLS issues/PRs.

Note: "ghcide#xxx" and "hls#yyy" are unambiguous, github will never make an
issue and PR in the same repository with the same number.

Note: "#xxx" is definitely ambiguous, there can be a "ghcide#xxx" and an
"hls#xxx" which are totally unrelated. One could even be an issue while the
other is a pull request.

Relevant mappings:
ghcide#7   |-> hls#1129
ghcide#71  |-> hls#1102
ghcide#123 |-> hls#713
ghcide#137 |-> hls#1073
ghcide#246 |-> hls#1030
ghcide#247 |-> hls#1029
ghcide#248 |-> hls#1028
ghcide#249 |-> hls#717
ghcide#250 |-> hls#1027
ghcide#273 |-> hls#1017
ghcide#274 |-> hls#1016
ghcide#283 |-> hls#1012
ghcide#310 |-> hls#767
ghcide#315 |-> hls#1002
ghcide#614 |-> hls#891
ghcide#847 |-> hls#831

Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>
Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-01-05 05:49:43 +00:00
Peter Wicks Stringfield
0b0a6a75e5
Enable more tests (#1143)
* Make rename tests compile.

(They can't pass since we don't have a renamer yet.)

* Enable some more tests.

Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>
Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-01-05 04:24:58 +00:00
Kostas Dermentzis
93ab0ea808
fix suggestAddTypeAnnotation regex (#760)
Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>
Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-01-05 02:03:12 +00:00
Jan Hrcek
0db2e28b48
Remove no longer needed git submodule update (#1145)
Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>
2021-01-04 20:57:00 +00:00
Javier Neira
1269d89d08
Merge pull request #1151 from jneira/mergify/jneira/config-update
Mergify: create configuration
2021-01-04 20:38:18 +01:00
Javier Neira
dd28adae94
Merge branch 'master' into mergify/jneira/config-update 2021-01-04 17:11:40 +01:00
Javier Neira
1454b7be1f
Merge pull request #1152 from pepeiborra/circleci
Streamline CircleCI jobs
2021-01-04 17:05:36 +01:00
Javier Neira
9c4b5f77e6
Merge branch 'master' into circleci 2021-01-04 15:41:38 +01:00
Javier Neira
44ea5a59c9
Merge pull request #1156 from haskell/revert-1154-auto-cancel
Revert "Auto cancel redundant workflows (attempt #2)"
2021-01-04 15:40:52 +01:00
Javier Neira
8efeb0d4d0
Merge branch 'master' into circleci 2021-01-04 14:29:21 +01:00
Javier Neira
e433dbe416
Merge branch 'master' into revert-1154-auto-cancel 2021-01-04 10:39:50 +01:00
Javier Neira
4ff9cf3c41
Merge branch 'master' into mergify/jneira/config-update 2021-01-04 10:39:28 +01:00
Javier Neira
eb58f13f7b
Merge pull request #1153 from jneira/prepare-0.8.0-2
Prepare 0.8.0 (versions)
2021-01-04 10:31:25 +01:00
Pepe Iborra
21116e97a3 Revert "Auto cancel redundant workflows (attempt #2) (#1154)"
This reverts commit 7fa3ff6a64.
2021-01-04 07:04:37 +00:00
Javier Neira
ca5544179c
Merge branch 'master' into prepare-0.8.0-2 2021-01-03 23:14:18 +01:00
Javier Neira
47fb4ea1cf
Merge branch 'master' into mergify/jneira/config-update 2021-01-03 23:03:30 +01:00
Pepe Iborra
7fa3ff6a64
Auto cancel redundant workflows (attempt #2) (#1154)
* Auto cancel redundant workflows (attempt #2)

* empty commit to test
2021-01-03 20:12:02 +00:00
jneira
529d07c375 Update ghcide changelog for 0.7.0 2021-01-03 20:27:56 +01:00
Javier Neira
c2ce8dec9b
Rephrasing mention to libs versions
Co-authored-by: Pepe Iborra <pepeiborra@me.com>
2021-01-03 19:59:01 +01:00
jneira
a6e9b696d6 Remove auto delete pr branches 2021-01-03 19:24:40 +01:00
Pepe Iborra
c51c56dc36 delete comment - no longer applies 2021-01-03 16:12:48 +00:00
Pepe Iborra
47aa2bbd69 Really skip running tests 2021-01-03 15:50:43 +00:00
jneira
075df414e8 Require newest ghcide version in hls 2021-01-03 15:58:15 +01:00
jneira
ae16372147 Mention libs versions and ghcide-0.6.0.2 changelog 2021-01-03 15:51:12 +01:00
jneira
527c2e5a70 Bump up hls version 2021-01-03 15:42:05 +01:00
jneira
e7b9cc9dac Bump up ghcide version 2021-01-03 15:41:12 +01:00
jneira
61dd1207e9 Bump up hls-plugin-api version 2021-01-03 15:40:53 +01:00
jneira
c224ccc89e Update hackage index 2021-01-03 15:39:08 +01:00
jneira
eb48bf971d Fix build for macOS 2021-01-03 15:37:19 +01:00
Javier Neira
3d8e5e64da
Use squash as merge method 2021-01-03 15:14:36 +01:00
Javier Neira
142431bd17
Remove circleci cabal job 2021-01-03 14:12:47 +01:00
Javier Neira
aa52d7d895
Use smart+fasttrack for strict merges 2021-01-03 14:12:25 +01:00
Pepe Iborra
193b5a9105 skip running tests in CircleCI
Tests are already covered by the Github Actions
2021-01-03 13:10:17 +00:00
Pepe Iborra
d7bdefe88d Clean up CircleCI config 2021-01-03 09:47:43 +00:00
Javier Neira
6b0740c476
Merge pull request #1149 from jneira/prepare-0.8.0
Prepare 0.8.0 release
2021-01-03 08:44:47 +01:00
jneira
c2860a9e41 Create mergify config 2021-01-03 08:42:05 +01:00
jneira
ee22a8ca14 Add missing pr in ghcide changelog 2021-01-03 07:15:49 +01:00
jneira
08b4b827e0 Add changelog for 0.8.0 2021-01-02 23:40:12 +01:00
jneira
f0a01fa804 Fix markdownlint warnings 2021-01-02 23:31:50 +01:00
Pepe Iborra
90966db236
Fix extend imports regression (#769)
* Update exports map for non FOIs

* Fallback to GHC suggestions if exportsMap not accurate

* Tests
2021-01-02 19:22:28 +00:00
Javier Neira
4d33fd192b
Merge pull request #721 from jneira/mergepocalypse-8.10.3
Add ghc-8.10.3 support after merging ghcide repo
2021-01-02 11:55:03 +01:00
Javier Neira
4c2c8f42c8
Merge branch 'master' into mergepocalypse-8.10.3 2021-01-02 10:23:35 +01:00
Pepe Iborra
9649165489
Perform memory measurement on SIGUSR1 (#761)
* Perform memory measurement on SIGUSR1

* remove nub

* Update the open telemetry docs

* remove redundant bang

Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>
2021-01-02 08:51:28 +00:00
Pepe Iborra
07145e4789
Merge branch 'master' into mergepocalypse-8.10.3 2021-01-02 07:30:05 +00:00