hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-12-15 17:31:56 +03:00
Code Issues Projects Releases Wiki Activity
5,358 Commits 138 Branches 441 Tags 4.4 GiB
3e3ebe9743
Commit Graph

5358 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Solomon
3e3ebe9743 Update Kriti to 0.3.3 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6430
GitOrigin-RevId: 5430f6c6b89f5f5dd65bd6ecf086fa5516a95140
 2022-10-20 00:59:23 +00:00
Antoine Leblanc
49d0594759 [server] prune join fields of remote relationships to remote schema (close hasura/graphql-engine#8345) 
## Description

This PR fixes hasura/graphql-engine#8345: when creating the final representation of a remote relationship to a remote schema (a `RemoteJoin`), we would mistakenly label ALL join fields in the selection set as being relevant to that one relationship: if there are more than one remote relationship to process in that selection set, that would be the union of all their join fields. The problem with this error is that, when processing remote relationships, we correctly ignore all the ones for which at least one join key is null. Consequently, this error would result in us ignoring remote relationships for which an _unrelated_ join key was null, resulting in that data missing in the final JSON result.

This PR simply ensures that the aggregation of fields that are passed to `createRemoteJoin` is pruned to only contain the fields relevant to the join being created. This is a very small change, and the bulk of this PR is the regression tests.

## Changelog

__Component__ : server
__Type__: bugfix
__Product__: community-edition

### Short Changelog

fix remote relationship to remote schema sometimes being erroneously null when multiple relationships are defined on the same table / graphql object ([#8345](https://github.com/hasura/graphql-engine/issues/8345))

### Long Changelog

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6420
GitOrigin-RevId: eb54462724b007f80b674dcf234adf6d9cfaaf79
 2022-10-20 00:11:51 +00:00
Brandon Simmons
cc6f1c3b69 multitenant: make ourIdleGC parameters tunable, and with better defaults (SRE-191) 
Context: https://hasurahq.atlassian.net/browse/SRE-10

Also remove an overlapping instance.

-----

The new flags if this needs to be tweaked on production by SRE are:

- --idleGCIdleInterval : "When the system has been idle for idleGCIdleInterval we may opportunistically try a major GC to run finalizers"
-  --idleGCMinGCInterval : "We never run an opportunistic GC unless it has been at least idleGCMinGCInterval seconds since the last major GC"
-  --idleGCMaxNoGCInterval : "If it has been longer than idleGCMaxNoGCInterval since the last major GC, force a GC to run finalizers"

Be aware: we may see memory usage grow to higher peaks than before, especially when under load

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6449
GitOrigin-RevId: 662d2f968f0d73b3b6eebb857c49aaede3312705
 2022-10-19 21:36:56 +00:00
Nicolas Beaussart
dd493c1781 ci: bump memory to 4gb for node related pipelines 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6436
GitOrigin-RevId: 4dd6779bdfbbba40e47de88b05be30f62b545d22
 2022-10-19 21:01:34 +00:00
Samir Talwar
5691d95ecf Delete docs-old. 
Seriously, do we actually need it?

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6441
GitOrigin-RevId: efbe436981c303f4881a5ccff01487b12248be7e
 2022-10-19 14:25:02 +00:00
Shraddha Agrawal
34e731d296 docs: remove duplicated warnings in preview app docs 
This PR removes the duplicate warnings in preview app docs.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5068
Co-authored-by: Rob Dominguez <24390149+robertjdominguez@users.noreply.github.com>
GitOrigin-RevId: eac156c9423f60c7b1a1147f4b2bff1a832a7d6d
 2022-10-19 13:25:25 +00:00
Aravind K P
4b1ab8bf67 cli: refactor metadataobject.Object interface to use std error 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6387
GitOrigin-RevId: 5a18fb9b26eaf9bc9a1b55ae79ce18e4147f4aa3
 2022-10-19 12:52:46 +00:00
Vijay Prasanna
ff94621ea0 chore (console): format changes on mockServiceWorker.js 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6431
GitOrigin-RevId: ff59eaab924e3884ac65badeb3283e9307d8d753
 2022-10-19 10:16:34 +00:00
Gil Mizrahi
c6fdb44388 Test on_conflict on cockroachdb. 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6423
GitOrigin-RevId: 58e1c3f60934332720cadb74c8cb29730e797287
 2022-10-19 08:51:49 +00:00
Daniele Cammareri
e91cba835b fix remote schema permissions with null default value 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6414
GitOrigin-RevId: 1b902b1ac7c541bdd79f933ef6fc008f875b517a
 2022-10-19 06:46:55 +00:00
Vijay Prasanna
67087043c9 feature (console): allow user to view and update existing filter/sort(s) on GDC browse rows 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6344
GitOrigin-RevId: 5118ca2299753a0c8742662e5493bb97baf16d9c
 2022-10-19 03:46:22 +00:00
Auke Booij
58e5bba4f8 Improve the tone of the OSS issue templates by removing questions 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6246
GitOrigin-RevId: 8e62587cbe36fa40124d22770c76322b5e716fde
 2022-10-19 02:21:46 +00:00
Daniele Cammareri
e13ff5babe fix remote schema permissions with interfaces 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6417
GitOrigin-RevId: c3df729df040ea11ec61cf75536c8dec6b7cdbed
 2022-10-18 21:21:29 +00:00
Gil Mizrahi
666f34d564 Add cockroach to default and on_conflict tests 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6412
GitOrigin-RevId: 637abad70096a06c39a13b9c8683444e2bebdecf
 2022-10-18 19:48:27 +00:00
Chris Martin
bf87246126 Chrism/docs/guide bestpractices metadata 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6027
GitOrigin-RevId: 6186ea1de1964a4b91b05a8417983ec312ca53f7
 2022-10-18 18:59:34 +00:00
Philip Lykke Carlsen
d81571f928 Add support for explain in CockroachDB 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6415
GitOrigin-RevId: d60363d6f466a764b79c887631f9e3f094946440
 2022-10-18 16:49:03 +00:00
Tom Harding
346640fdf1 Add tests for query variables 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6383
GitOrigin-RevId: 87345b60ca2206aac097740109fedfeff045598a
 2022-10-18 15:55:22 +00:00
Rikin Kachhia
53af3157fc docs: point EE release notes to changelog site 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6421
GitOrigin-RevId: e29fb208cde605ea0adcd124264abe3ee3711208
 2022-10-18 14:54:21 +00:00
Nicolas Beaussart
7a7688ca9d platform: fix graphql codegen in action and graphiql editor 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6404
GitOrigin-RevId: f20eaece35f2c0b7d7db8b65908b608a79afcdba
 2022-10-18 14:24:14 +00:00
Daniele Cammareri
fbb0fbbe0b fix remote schema permmission when there are arguments 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6407
Co-authored-by: Varun Choudhary <68095256+Varun-Choudhary@users.noreply.github.com>
GitOrigin-RevId: faa0d05bcee2ad033c7a610d5c6cf27bd6af09bf
 2022-10-18 13:53:38 +00:00
Samir Talwar
68f4779908 packaging: Rebuild the base images to get PostgreSQL Client 15. 
This is required to get the latest version of `pg_dump`, which is used
by a few features (including the CLI command, `hasura seed create`).

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6393
GitOrigin-RevId: 31442fff669af9e5c987128e10c6801f8ed9fb95
 2022-10-18 13:27:24 +00:00
Varun Choudhary
7dbb3ab80b docs: update role-based allow list version for console support 
Edit the note [here](https://hasura.io/docs/latest/security/allow-list/#role-based-allow-list) to make it clear that console support for role-based allow list is available from `v2.13` and server support is available from `v2.3`.

**New note looks like -**

![Screenshot from 2022-10-18 12-35-19](https://user-images.githubusercontent.com/68095256/196362090-a866ae70-1464-4836-9237-aa603924a689.png)

**Related issues**

https://hasurahq.atlassian.net/browse/GS-191

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6402
GitOrigin-RevId: 5e1c74b275b0535a6156c3999be98aaeccfb3a68
 2022-10-18 12:04:46 +00:00
Samir Talwar
8435d7a5fb server: Update the contributing guide. 
* The versions for some tools were out of date; updated accordingly.
* The link to the Dockerfile was broken.
* Included instructions for Nix.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6403
GitOrigin-RevId: 3acbafe90e4bb9267dcdb2dce5e205773a14dfc9
 2022-10-18 09:50:46 +00:00
Tom Harding
17ea024884 Add tests for query fragments 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6385
Co-authored-by: Gil Mizrahi <8547573+soupi@users.noreply.github.com>
GitOrigin-RevId: 2cb3255cf9c1aea9e010affecc5f038ea6aa6ab9
 2022-10-18 09:17:41 +00:00
Philip Lykke Carlsen
032c25240b fix: Disable subscriptions in CockroachDB 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6368
GitOrigin-RevId: b1434b830d3ef84e13c7abb64ecb6ef3c1878a55
 2022-10-18 08:44:34 +00:00
Tom Harding
c1b66d7243 Add tests for query aliases 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6384
Co-authored-by: Gil Mizrahi <8547573+soupi@users.noreply.github.com>
GitOrigin-RevId: 331baf9ec41bc6b2d618362e87defa44ca39da40
 2022-10-18 08:11:06 +00:00
Solomon
1e8846d27d Refactor GDC Fixture Modules for Hspec Tests 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6358
GitOrigin-RevId: 19b63d1db75998875463eb2a88e938eba688ecb0
 2022-10-18 05:33:46 +00:00
Vijay Prasanna
2298c21ae0 feature (console): add storybook components for local relationships for GDC 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6290
GitOrigin-RevId: aadac5dc29db2d1fa6550a604e04a6baa3b7c661
 2022-10-18 04:58:13 +00:00
Daniel Chambers
5c51ff4288 Fix conflicting data connector comparison exp GraphQL types 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6394
GitOrigin-RevId: c272e8aad426a18ccadfec005e03d5b2669e035c
 2022-10-18 04:19:12 +00:00
Mohd Bilal
51424c0857 cli: use github.com/stretchr/testify/require assertions in internal/hasura/pgdump tests 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6364
GitOrigin-RevId: c6c99c092e6992d3905e1a1f58ea0373911238f8
 2022-10-18 03:24:17 +00:00
Solomon
15ac95d446 Adds GDC Fixture to query specs 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6352
GitOrigin-RevId: 2abba0743648e7f24baddd7591eee737ba795869
 2022-10-18 02:48:33 +00:00
Solomon
5e85b0c534 Mutable Sqlite GDC Fixture - GDC-455 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6351
GitOrigin-RevId: bdcb3cfa694dda6a0d1473331bc689aae418a5bb
 2022-10-17 22:53:14 +00:00
Abhijeet Khangarot
49a2822dbe console: UI fixes for neon banner in connect db page 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6376
Co-authored-by: Rishichandra Wawhal <27274869+wawhal@users.noreply.github.com>
GitOrigin-RevId: 8f2ec961be370097b48b684211606d34dbaa002d
 2022-10-17 19:04:52 +00:00
Mohd Bilal
aa70c62bdd cli: port internal/hasura/v2query package to use internal/errors 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6379
GitOrigin-RevId: 787e5cce03006b0d248a79797923efb8fe6fa7b4
 2022-10-17 18:28:56 +00:00
Mohd Bilal
081b9163c4 cli: port internal/hausra/sourceops/postgres to use internal/errors 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6374
GitOrigin-RevId: 8b52f7409799d7ac3b43937cc66837ab3861cd03
 2022-10-17 17:56:02 +00:00
Mohd Bilal
7044bf194d cli: port internal/hasura/v1graphql package to use internal/errors 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6322
GitOrigin-RevId: 1f1c8f13bd688881c48f3381dc9e3e7bacf5fc0c
 2022-10-17 17:02:00 +00:00
Erik Magnusson
63ef6e722c console: refactor the data pages edit tab 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6380
GitOrigin-RevId: 15a96fd2f743d84570026aeeb75efbcbd9386c2a
 2022-10-17 16:10:42 +00:00
Tom Harding
a4a7d06000 Add (failing) remote relationship test for CockroachDB 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6315
GitOrigin-RevId: dd15b1743343d8d1156cc18462b24535f5e05f56
 2022-10-17 15:19:03 +00:00
Daniel Harvey
f4f4221d04 tests: Docker Compose healthchecks 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6282
Co-authored-by: Gil Mizrahi <8547573+soupi@users.noreply.github.com>
Co-authored-by: Samir Talwar <47582+SamirTalwar@users.noreply.github.com>
GitOrigin-RevId: c2b1f958364ce5e1ef704fa1275d18ac810ca35b
 2022-10-17 13:20:31 +00:00
Varun Choudhary
3757731228 console: Implemented batch_size API limit to tackle GraphQL batching attacks 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6337
Co-authored-by: Daniele Cammareri <5709409+dancamma@users.noreply.github.com>
GitOrigin-RevId: 826bbbf33ad9608db7807d919ba685d1b15c4e32
 2022-10-17 12:39:02 +00:00
Samir Talwar
ed4d948adf server/tests-py: Make run.sh work on aarch64. 
This helps with running the tests locally on a recent Mac.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6304
Co-authored-by: Daniel Harvey <4729125+danieljharvey@users.noreply.github.com>
GitOrigin-RevId: eb5c6a185f68b216c94df2581acf71906cce7872
 2022-10-17 12:08:25 +00:00
Varun Choudhary
b60b38d70b console: show total max connections in pool settings fields for CE/EE/Cloud 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6080
GitOrigin-RevId: aafa8350f8d00d3f8ddb6e51964f06a25455aac5
 2022-10-17 10:38:34 +00:00
Mohd Bilal
06138634bc cli: use github.com/stretchr/testify/require assertions in internal/hasura/catalogstate tests 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6360
GitOrigin-RevId: 1c0f1666fb0ca70d7cf00e6584c549f1bf044c69
 2022-10-17 09:57:59 +00:00
Vijay Prasanna
f15e3f0148 feature (console): use list_source_kinds to get available drivers for the connect DB page 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6359
GitOrigin-RevId: 2d75899258d1581c840ef14b161532f0f10a7b5e
 2022-10-17 09:05:34 +00:00
Rakesh Emmadi
5666161ac9 server/multitenant: resize sources' connection pools when a cloud project is scaled, global connection pooling 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5708
Co-authored-by: Naveen Naidu <30195193+Naveenaidu@users.noreply.github.com>
Co-authored-by: pranshi06 <85474619+pranshi06@users.noreply.github.com>
Co-authored-by: Puru Gupta <32328846+purugupta99@users.noreply.github.com>
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
Co-authored-by: Anon Ray <616387+ecthiender@users.noreply.github.com>
GitOrigin-RevId: 513d497548d89b397d4a299355b11607daec3c7e
 2022-10-17 08:06:12 +00:00
Solomon
4700ac44fb Webhook Transforms: Move RequestCtx into a type family 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5975
GitOrigin-RevId: 08ad528b2600379deb4cef9d39968126c7c745d8
 2022-10-16 03:55:06 +00:00
Shraddha Agrawal
60411b95e5 docs: update region migration docs 
fix for Jira ticket: https://hasurahq.atlassian.net/browse/CPS-251

This PR adds more context why user's should change the region of their cloud project to a region closer to their database. This is part of the changes of the MRAU project.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6312
GitOrigin-RevId: 3868b0659bc6cfcdc4861bda8433ed342049c6b5
 2022-10-14 13:11:36 +00:00
Solomon
011e7be360 Dispatch JSON serialization by BackendType for Table Names in Test Suite 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6350
GitOrigin-RevId: 736a41592c3acd018fa1777dafc0b2e8098d2dc6
 2022-10-14 01:47:49 +00:00
Rob Dominguez
c326cf4637 docs: reformat links 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6331
Co-authored-by: Sean Park-Ross <94021366+seanparkross@users.noreply.github.com>
GitOrigin-RevId: 6c059c65f3c260c15cc565d47e13a3a479ca766c
 2022-10-13 19:48:32 +00:00
Daniel Chambers
6d8231903c Reworked scalar type determination in SQLite agent [GDC-455] 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6335
GitOrigin-RevId: baf7619a0c705bddcbd75f8842bf8fcfeeaa05c9
 2022-10-13 19:03:25 +00:00