Commit Graph

5273 Commits

Author SHA1 Message Date
Luca Restagno
950836849d console: fix alter primary key for cockroachdb
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6292
GitOrigin-RevId: 0f449e08837c174627fb69ee611411b44ba88b62
2022-10-11 16:09:58 +00:00
Samir Talwar
1ffc19367d Push the Nix dependency management configuration to the OSS repository.
We don't need to hide it.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6255
GitOrigin-RevId: 9b46511c6b274dd7e8e52ee74644dc86c7d75872
2022-10-11 15:33:22 +00:00
Tom Harding
2f94bcf6c7 Add Update tests for Cockroach
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6271
GitOrigin-RevId: ecb38e084f433e29e3ae4e2a6f2039907afcf6d3
2022-10-11 15:18:56 +00:00
Tom Harding
4237c56419 Add more Cockroach tests to api-tests
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6189
Co-authored-by: Daniel Harvey <4729125+danieljharvey@users.noreply.github.com>
GitOrigin-RevId: fb03fc2f21ef392f63a5d0d4164ff75cc215692c
2022-10-11 14:48:38 +00:00
Vijay Prasanna
690c05d33a feature (console): Enable browse rows for GDC sources (supports pagination, filter, limit & sort)
Adds a browse rows component for GDC sources
Cleans up the implementation of the FilterSection and additonal refactoring

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6178
GitOrigin-RevId: 82c3f729edb05778e81b08254608797617b45aaf
2022-10-11 14:17:42 +00:00
Aravind K P
a949af5e14 cli: refactor httpc package to use error framework
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6227
GitOrigin-RevId: fcf9ee64345309ddcba95e4369a6564defa54fc0
2022-10-11 13:40:46 +00:00
Gil Mizrahi
3a73997555 server/cockroach: fix long identifiers tests for cockroach
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6257
GitOrigin-RevId: 94aa7e59159db2130718285221db88f20ca7079a
2022-10-11 12:59:51 +00:00
Divi
2e2aab9f2f ci: catalog version update for v2.13.0
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6293
GitOrigin-RevId: cbadd0591f01ae1f038fb9d92aff68e46cc600d1
2022-10-11 12:11:34 +00:00
nevermore
08a46714d3 docs: add Neon integration docs, remove Heroku docs
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6162
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sean Park-Ross <94021366+seanparkross@users.noreply.github.com>
GitOrigin-RevId: 1c80b85df1f474e54cda332c98b93adc4339ac09
2022-10-11 11:59:42 +00:00
Daniel Harvey
f831c73e1b tests: bump CockroachDB image
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6278
GitOrigin-RevId: a7148f22b278181fccaad17d3e9c4bd61d8475d5
2022-10-11 11:49:42 +00:00
Tom Harding
d7d83d26d6 Add simple Insert tests
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6269
Co-authored-by: Samir Talwar <47582+SamirTalwar@users.noreply.github.com>
Co-authored-by: Auke Booij <164426+abooij@users.noreply.github.com>
Co-authored-by: Erik Magnusson <32518962+ejkkan@users.noreply.github.com>
Co-authored-by: Sean Park-Ross <94021366+seanparkross@users.noreply.github.com>
Co-authored-by: hasura-bot <30118761+hasura-bot@users.noreply.github.com>
Co-authored-by: Rob Dominguez <24390149+robertjdominguez@users.noreply.github.com>
Co-authored-by: Gil Mizrahi <8547573+soupi@users.noreply.github.com>
Co-authored-by: Daniel Chambers <1214352+daniel-chambers@users.noreply.github.com>
Co-authored-by: Abhijeet Khangarot <26903230+abhi40308@users.noreply.github.com>
Co-authored-by: Manas Agarwal <5352361+manasag@users.noreply.github.com>
Co-authored-by: Vijay Prasanna <11921040+vijayprasanna13@users.noreply.github.com>
GitOrigin-RevId: e522df6409137aca2209e4e686f673a389abd546
2022-10-11 11:18:26 +00:00
Philip Lykke Carlsen
ee34921d0d refactor: QualifiedIdentifier to use TableIdentifier
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6210
GitOrigin-RevId: 1fa24321396bbb68dd5f8516aab76850ebeebfa4
2022-10-11 10:43:43 +00:00
Tom Harding
4fdbda05ec Enable Postgres enums for Cockroach
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6232
GitOrigin-RevId: cc29e4932c3a24039efaf28f890a3dad97b51c3e
2022-10-11 09:09:26 +00:00
Matthew Goodwin
ae00089cd4 Add GQL Customization to connect DB form [GDW-333]
## Description 🔖

This adds the ability to edit **GraphQL Field Customization** when either connecting or editing a db connection for an agent.

This was implemented using the newest form and form components:

<img width="548" alt="Screen Shot 2022-09-29 at 3 42 16 PM" src="https://user-images.githubusercontent.com/49927862/193155139-c0eb71fb-4829-42d9-8ec1-90582fe8054a.png">

## Solution and Design 🎨

This is a fairly minimal addition that makes use of the existing `react-hook-form` compatible `Form` and components. I had to edit the zod schema with the correct properties from the spec for GQL Sources.

I created a new dir for the `CustomizationForm` and implemented it in both the Connect and Edit components.

A quick note on a directory convention I am using here:

It's fairly common to have a components folder, and then within that, have sub-directories for more complicated components.

In that model, I have found it useful to use a `parts` directory as a next level of granularity within a component directory.
This helps to avoid cluttered components folder, by optionally adding a `parts` folder inside a component's folder for pieces that you want to break out but are NOT shared with anything else.

I've done this here with a fairly simple component `src/features/ConnectDB/components/Customization/parts/SectionHeader.tsx`, but one that benefits from having it's own component.

## Review Setup 💻

Video of feature:

https://www.loom.com/share/d737afca4be04da28f6943c1c8164d6f

### Tests

Added new customization form to storybook here ->> http://localhost:6006/?path=/story/data-connect-graphql-field-customization--primary

### Note on commit history

We had some issues trying to fix my accidental commital of a package-lock.json file and ended up doing some song and dance which involved @solomon-b ending up with credit for the first few commits. Just as a note for history, his name is on them, but it's my code, so if there's something to comment on, direct it to me.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6134
Co-authored-by: Solomon <24038+solomon-b@users.noreply.github.com>
GitOrigin-RevId: 0c8891e246e5d048e70b6a8a91331f21049d1c8c
2022-10-11 07:49:03 +00:00
Lyndon Maydwell
d54bb30d3b Structured Error Protocol for Data Connectors Agents - GDW-137
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6061
Co-authored-by: Vishnu Bharathi <4211715+scriptnull@users.noreply.github.com>
GitOrigin-RevId: 855d96378030f4e01b0c74b00e20e592e51e7a49
2022-10-11 00:26:24 +00:00
Daniel Harvey
34d01caebb tests: simplify healthchecks for Pytests in Docker
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6270
GitOrigin-RevId: 70a6c1298bfaf032f6279a6575f37feb8270a392
2022-10-10 19:18:41 +00:00
Daniel Harvey
1aaa7b1b47 server: revert "fetch col_description using value from column directly"
Reverts hasura/graphql-engine-mono#6228

We are getting metadata timeouts again, this needs looking into before enabling again.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6277
GitOrigin-RevId: 397c1704834a5e2332cca50d14a46c117f34d1ca
2022-10-10 15:28:44 +00:00
Vijay Prasanna
2835a1aa98 fix (console): tree nav auto-select when table/database is present in the route
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6205
GitOrigin-RevId: 61d89f4dbd2fac0fca58c0c7eefe735856637a42
2022-10-10 12:47:01 +00:00
Abhijeet Khangarot
948ace94e7 console: Neon integraiton design updates
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6212
Co-authored-by: nevermore <31686586+OjasWadhwani@users.noreply.github.com>
Co-authored-by: Rishichandra Wawhal <27274869+wawhal@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
GitOrigin-RevId: 71cc4923a2dda178839464d91b3214456fd207fa
2022-10-10 09:48:37 +00:00
Daniel Chambers
8369cac3bd Data Connector agent data schema capabilities [GDC-479]
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6268
GitOrigin-RevId: 4ec29566d3c2ab2144dad8055b4442a4027915ec
2022-10-10 06:59:30 +00:00
Daniel Chambers
c862c64b33 Break down Data Connector agent schema tests into finer grained, more accurate, tests [GDC-479]
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6225
GitOrigin-RevId: 8eaadcc14cf4bc90a22450e924daf8cc340ed2ea
2022-10-10 02:25:09 +00:00
Gil Mizrahi
4a321e2459 docs: functions -> custom functions
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6244
GitOrigin-RevId: 999517c28791a0b8f3de1843f02232338ad00fa9
2022-10-07 19:23:41 +00:00
Auke Booij
6f6177db38 Remove some unnecessary OPTIONS_GHC pragmas
I didn't track why these were left behind. Presumably GHC 9.2 has an improved redundant constraint checker, so that explains a few. Otherwise, perhaps code got refactored along the way.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6256
GitOrigin-RevId: b6275edf3e867f8e33bdec533ce9932381d36bbb
2022-10-07 17:27:08 +00:00
Rob Dominguez
9c48313f81 docs: add SLA and reorder pages
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6240
GitOrigin-RevId: 406303a03e5258c20baa5c49f52be8d6262a7535
2022-10-07 16:43:12 +00:00
hasura-bot
7b6dae7e8e docs: Fix minor grammatical errors in faq.mdx
GITHUB_PR_NUMBER: 9075
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/9075

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6214
Co-authored-by: Varun <98093422+kVarunkk@users.noreply.github.com>
GitOrigin-RevId: d4bffff3120176e765f4050d77807bffc22c9bc3
2022-10-07 16:12:16 +00:00
Sean Park-Ross
494e270227 Docs: Wiki Restructure and remove Sphinx RST - WIP
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6059
GitOrigin-RevId: c527d01b7af8ef98fa3859930115ec44d993e444
2022-10-07 13:58:26 +00:00
Sean Park-Ross
1dc95b8c4a Docs: Wiki add documentation 'mission statement'
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6051
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
GitOrigin-RevId: 686ba92c48e15a43f37d28308730f7073e327b7f
2022-10-07 13:16:15 +00:00
Erik Magnusson
00c01197ef console: added update_many field to table field customization component
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6203
GitOrigin-RevId: 1559f1b8d4b40d2286d12aa9d8b0582915299bb5
2022-10-07 13:10:55 +00:00
Auke Booij
4c016b4c42 Clean up pg-client-hs
- Remove a few unnecessary helper functions
- Delete kind annotations
- Bring GHC warnings and language extensions more in line with those of the `graphql-engine` library
- Constrain unconstrained dependency on `hasql-pool`

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6251
GitOrigin-RevId: 10c2530f007f70cf1464cec36566ee2264589881
2022-10-07 11:56:55 +00:00
Tom Harding
1d1ab15b47 Remove parsing for functions in Cockroach
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6250
GitOrigin-RevId: 389f58a327096ef9586c7a0f35df243955f73a5d
2022-10-07 09:51:07 +00:00
Daniel Harvey
ba2e585a15 server: fetch col_description using value from column directly
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6228
GitOrigin-RevId: 8a887817ae3003bc63b49a79d3d4772b2dcea020
2022-10-07 08:42:16 +00:00
Sean Park-Ross
84c38e8a5c Docs: Fix Docker compose version issue in getting started
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6236
GitOrigin-RevId: 33ac857a6d0b0e0999de09e61a40e307d00f1574
2022-10-07 06:03:06 +00:00
Samir Talwar
585f35f271 Nix: Upgrade to GHC 9.2.4.
What fun!

Tested on x86_64 Linux and aarch64 macOS. I had to add a bunch of Haskell package overrides specifically for macOS on aarch64, but I made them apply to all macOS users because, well, it's just a couple of us right now and we're both using aarch64.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6239
GitOrigin-RevId: 4e5a20d21eb24c736e8663de3f1e05ce5705284a
2022-10-06 21:05:34 +00:00
Samir Talwar
36031d62d2 server/tests-py: Fix the run.sh and run-new.sh scripts to work with our new server-builder image.
This updates _docker-compose.yml_ to use the new image tags, and updates _run.sh_ accordingly.

While I was at it, I also added a `docker compose pull` instruction to make sure that we don't have surprises half-way through the script, and a few `echo` lines for clarity.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6235
GitOrigin-RevId: 3855f6898bd3e906c5f423d9d0d6a7031de3777a
2022-10-06 19:04:58 +00:00
Samir Talwar
f9ff7ae00c CI: Remove the custom Microsoft SQL Server image.
Now that we use the mssql-tools image for running `sqlcmd`, we no longer need this (or indeed use it very much).

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6152
GitOrigin-RevId: be8852a93889553c3ffd2ec00c0dda81b36c3d05
2022-10-06 16:21:44 +00:00
Daniel Harvey
bdf70651e8 tooling: bump .ghcversion to 9.2.4
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6226
GitOrigin-RevId: 46b9d3e118ca5394a5cb4869a020d5de0b873999
2022-10-06 14:13:39 +00:00
Luca Restagno
b0569e0eb7 console: fix e2e tests
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5557
GitOrigin-RevId: 5b07d94e7199b75546455e5702e6eaabfa5e1f7f
2022-10-06 14:13:30 +00:00
Daniel Harvey
ad53402d1d test: Check CockroachDB can query into JSONB values with a path
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6124
GitOrigin-RevId: 3de6b6c602d41d4d340c355171c10ac33582b9a5
2022-10-06 13:03:03 +00:00
Gil Mizrahi
d8452bf11c server: remove ghc libs from freeze file, update guides
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6231
GitOrigin-RevId: d877e46d7130217cd95eb9c507921e76a0009151
2022-10-06 12:27:09 +00:00
Varun Choudhary
4b79dfcb8d console: disable url field on view remote schema page
## Description 🔖

Disable URL field on view remote schema page. Earlier we are able to edit the URL name from the view remote schema page. ([VIDEO](https://user-images.githubusercontent.com/68095256/194233185-1c93722a-e8bb-4a78-9d8e-05a0eef572c3.mov))

## Related issue

https://hasurahq.atlassian.net/browse/GS-170

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6224
GitOrigin-RevId: 7a3a43a3648d6f88e66e886d34357939477bcc88
2022-10-06 11:38:22 +00:00
Varun Choudhary
bb5c1ad4d0 console: add response_transform in update_action api call
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6223
Co-authored-by: Daniele Cammareri <5709409+dancamma@users.noreply.github.com>
GitOrigin-RevId: 6687188c3fe1dc025273aa8f3bb0bac20b605a7d
2022-10-06 11:04:14 +00:00
Erik Magnusson
8fb1c1f344 console: added an error notification when successful gql response contains err…
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6204
GitOrigin-RevId: ab3135525a7cbb0d2efbd8a65b2b84942014b367
2022-10-06 10:31:43 +00:00
Daniel Harvey
87ca46f79b tests: add Postgres 14 and Postgres 15 pytests
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5968
GitOrigin-RevId: 6569e58b89f014268152cfe7bf1f6c11233fbe49
2022-10-06 09:46:38 +00:00
Brandon Simmons
823babe885 server: switch to ghc 9.2 (2nd try)
## Migrating, for server devs

You will need the fork of 9.2.4 that we're using (for now):

```
ghcup -c -n install ghc --force -u "https://storage.googleapis.com/graphql-engine-cdn.hasura.io/ghc-bindists/ghc-x86_64-deb10-linux-9.2.4-hasura-fix.tar.xz" 9.2.4
```

or for m1 mac:

```
ghcup -c -n install ghc --force -u  "https://storage.googleapis.com/graphql-engine-cdn.hasura.io/ghc-bindists/ghc-arm64-apple-darwin-9.2.4-hasura-fix.tar.xz"
```

Samir is working on a nix build for nix folx

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6154
GitOrigin-RevId: 6716e3f2ee19f0281c8ad25383a1241fc362d616
2022-10-06 09:09:01 +00:00
Luca Restagno
1fb32bc2d4 console: isolate redux logic for the insert row tab
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6195
GitOrigin-RevId: c65e08266fb0a4946bbe4c37e89070fb02eba9f8
2022-10-06 08:00:54 +00:00
Rishichandra Wawhal
8613af582e console: update onboarding messages for the new template schema
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6221
GitOrigin-RevId: 1276a6208e34f20e735daaf856a1e099e52d3338
2022-10-06 06:12:28 +00:00
Daniel Chambers
d713cad315 Add support for lowercase table and column names in the Data Connector agent tests [GDC-463]
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6179
GitOrigin-RevId: 6455e5809ea06b86dfbcddf781ee105088ca78f9
2022-10-05 23:25:00 +00:00
Jesse Hallett
77200563a4 rfc: separate metadata API types from business logic types
[Rendered](https://github.com/hasura/graphql-engine-mono/blob/jesse/rfc/metadata-dtos/rfcs/separate-metadata-api-types.md)

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4619
GitOrigin-RevId: a9e4c119ae53a37718fd7c7c1b658c6bfaa2616a
2022-10-05 18:39:45 +00:00
Samir Talwar
6a586cdaa0 api-tests: Sort and uniquify test module names in the Cabal file.
The duplicates make Cabal 3.8.x choke.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6206
GitOrigin-RevId: 7c6c69c721aed659a19db7b9124749dd6566d5dc
2022-10-05 12:38:48 +00:00
Philip Lykke Carlsen
3fea9ce4fc Refactor FromItem to use TableIdentifier
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6166
GitOrigin-RevId: 97d4fb0bec6d1c60e168f2503328ad5ef38915b2
2022-10-05 10:04:57 +00:00