Commit Graph

4281 Commits

Author SHA1 Message Date
Vijay Prasanna
db07dcf60d console: new "add remote schema" page (with GQL customization)
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4428
GitOrigin-RevId: d8f82ffe86fd59abb43afa195b40c2fdafabb847
2022-05-10 11:32:32 +00:00
Varun Choudhary
f7b4d32941 CON-162-Swap to react icons in the remote schemas + settings + feature flag
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4462
GitOrigin-RevId: 57c43f73603a63641363e578e3a8440eb1d3b586
2022-05-10 07:38:04 +00:00
Antoine Leblanc
697137dd77 Fix Postgres not padding timestamps correctly (fix hasura/graphql-engine#8096)
## Description

As identified in hasura/graphql-engine#8096, the format string we used for timestamps was incorrect; we were using `%F`, which expands to `%Y-%m-%d`; but that meant that the year was not padded to four digits: `0001` would be represented simply as `1`. However, Postgres inteprets that `1` as `2001`, probably due to interpretation rules about two-digit years (in `25/12/01`, `01` is indeed `2001`).

```
# create table timestamp_test ( test timestamptz );
CREATE TABLE
# insert into timestamp_test values ('1-01-01T00:00:57Z');
INSERT 0 1
# select * from timestamp_test;
          test
------------------------
 2001-01-01 00:00:57+00
(1 row)
```

To fix this, this PR changes the format string to use `%0Y`, which always pads the year number with zeroes.

## Remaining work

- [x] write Changelog entry
- [ ] copy timestamp tests from the python suite into the hspec tests

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3536
GitOrigin-RevId: fa144111358339fd4a35b32d888c1d2c5b418ea6
2022-05-09 12:18:18 +00:00
Evie Ciobanu
d1f8b9a87d server: further improve anybackend module docs
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4465
GitOrigin-RevId: fda2b45468a94d5b25f9d5aed8199502ee9370ad
2022-05-09 10:12:59 +00:00
hasura-bot
8bf2dd0c65 Improve COMPILING-ON-MACOS.md
GITHUB_PR_NUMBER: 8472
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/8472

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4466
Co-authored-by: Nico Burns <1007307+nicoburns@users.noreply.github.com>
Co-authored-by: Gil Mizrahi <8547573+soupi@users.noreply.github.com>
GitOrigin-RevId: dae49cafaba8492224d70df4624ad36888e0e3ab
2022-05-09 08:32:56 +00:00
Anon Ray
c33fb6c436 server: update pg-client-hs version
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4446
GitOrigin-RevId: adb823916f1f3c0451a1dbfaf7669f3a625eac81
2022-05-09 08:28:54 +00:00
Miguel Fernández
7ea4c79f02 docs: add another FAQ to project hibernation
>

## Description ✍️
->

Tracked in https://github.com/hasura/lux/pull/3904
Part of https://github.com/hasura/lux/issues/4136

## Changelog ✍️

- [x] `CHANGELOG.md` is updated with user-facing content relevant to this PR.
  If no changelog is required, then add the `no-changelog-required` label.

## Affected components ✍️

- [x]  Docs

### Metadata ✍

Does this PR add a new Metadata feature?
-  No

### GraphQL ✍
-  No new GraphQL schema is generated

### Breaking changes ✍

-  No Breaking changes

### Kodiak commit message

#### Commit title

[docs] Add another FAQ to the project hibernation page

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4447
GitOrigin-RevId: 9e2681c12bdac69f992419a181503ef44672d55b
2022-05-07 16:09:55 +00:00
hasura-bot
4c1280e3af docs: add SSL setup to cloud GCP Postgres guide
GITHUB_PR_NUMBER: 8458
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/8458

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4425
Co-authored-by: adas98012 <101733366+adas98012@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Marion Schleifer <5722022+marionschleifer@users.noreply.github.com>
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: c958ae880118e717f76f982c3c15ea7b90ff56e7
2022-05-07 16:07:30 +00:00
hasura-bot
b56b3f9581 docs: add Clerk auth integration guide
GITHUB_PR_NUMBER: 8456
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/8456

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4422
Co-authored-by: Ian McPhail <97047001+devchampian@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Marion Schleifer <5722022+marionschleifer@users.noreply.github.com>
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: 60436cb04abd92ea22816b3960c0f34675fabfa6
2022-05-07 15:42:29 +00:00
Brandon Simmons
f8fd61539e ci: finer-grained dependencies on build-servers artifacts
…p CI (#3975)

Trying out a new convention here for jobs that generate multiple
artifacts at different points in time, and where downstream jobs depend
on just a particular subset of artifacts and don't need to wait for the
entire job. We accomplish this with separate `Input` steps, which we
unblock manually via calls to the buildkite API once particular sets of
artifacts are complete.

We could accomplish the same thing by having multiple build server jobs
focused on particular targets ( this is in fact how it used to work)
but that is quite wasteful of CI resources;  in order to build any of
the binaries quickly, we need significant number of cores;  but if we
only build particular targets, we don't take advantage I've all those
cores relative to the parallelism a full cabal build gives us. That
would likely be more difficult to maintain as well.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4256
Co-authored-by: Vishnu Bharathi <4211715+scriptnull@users.noreply.github.com>
GitOrigin-RevId: 5f5603da8a85f9a491877d51a7c08764c7199602
2022-05-06 12:59:53 +00:00
Karthikeyan Chinnakonda
3d33017296 [RFC] disable query/subscription root fields
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4449
GitOrigin-RevId: f7f4e60250b4c7375a973d0e5770ac134217767a
2022-05-06 11:19:48 +00:00
Jeremy Jacobson
b369462913 docs: Added DataDog trace documentation for Cloud
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4421
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: 5791a4c952a96885ac3c3ec3373436f180778115
2022-05-06 10:52:08 +00:00
Varun Choudhary
dcb8f7a4c9 CON-158-Swap to react icons in the common folder of oss codebase
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4434
Co-authored-by: Nicolas Beaussart <7281023+beaussan@users.noreply.github.com>
GitOrigin-RevId: 1b7b7beb30b6ee7f6a4960801a011c5deea620cc
2022-05-06 10:38:32 +00:00
Sooraj
2e81212c12 console: remove remote schema relationships feature flag
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4412
GitOrigin-RevId: b15cb02f143e92b2b3dbd63ec57bc4036aa84b3b
2022-05-06 07:38:48 +00:00
Nicolas Beaussart
db1e6cc79f console: removing bootstrap webpack loader [CON-153]
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4328
GitOrigin-RevId: d8189f4bdc7fdeecf575a40843f48c7cc727ea4d
2022-05-05 17:47:36 +00:00
Antoine Leblanc
04d8f068b6 Remove explicit case on the backend tag in Cache
### Description

As part of the cache building process, we create / update / migrate the catalog that each DB uses as a place to store event trigger information. The function that decides how this should be done was doing an explicit `case ... of` on the backend tag, instead of delegating to one of the backend classes. The downsides of this is that:
- it adds a "friction point" where the backend matters in the core of the engine, which is otherwise written to be almost entirely backend-agnostic
- it creates imports from deep in the engine to the `Backends`, which we try to restrict to a very small set of clearly identified files (the `Instances` files)
- it is currently implemented using a "catch all" default case, which might not always be correct for new backends

This PR makes the catalog updating process a part of `BackendMetadata`, and cleans the corresponding schema cache code.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4457
GitOrigin-RevId: 592f0eaa97a7c38f4e6d4400e1d2353aab12c97e
2022-05-05 13:44:56 +00:00
Daniel Chambers
97ac9cbcdc Data Connector Agent Configuration Schema [GDW-103]
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4450
GitOrigin-RevId: 2dce6e901c9734407d084d57166039fd94394279
2022-05-05 05:19:46 +00:00
Sibi Prabakaran
a06abcea86 docs: Add Debugging section for hspec
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4448
GitOrigin-RevId: 57aff86ebd0ef0ec90fa4ba11f5a7a83cf4e9c27
2022-05-04 14:57:15 +00:00
Rakesh Emmadi
7474f50ef0 server/bigquery: enable metadata API to add/drop computed fields to BigQuery tables
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4414
GitOrigin-RevId: 7899824a49ba9fd479f4cf08789450153f454168
2022-05-04 14:53:31 +00:00
hasura-bot
4cd66bef09 docs: clarify computed fields execution docs
GITHUB_PR_NUMBER: 8461
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/8461

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4437
Co-authored-by: Michael Floering <2420688+hangtwenty@users.noreply.github.com>
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: fbeb56eba04415776cdba44089a4e0319587eb36
2022-05-04 11:02:31 +00:00
paritosh-08
fb4f745f74 server: refactor Hasura.GraphQL.Analyse
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4310
GitOrigin-RevId: 36bd42476724cc6b94987a4362c2a46616be4f0c
2022-05-04 10:57:55 +00:00
Sibi Prabakaran
49f2e0f4a3 Unify hspec test for SelectSpec and DirectiveSpec
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4387
GitOrigin-RevId: 890d07ebda838a4c6dc4221908bacba2ee75a0a2
2022-05-04 09:59:29 +00:00
Miguel Fernández
935a6fc975 [docs] Document the hibernation of free projects that are unused
>

## Description ✍️
->

Tracked in https://github.com/hasura/lux/pull/3904
Part of https://github.com/hasura/lux/issues/4136

## Changelog ✍️

- [x] `CHANGELOG.md` is updated with user-facing content relevant to this PR.
  If no changelog is required, then add the `no-changelog-required` label.

## Affected components ✍️

- [x]  Docs

### Metadata ✍

Does this PR add a new Metadata feature?
-  No

### GraphQL ✍
-  No new GraphQL schema is generated

### Breaking changes ✍

-  No Breaking changes

### Kodiak commit message

#### Commit title
[docs] Document the suspension of free projects that are unused

#### Commit body

Unused free projects are suspended given two previous notices to the owner. A project becomes inactive when it's unused for 3 months.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4389
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: e4daed2bba6fe5d965c64c00f2aa4104afe593e7
2022-05-04 09:01:54 +00:00
Abby Sassel
7eda345f3b server/tests: Troubleshooting docs
From discussion threads at https://hasurahq.slack.com/archives/CV3UR1MT2/p1651627110710999 and https://hasurahq.slack.com/archives/CV3UR1MT2/p1651590300512049

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4445
GitOrigin-RevId: c5c674f91d065e6864ec781b17db151bc649e75c
2022-05-04 08:23:53 +00:00
Abby Sassel
738693f61f server/docs: Add/update BigQuery test setup info
This PR adds BigQuery setup notes for the hspec test suite.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4444
GitOrigin-RevId: 4d3ea3315e60dedf47f6236ea79e6fa4945fa8f0
2022-05-04 07:37:22 +00:00
Gil Mizrahi
4411bc9b17 add some haddock annotations to AnyBackend.hs
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4415
GitOrigin-RevId: 8e3feca04ef92bed8870da128959b9d48fb92727
2022-05-03 13:15:41 +00:00
Vishnu Bharathi
9c90bb0b2c ci: tag release v2.5.2 and v2.6.1
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4430
GitOrigin-RevId: 9080dac0ffa75558401716ed8b437d63ff1d82c1
2022-05-03 09:36:04 +00:00
Vamshi Surabhi
d5cb312f8b replace SQLOperator with ScalarSelectionArguments
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4426
GitOrigin-RevId: 69beda27ccf4cb47dab80d59ec383704be805bf6
2022-05-03 09:00:01 +00:00
Sibi Prabakaran
c199215947 Unified setup for NestedRelationshipsSpec
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4378
GitOrigin-RevId: 3881591ad0ec109352e09a989377121550632fdd
2022-05-03 07:38:47 +00:00
Brandon Martin
5008b54813 Update CHANGELOG for known issue v2.6.0/v2.5.1
## Description ✍️
Update CHANGELOG for known issue v2.6.0/v2.5.1

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4409
GitOrigin-RevId: ae22b1b9e1845de48859be56af83426ee8556c9f
2022-05-02 13:31:01 +00:00
Naveen Naidu
955db8ab11 server: Use quote_ident for quoting table name when using regclass
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4413
Co-authored-by: Karthikeyan Chinnakonda <15602904+codingkarthik@users.noreply.github.com>
GitOrigin-RevId: 721fae15587bdab6f27b8d1189fe6e41c42097e7
2022-05-02 13:16:55 +00:00
Varun Choudhary
0580d6f727 CON-128-filter out scalar type from source type for RS-to-RS relationships
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4406
GitOrigin-RevId: 6421e1b2695870ba48ab0f095c3c82568e6ffd55
2022-05-02 12:20:55 +00:00
Varun Choudhary
bdaa6c38b9 console: allow users to remove prefix / suffix / root field namespace from a remote schema
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4379
GitOrigin-RevId: afdf4246c711c6972d7f33365cf98b75c1e6f78e
2022-05-02 06:24:22 +00:00
Daniel Chambers
4f835623b1 Rename Data Wrapper to Data Connector [GDW-89]
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4400
GitOrigin-RevId: 2d90542f95ef4dad70c8dfe1ca3b4c1f3bdaa527
2022-05-02 05:04:07 +00:00
Lyndon Maydwell
53ca4da79d Fixing URL parameter for variable <name> not supported bug in REST endpoints for Dates
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4345
GitOrigin-RevId: 0b739530757ee1081d764d9582e3c0e648861d4e
2022-05-02 03:34:34 +00:00
Daniel Chambers
9453932112 Data Connector Agent Configuration via HGE Metadata [GDW-103]
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4358
GitOrigin-RevId: 36e18edf00ba0665b40a80c0b07c374ffcfe56e4
2022-05-01 23:02:08 +00:00
Matt Hardman
05bc304d7e CON-124-create-a-metadata-selector-that-gets-db-to-rs-relationships
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4277
GitOrigin-RevId: 6c2c3128e1480e182f27290e9d6239c1ff95f5fc
2022-04-29 16:52:33 +00:00
hasura-bot
7312a92e5f docs: add chinese translation for live-queries.md
GITHUB_PR_NUMBER: 6646
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/6646

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/832
Co-authored-by: Berlin Chan <14348629+BerlinChan@users.noreply.github.com>
GitOrigin-RevId: 9c731b835d44398e05ad0f0c37ea9e8f82004e44
2022-04-29 08:21:38 +00:00
Abhijeet Khangarot
38db669e6b console: add remote db relationship widget
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4365
GitOrigin-RevId: 7143110491d112879847e6cbfa141c8d62a311f7
2022-04-29 08:07:17 +00:00
Daniel Chambers
970d69edd4 Added BackendConfig to allow sources to share configuration of Data Connectors [GDW-78]
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4271
GitOrigin-RevId: 6990010bff622a424ca0bb9d24579bf121819fb0
2022-04-29 02:14:10 +00:00
Naveen Naidu
222419527f server: refactor MaintenanceMode datatype
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4298
GitOrigin-RevId: 0b88d040bd4b24c61c4ae91e18dc6edf67b3672e
2022-04-28 20:56:11 +00:00
Naveen Naidu
1d641aa2ff server: support query tags for MSSQL data sources
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4373
GitOrigin-RevId: 45717defdc973f3b7f1c9b972e2d3c836eec4476
2022-04-28 19:34:45 +00:00
hasura-bot
1123dd87b4 update README.md with pgAdmin password for connection settings
GITHUB_PR_NUMBER: 6473
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/6473

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/391
Co-authored-by: estalldecker <6700086+estalldecker@users.noreply.github.com>
GitOrigin-RevId: 9f52efe0225e8d32bb4753c1993bee8cbbedd538
2022-04-28 14:45:30 +00:00
Rakesh Emmadi
030de648e3 server/bigquery: internal types and function to fetch routine information from BigQuery
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4376
GitOrigin-RevId: 30f2d0373dba262cc868ea48a613272ca19865f6
2022-04-28 12:38:27 +00:00
Marion Schleifer
0d66c316ce docs: add feature docs for federation
This PR adds the following docs:
- Remote relationships for Postgres
  - Remote schema -> Database
  - Remote schema -> Remote schema
- Remote relationships for MS SQL Server
  - Database -> Database
  - Database -> Remote schema
  - Remote schema -> Database
  - Remote schema -> Remote schema

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4281
Co-authored-by: Vamshi Surabhi <6562944+0x777@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: dc6aa4d4cbcfd9c9ddc1df65c7b0f402cc2eafee
2022-04-28 09:14:27 +00:00
Sibi Prabakaran
88f8c676d4 Update hspec documentation for TestEnvironment
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4386
GitOrigin-RevId: 471b538316f2766ccd7d8919299d947f9b2ac4a4
2022-04-28 08:59:09 +00:00
Alberto Francesco Motta
b21d1c0495 changelog: update for v2.6.0 release
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4385
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
Co-authored-by: Vishnu Bharathi <4211715+scriptnull@users.noreply.github.com>
GitOrigin-RevId: b61cbd40163568cbc5f550ff9ed3157f5c0b474b
2022-04-28 08:46:55 +00:00
Solomon
db1c50affa Feature/gdw execute array literals GDW-82
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4319
GitOrigin-RevId: 20db2a1eb6e8521c4e572aa642c802129792468f
2022-04-28 01:53:06 +00:00
Abby Sassel
25d77afaff server/tests: Fix BigQuery test failure Job exceeded rate limits error in CI
Fixes https://github.com/hasura/graphql-engine-mono/issues/3695.

Error: [BigQuery test failure Job exceeded rate limits](https://github.com/hasura/graphql-engine-mono/issues/3695)

Cause:
1. [this command](2325755954/.circleci/test-server.sh (L1263)) runs tests matching the `Bigquery or Common` string, for the `test-oss-server-bigquery` CI job.
2. in this case, the pytest filter matched on `TestGraphQLQueryBoolExpSearchCommon`. Although unrelated pytests are skipped, BQ setup and teardown runs uneccesarily for the [MSSQL and Postgres backends](e444cf1f5d/server/tests-py/test_graphql_queries.py (L868)).
4. the setup and teardown runs three times in quick succession, _for each of_ SQL Server, Postgres and BigQuery. Occasionally, this surpassed [BigQuery's maximum rate of 5 table update operations in 10 seconds](https://cloud.google.com/bigquery/quotas#load_job_per_table.long).

Fix: restrict setup/teardown to only the relevant backends...
- Hotfix (this PR): ...by renaming pytest classes and changing the pytest filters in `test-server`
	- ok, this is faintly horrifying and an inelegant convention change. On the bright side, it shaves a minute or so off our integration test suite run by skipping fewer tests. Anecdata for `test-oss-server-bigquery`
		- before: 87 passed, 299 skipped, 1 warning, 1 error in 192.99s
		- after: 87 passed, 20 skipped, 1 warning in 170.82s
	- [`Common` was a terrible name, anyway](https://github.com/hasura/graphql-engine-mono/issues/2079), for `AnyCombinationOfBackends`.
- Better fix: ...by refactoring the `conftest.py` helpers. I ran out of a timebox so will write up a separate issue. Given we're actively [porting pytests over to hspec](https://github.com/hasura/graphql-engine/issues/8432), I don't know how much it's worth investing time in a refactor.

To verify the fix: I ran a full CI build a few times [[1]](https://buildkite.com/hasura/graphql-engine-mono/builds/8069#078c781a-c8ef-44f2-a400-15f91fb88e42)[[2]](https://buildkite.com/hasura/graphql-engine-mono/builds/8072#f9e7f59d-264f-46a4-973d-21aa762cca35)[[3]](https://buildkite.com/hasura/graphql-engine-mono/builds/8075#bb104e80-ff76-408c-a46b-6f40e92e6317) whilst troubleshooting to convince myself this fixed the problem.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4362
GitOrigin-RevId: 4c3283f0654b70e9dcda642d9012f6376aa95290
2022-04-27 18:40:41 +00:00
Antoine Leblanc
f684fecc6c Cut ties with RQL.DML.Internal
## Description

As the name suggests, `DML.Internal` contains internal implementation details of RQL's DML. However, a lot of unrelated parts of the codebase still use some of the code it contains. This PR fixes this, and removes all imports of `RQL.DML.Internal` from outside of `RQL.DML`. Most of the time, this involves moving a function out of `DML.Internal` to an underlying module (see `getRolePermInfo`) or moving a function _back_ into it (see `checkRetCols`).

This PR also clarifies a bit the situation with `withTyAnn` and `withTypeAnn` by renaming the former into `withScalarTypeAnn` and moving them together. Worth noting: there might be a bug lurking in that function, as it doesn't seem to use the proper type annotations for some extension types!

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4380
GitOrigin-RevId: c8ae5b4e8378fefc0bcccf778d97813df727d3cb
2022-04-27 15:37:23 +00:00