hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-12-15 01:12:56 +03:00
Code Issues Projects Releases Wiki Activity
42a2787290
graphql-engine/server
History
Rakesh Emmadi 42a2787290 server/mssql: update odbc git reference to the commit which has error message fix 
## Description

I come across a flaky test due to inconsistent error messages from the odbc lib we use for MSSQL database interactions.
```
cabal new-run -- test:graphql-engine-tests mssql
Up to date

Database.MSSQL.TransactionSpec
  runTx
    runs command in a transaction
    commits a successful transaction, returning a single field
    commits a successful transaction, returning multiple fields
    an unsuccesful transaction, expecting Int
    a successfull query expecting multiple rows
    an unsuccesful transaction; expecting single row
    displays the SQL Server error on an unsuccessful transaction FAILED [1]
    rolls back an unsuccessful transaction

Failures:

  src-test/Database/MSSQL/TransactionSpec.hs:60:15:
  1) Database.MSSQL.TransactionSpec.runTx displays the SQL Server error on an unsuccessful transaction
       expected: UnsuccessfulReturnCode "odbc_SQLExecDirectW" (-1) "[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The definition for column 'INVALID_SYNTAX' must include a data type.[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The definition for column 'INVALID_SYNTAX' must include a data type."
        but got: UnsuccessfulReturnCode "odbc_SQLExecDirectW" (-1) "[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The definition for column 'INVALID_SYNTAX' must include a data type.[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The definition for column 'INVALID_SYNTAX' must include a data type.\DEL"

  To rerun use: --match "/Database.MSSQL.TransactionSpec/runTx/displays the SQL Server error on an unsuccessful transaction/"

Randomized with seed 1101559172

Finished in 0.2140 seconds
8 examples, 1 failure
```
From above, we got a error message with `\DEL` appended. It is also driving the tests to fail in the CI on random PRs.

We brought this into notice of "fpco", the authors of the library and they got us a [quick fix](https://github.com/fpco/odbc/pull/43), which also improves the errors by removing the redundancy of the error message.

In this PR
- We update the `odbc` library git reference to fc5b592a60
- Update the error messages in tests to conform with improved error messages from `odbc`

## Related issues
Closes https://github.com/hasura/graphql-engine-mono/issues/3340

## Changelog

- ✅ `CHANGELOG.md` is updated with user-facing content relevant to this PR.

## Affected components
- ✅ server
- ✅ tests

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3345
GitOrigin-RevId: a5694e8afb58b5ad71b9c9635a80dea1ec449f51
2022-01-13 11:15:01 +00:00
..
bench-wrk server, pro: actually reformat the code-base using ormolu 2021-09-23 22:57:37 +00:00
benchmarks server benchmarks: add introspection queries 2021-12-09 15:10:42 +00:00
documentation Add tip for writing unit tests for SQL generation 2021-12-06 07:59:44 +00:00
packaging ci: add support for linux/arm64 docker image 2021-12-09 09:34:22 +00:00
src-exec server/tests: initial work on a test suite for DB-to-DB joins 2021-10-20 20:02:34 +00:00
src-lib mssql: Test upserts with permissions 2022-01-11 13:36:56 +00:00
src-rsr tag release v2.1.1 2021-12-17 12:38:06 +00:00
src-test server/mssql: update odbc git reference to the commit which has error message fix 2022-01-13 11:15:01 +00:00
tests/integration server/mssql: support read replicas 2022-01-04 11:54:56 +00:00
tests-hspec hspec: Tests for MySQL equivalent to the ones from the Python suite. close hasura/graphql-engine#7757 2022-01-07 17:52:53 +00:00
tests-py server/mssql: update odbc git reference to the commit which has error message fix 2022-01-13 11:15:01 +00:00
.dockerignore update packages (#251) 2018-08-08 13:10:13 +05:30
.gitignore server/citus: feature branch 2021-05-21 02:47:51 +00:00
.hlint.yaml ci: improve hlint messages 2021-05-04 21:52:55 +00:00
commit_diff.txt Rewrite GraphQL schema generation and query parsing (close #2801) (#4111) 2020-08-21 12:27:01 -05:00
COMPILING-ON-M1.md Add instructions for compiling graphql-engine natively on M1 2021-11-24 09:59:10 +00:00
CONTRIBUTING.md server/mssql: fix pytest class names for update mutations 2021-12-29 18:03:46 +00:00
graphql-engine.cabal hspec: Tests for MySQL equivalent to the ones from the Python suite. close hasura/graphql-engine#7757 2022-01-07 17:52:53 +00:00
Makefile ci: misc. cleanup, naming 2022-01-03 06:26:39 +00:00
Setup.hs server, pro: actually reformat the code-base using ormolu 2021-09-23 22:57:37 +00:00
STYLE.md server, CI: use ormolu as a formatter for Haskell sources 2021-09-23 21:23:21 +00:00