hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-12-18 21:12:09 +03:00
Code Issues Projects Releases Wiki Activity
42a2787290
graphql-engine/server/tests-py/queries/v2/mssql/run_sql
History
Rakesh Emmadi 42a2787290 server/mssql: update odbc git reference to the commit which has error message fix 
## Description

I come across a flaky test due to inconsistent error messages from the odbc lib we use for MSSQL database interactions.
```
cabal new-run -- test:graphql-engine-tests mssql
Up to date

Database.MSSQL.TransactionSpec
  runTx
    runs command in a transaction
    commits a successful transaction, returning a single field
    commits a successful transaction, returning multiple fields
    an unsuccesful transaction, expecting Int
    a successfull query expecting multiple rows
    an unsuccesful transaction; expecting single row
    displays the SQL Server error on an unsuccessful transaction FAILED [1]
    rolls back an unsuccessful transaction

Failures:

  src-test/Database/MSSQL/TransactionSpec.hs:60:15:
  1) Database.MSSQL.TransactionSpec.runTx displays the SQL Server error on an unsuccessful transaction
       expected: UnsuccessfulReturnCode "odbc_SQLExecDirectW" (-1) "[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The definition for column 'INVALID_SYNTAX' must include a data type.[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The definition for column 'INVALID_SYNTAX' must include a data type."
        but got: UnsuccessfulReturnCode "odbc_SQLExecDirectW" (-1) "[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The definition for column 'INVALID_SYNTAX' must include a data type.[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The definition for column 'INVALID_SYNTAX' must include a data type.\DEL"

  To rerun use: --match "/Database.MSSQL.TransactionSpec/runTx/displays the SQL Server error on an unsuccessful transaction/"

Randomized with seed 1101559172

Finished in 0.2140 seconds
8 examples, 1 failure
```
From above, we got a error message with `\DEL` appended. It is also driving the tests to fail in the CI on random PRs.

We brought this into notice of "fpco", the authors of the library and they got us a [quick fix](https://github.com/fpco/odbc/pull/43), which also improves the errors by removing the redundancy of the error message.

In this PR
- We update the `odbc` library git reference to fc5b592a60
- Update the error messages in tests to conform with improved error messages from `odbc`

## Related issues
Closes https://github.com/hasura/graphql-engine-mono/issues/3340

## Changelog

- ✅ `CHANGELOG.md` is updated with user-facing content relevant to this PR.

## Affected components
- ✅ server
- ✅ tests

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3345
GitOrigin-RevId: a5694e8afb58b5ad71b9c9635a80dea1ec449f51
2022-01-13 11:15:01 +00:00
..
create_author_table_fail.yaml server/mssql: update odbc git reference to the commit which has error message fix 2022-01-13 11:15:01 +00:00
drop_article_table_with_cascade.yaml server/mssql: add cascade to mssql_run_sql 2021-10-22 14:50:13 +00:00
drop_article_table_without_cascade.yaml server/mssql: add cascade to mssql_run_sql 2021-10-22 14:50:13 +00:00
schema_setup_mssql.yaml server/mssql: add cascade to mssql_run_sql 2021-10-22 14:50:13 +00:00
schema_teardown_mssql.yaml server/mssql: add cascade to mssql_run_sql 2021-10-22 14:50:13 +00:00
setup_mssql.yaml server/mssql: add cascade to mssql_run_sql 2021-10-22 14:50:13 +00:00