hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-12-15 01:12:56 +03:00
Code Issues Projects Releases Wiki Activity
ac004fec38
graphql-engine/CONTRIBUTING.md
Karthik Venkateswaran a9dc756a40 update console variables and contributing guide (close #517) (#538) 
Changes `consoleMode` variable templated by HGE to `server` and modified console to respect in the same way and adds a patch to continue working with the older HGEs

- [x] Server
- [x] Console
2018-09-27 17:10:32 +05:30

3.1 KiB
Raw Blame History

Contributing to Hasura graphql-engine

First: if you're unsure or afraid of anything, just ask or submit the issue or pull request anyway. You won't be yelled at for giving your best effort. The worst that can happen is that you'll be politely asked to change something. We appreciate any sort of contributions, and don't want a wall of rules to get in the way of that.

However, for those individuals who want a bit more guidance on the best way to contribute to the project, read on. This document will cover what we're looking for. By addressing all the points we're looking for, it raises the chances we can quickly merge or address your contributions.

Overview

hasura/graphql-engine is a mono-repo consisting of 3 components. Each have their own contributing guides:

  1. Server (Haskell)
  2. CLI (Go)
  3. Console (JavaScript)

All of the three components have a single version, denoted by either the git tag, or a combination of branch name and git commit SHA.

Docs

Contributing guide for docs can be found at docs/CONTRIBUTING.md.

Community content

There is no specific contributing guide for community content. Anything that can help GraphQL Engine community/users can go into the section. We have identified boilerplates, examples and tools as primary candidates. Feel free to submit a pull request if you have something to add (not necessarily belonging to the before-mentioned sections).

Issues

Reporting an Issue

  • Make sure you test against the latest released version. It is possible we already fixed the bug you're experiencing.

  • Provide steps to reproduce the issue, including Postgres version, graphql-engine version and the provider you are running on (Heroku, Docker etc.).

  • Please include logs of the server, if relevant.

Common guidelines

  • Please make sure there is an issue associated with the work that you're doing.

  • If you're working on an issue, please comment that you are doing so to prevent duplicate work by others also.

  • Squash your commits and refer to the issue using fix #<issue-no> or close #<issue-no> in the commit message, at the end. For example: resolve answers to everything (fix #42) or resolve answers to everything, fix #42

  • Rebase master with your branch before submitting pull request.

Commit messages

  • The first line should be a summary of the changes - not execeeding 50 characters. Followed by an optional body which has more details about the changes. (https://github.com/erlang/otp/wiki/writing-good-commit-messages)

  • Use the imperative present tense: "add/fix/change", not "added/fixed/changed" nor "adds/fixes/changes".

  • Don't capitalize the first letter of the summary line.

  • Do not add a period/dot (.) at the end in the summary line.

(Credits: Some sections are adapted from https://github.com/PostgREST/postgrest/blob/master/.github/CONTRIBUTING.md)