mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-26 00:43:09 +03:00
b75ab7233e
#### Issue: https://github.com/hasura/graphql-engine-mono/issues/2179 ### Problem: 1. There are few warnings when tests are executed with cli if it is built with `race` flag It is because of a race condition between stdin in migrate_delete for the prompt and stdout for other commands. 2. The integration test of the console used to behave as follows: ``` - Initially there won't be any wg.adds in wait-group so the second go-routine created in console-test (integration-test) - It will send the interrupt signal to the channel before the server has been started - So practically the server won't start ``` 3. The read and write for consoleopts.WG has been happening in different go-routines without control or lock system(reading and writing into same memory location without lock system). So there is a chance of data-race(warning for data-race while integration tests are executed) 4. Data-race errors from `promptui` package ### Solution: 1. Use `--force` flag to avoid getting the input from the prompt in `migrate_delete_test.go` 2. Introduced two fields in server and console opts to let know other go-routines whether the server has been started or not 3. To avoid data-race above which are shared b/w go-routines to know the status of servers has been operated atomically. 4. using new package https://github.com/AlecAivazis/survey https://github.com/hasura/graphql-engine-mono/pull/2231 GitOrigin-RevId: 387eb1be74f24dda34bb3588314b5a909adac227 |
||
|---|---|---|
| .. | ||
| templates/gohtml | ||
| apiserver.go | ||
| consoleserver.go | ||
| serve.go | ||
| template_test.go | ||
| template.go | ||