git.iko.soy/helix
on master help sign in
Document MSRV policy (#3913)
commit4133f1f424c6a9da71cab65dc9541e6d941ec603 authorPascal Kuthe <dspom@protonmail.com> dateFri 23 Sep 2022, 08:58 (4 years ago) parenteb6fd28
5 files changed+7−15
compare with master
unifiedsplit
.github/workflows/msrv-rust-toolchain.toml+1−1 Cargo.lock−7 docs/CONTRIBUTING.md+6 helix-term/Cargo.toml−3 helix-term/src/ui/picker.rs−4
.github/workflows/msrv-rust-toolchain.toml+1−1
@@ -1,3 +1,3 @@
11[toolchain]
2−channel = "1.59.0"
2+channel = "1.61.0"
33components = ["rustfmt", "rust-src"]
Cargo.lock−7
@@ -485,7 +485,6 @@ dependencies = [
485485 "log",
486486 "once_cell",
487487 "pulldown-cmark",
488− "retain_mut",
489488 "serde",
490489 "serde_json",
491490 "signal-hook",
@@ -884,12 +883,6 @@ dependencies = [
884883 "winapi",
885884]
886885
887−[[package]]
888−name = "retain_mut"
889−version = "0.1.9"
890−source = "registry+https://github.com/rust-lang/crates.io-index"
891−checksum = "4389f1d5789befaf6029ebd9f7dac4af7f7e3d61b69d4f30e2ac02b57e7712b0"
892−
893886[[package]]
894887name = "ropey"
895888version = "1.5.0"
docs/CONTRIBUTING.md+6
@@ -37,6 +37,12 @@ contributors are strongly encouraged to write integration tests for their code.
3737Existing tests can be used as examples. Helpers can be found in
3838[helpers.rs][helpers.rs]
3939
40+## Minimum Stable Rust Version (MSRV) Policy
41+
42+Helix follows the MSRV of Firefox.
43+The current MSRV and future changes to the MSRV are listed in the [Firefox documentation].
44+
45+[Firefox documentation]: https://firefox-source-docs.mozilla.org/writing-rust-code/update-policy.html
4046[good-first-issue]: https://github.com/helix-editor/helix/labels/E-easy
4147[log-file]: https://github.com/helix-editor/helix/wiki/FAQ#access-the-log-file
4248[architecture.md]: ./architecture.md
helix-term/Cargo.toml−3
@@ -67,9 +67,6 @@ serde = { version = "1.0", features = ["derive"] }
6767grep-regex = "0.1.10"
6868grep-searcher = "0.1.10"
6969
70−# Remove once retain_mut lands in stable rust
71−retain_mut = "0.1.7"
72−
7370[target.'cfg(not(windows))'.dependencies] # https://github.com/vorner/signal-hook/issues/100
7471signal-hook-tokio = { version = "0.3", features = ["futures-v0_3"] }
7572
helix-term/src/ui/picker.rs−4
@@ -365,10 +365,6 @@ impl<T: Item> Picker<T> {
365365 .map(|(index, _option)| (index, 0)),
366366 );
367367 } else if pattern.starts_with(&self.previous_pattern) {
368− // TODO: remove when retain_mut is in stable rust
369− #[allow(unused_imports, deprecated)]
370− use retain_mut::RetainMut;
371−
372368 // optimization: if the pattern is a more specific version of the previous one
373369 // then we can score the filtered set.
374370 #[allow(unstable_name_collisions)]