git.iko.soy/helix
on master help sign in
Document MSRV policy (#3913)
4133f1fPascal Kuthe
.github/workflows/msrv-rust-toolchain.toml+1−1
compare with master
unifiedsplit
@@ -1,3 +1,3 @@
1[toolchain]
1[toolchain]
2−channel = "1.59.0"
2+channel = "1.61.0"
3components = ["rustfmt", "rust-src"]
3components = ["rustfmt", "rust-src"]
Cargo.lock−7
@@ -485,7 +485,6 @@ dependencies = [
485 "log",
485 "log",
486 "once_cell",
486 "once_cell",
487 "pulldown-cmark",
487 "pulldown-cmark",
488− "retain_mut",
489 "serde",
488 "serde",
490 "serde_json",
489 "serde_json",
491 "signal-hook",
490 "signal-hook",
@@ -884,12 +883,6 @@ dependencies = [
884 "winapi",
883 "winapi",
885]
884]
886
885
887−[[package]]
888−name = "retain_mut"
889−version = "0.1.9"
890−source = "registry+https://github.com/rust-lang/crates.io-index"
891−checksum = "4389f1d5789befaf6029ebd9f7dac4af7f7e3d61b69d4f30e2ac02b57e7712b0"
892−
893[[package]]
886[[package]]
894name = "ropey"
887name = "ropey"
895version = "1.5.0"
888version = "1.5.0"
docs/CONTRIBUTING.md+6
@@ -37,6 +37,12 @@ contributors are strongly encouraged to write integration tests for their code.
37Existing tests can be used as examples. Helpers can be found in
37Existing tests can be used as examples. Helpers can be found in
38[helpers.rs][helpers.rs]
38[helpers.rs][helpers.rs]
39
39
40+## Minimum Stable Rust Version (MSRV) Policy
41+
42+Helix follows the MSRV of Firefox.
43+The current MSRV and future changes to the MSRV are listed in the [Firefox documentation].
44+
45+[Firefox documentation]: https://firefox-source-docs.mozilla.org/writing-rust-code/update-policy.html
40[good-first-issue]: https://github.com/helix-editor/helix/labels/E-easy
46[good-first-issue]: https://github.com/helix-editor/helix/labels/E-easy
41[log-file]: https://github.com/helix-editor/helix/wiki/FAQ#access-the-log-file
47[log-file]: https://github.com/helix-editor/helix/wiki/FAQ#access-the-log-file
42[architecture.md]: ./architecture.md
48[architecture.md]: ./architecture.md
helix-term/Cargo.toml−3
@@ -67,9 +67,6 @@ serde = { version = "1.0", features = ["derive"] }
67grep-regex = "0.1.10"
67grep-regex = "0.1.10"
68grep-searcher = "0.1.10"
68grep-searcher = "0.1.10"
69
69
70−# Remove once retain_mut lands in stable rust
71−retain_mut = "0.1.7"
72−
73[target.'cfg(not(windows))'.dependencies] # https://github.com/vorner/signal-hook/issues/100
70[target.'cfg(not(windows))'.dependencies] # https://github.com/vorner/signal-hook/issues/100
74signal-hook-tokio = { version = "0.3", features = ["futures-v0_3"] }
71signal-hook-tokio = { version = "0.3", features = ["futures-v0_3"] }
75
72
helix-term/src/ui/picker.rs−4
@@ -365,10 +365,6 @@ impl<T: Item> Picker<T> {
365 .map(|(index, _option)| (index, 0)),
365 .map(|(index, _option)| (index, 0)),
366 );
366 );
367 } else if pattern.starts_with(&self.previous_pattern) {
367 } else if pattern.starts_with(&self.previous_pattern) {
368− // TODO: remove when retain_mut is in stable rust
369− #[allow(unused_imports, deprecated)]
370− use retain_mut::RetainMut;
371−
372 // optimization: if the pattern is a more specific version of the previous one
368 // optimization: if the pattern is a more specific version of the previous one
373 // then we can score the filtered set.
369 // then we can score the filtered set.
374 #[allow(unstable_name_collisions)]
370 #[allow(unstable_name_collisions)]