on master help sign in
Remove some TODOs
commit7c9ebd05b83e90e55d032f65d9405ad265b82258 authorBlaž Hrastnik <blaz@mxxn.io> dateSun 23 Jan 2022, 16:08 (5 years ago) parent80e920b
2 files changed+1−20
TODO.md−13 helix-core/src/syntax.rs+1−7
TODO.md−13
@@ -1,25 +1,12 @@
11
2−- tree sitter:
3− - markdown
4− - regex
5− - kotlin
6− - clojure
7− - erlang
8−
92- [ ] completion isIncomplete support
10−
11−1
123- [ ] respect view fullscreen flag
134- [ ] Implement marks (superset of Selection/Range)
145
156- [ ] = for auto indent line/selection
16−- [ ] :x for closing buffers
177- [ ] lsp: signature help
188
1992
20−- [ ] macro recording
21−- [ ] extend selection (treesitter select parent node) (replaces viw, vi(, va( etc )
22−- [ ] selection align
2310- [ ] store some state between restarts: file positions, prompt history
2411- [ ] highlight matched characters in picker
2512
helix-core/src/syntax.rs+1−7
@@ -665,14 +665,10 @@ impl Syntax {
665665 layer.depth == depth && // TODO: track parent id instead
666666 layer.config.language == config.language && layer.ranges == ranges
667667 })
668− .map(|(id, _layer)| {
669− log::info!("match! {:?}", id);
670− id
671− });
668+ .map(|(id, _layer)| id);
672669
673670 // ...or insert a new one.
674671 let layer_id = layer.unwrap_or_else(|| {
675− log::info!("miss! {:?}", ranges);
676672 self.layers.insert(LanguageLayer {
677673 tree: None,
678674 config,
@@ -714,7 +710,6 @@ impl Syntax {
714710 .iter()
715711 .filter_map(|(_, layer)| {
716712 // TODO: if range doesn't overlap layer range, skip it
717− // we can calculate intersection and use it later for set_byte_range
718713
719714 // Reuse a cursor from the pool if available.
720715 let mut cursor = PARSER.with(|ts_parser| {
@@ -729,7 +724,6 @@ impl Syntax {
729724 unsafe { mem::transmute::<_, &'static mut QueryCursor>(&mut cursor) };
730725
731726 // if reusing cursors & no range this resets to whole range
732− // TODO: handle intersect (range & layer.range)
733727 cursor_ref.set_byte_range(range.clone().unwrap_or(0..usize::MAX));
734728
735729 let mut captures = cursor_ref