git.iko.soy/helix
on master help sign in
Remove some TODOs
7c9ebd0Blaž Hrastnik
TODO.md−13
compare with master
unifiedsplit
@@ -1,25 +1,12 @@
1
1
2−- tree sitter:
3− - markdown
4− - regex
5− - kotlin
6− - clojure
7− - erlang
8−
9- [ ] completion isIncomplete support
2- [ ] completion isIncomplete support
10−
11−1
12- [ ] respect view fullscreen flag
3- [ ] respect view fullscreen flag
13- [ ] Implement marks (superset of Selection/Range)
4- [ ] Implement marks (superset of Selection/Range)
14
5
15- [ ] = for auto indent line/selection
6- [ ] = for auto indent line/selection
16−- [ ] :x for closing buffers
17- [ ] lsp: signature help
7- [ ] lsp: signature help
18
8
192
92
20−- [ ] macro recording
21−- [ ] extend selection (treesitter select parent node) (replaces viw, vi(, va( etc )
22−- [ ] selection align
23- [ ] store some state between restarts: file positions, prompt history
10- [ ] store some state between restarts: file positions, prompt history
24- [ ] highlight matched characters in picker
11- [ ] highlight matched characters in picker
25
12
helix-core/src/syntax.rs+1−7
@@ -665,14 +665,10 @@ impl Syntax {
665 layer.depth == depth && // TODO: track parent id instead
665 layer.depth == depth && // TODO: track parent id instead
666 layer.config.language == config.language && layer.ranges == ranges
666 layer.config.language == config.language && layer.ranges == ranges
667 })
667 })
668− .map(|(id, _layer)| {
668+ .map(|(id, _layer)| id);
669− log::info!("match! {:?}", id);
670− id
671− });
672
669
673 // ...or insert a new one.
670 // ...or insert a new one.
674 let layer_id = layer.unwrap_or_else(|| {
671 let layer_id = layer.unwrap_or_else(|| {
675− log::info!("miss! {:?}", ranges);
676 self.layers.insert(LanguageLayer {
672 self.layers.insert(LanguageLayer {
677 tree: None,
673 tree: None,
678 config,
674 config,
@@ -714,7 +710,6 @@ impl Syntax {
714 .iter()
710 .iter()
715 .filter_map(|(_, layer)| {
711 .filter_map(|(_, layer)| {
716 // TODO: if range doesn't overlap layer range, skip it
712 // TODO: if range doesn't overlap layer range, skip it
717− // we can calculate intersection and use it later for set_byte_range
718
713
719 // Reuse a cursor from the pool if available.
714 // Reuse a cursor from the pool if available.
720 let mut cursor = PARSER.with(|ts_parser| {
715 let mut cursor = PARSER.with(|ts_parser| {
@@ -729,7 +724,6 @@ impl Syntax {
729 unsafe { mem::transmute::<_, &'static mut QueryCursor>(&mut cursor) };
724 unsafe { mem::transmute::<_, &'static mut QueryCursor>(&mut cursor) };
730
725
731 // if reusing cursors & no range this resets to whole range
726 // if reusing cursors & no range this resets to whole range
732− // TODO: handle intersect (range & layer.range)
733 cursor_ref.set_byte_range(range.clone().unwrap_or(0..usize::MAX));
727 cursor_ref.set_byte_range(range.clone().unwrap_or(0..usize::MAX));
734
728
735 let mut captures = cursor_ref
729 let mut captures = cursor_ref