ilyakooo0/nixpkgs
1
0
Fork 0
mirror of https://github.com/ilyakooo0/nixpkgs.git synced 2024-11-19 02:44:17 +03:00
Code Issues Projects Releases Wiki Activity

Merge pull request #195235 from thiagokokada/retroarch-mark-as-broken-macos

Browse Source 
retroarch: mark as broken in macOS
This commit is contained in:
Thiago Kenji Okada 2022-10-09 17:28:33 +01:00 committed by GitHub
commit 6b0b91fee3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pkgs/applications/emulators/retroarch/default.nix
View File

@ -129,12 +129,7 @@ stdenv.mkDerivation rec {
# Workaround for the following error affecting newer versions of Clang:
# ./config.def.h:xxx:x: error: 'TARGET_OS_TV' is not defined, evaluates to 0 [-Werror,-Wundef-prefix=TARGET_OS_]
NIX_CFLAGS_COMPILE = lib.optionals stdenv.cc.isClang [ "-Wno-undef-prefix" ]
# Workaround build failure on -fno-common toolchains:
# duplicate symbol '_apple_platform' in:ui_cocoa.o cocoa_common.o
# TODO: drop when upstream gets a fix for it:
# https://github.com/libretro/RetroArch/issues/14025
++ lib.optionals stdenv.isDarwin [ "-fcommon" ];
NIX_CFLAGS_COMPILE = lib.optionals stdenv.cc.isClang [ "-Wno-undef-prefix" ];
passthru.tests = nixosTests.retroarch;
@ -145,5 +140,9 @@ stdenv.mkDerivation rec {
platforms = platforms.unix;
changelog = "https://github.com/libretro/RetroArch/blob/v${version}/CHANGES.md";
maintainers = with maintainers; teams.libretro.members ++ [ matthewbauer kolbycrouch ];
# FIXME: error while building in macOS:
# "Undefined symbols for architecture <arch>"
# See also retroarch/wrapper.nix that is also broken in macOS
broken = stdenv.isDarwin;
};
}

2
pkgs/applications/emulators/retroarch/wrapper.nix
View File

@ -34,7 +34,7 @@ stdenv.mkDerivation {
The following cores are included:
${lib.concatStringsSep "\n" (map (x: " - ${x.name}") cores)}
'';
# FIXME: exits with error on macOS:
# FIXME: exit with error on macOS:
# No Info.plist file in application bundle or no NSPrincipalClass in the Info.plist file, exiting
broken = stdenv.isDarwin;
};