mirror of
https://github.com/ilyakooo0/streamly.git
synced 2024-09-11 08:25:40 +03:00
Change the FileSystem.Handle from* APIs to put* Mutable write APIs would use a "put" prefix to make the name more intuitive.
2.3 KiB
2.3 KiB
Data Containers
Containers are persistent containers of data e.g. files, arrays, maps. For consistency we use similar API for all such containers where possible. Usually the API names are relative to the current module e.g. toBytes in an array module means converting the array to bytes, it sounds intuitive if read qualified with the module name e.g. Array.toBytes. This doc lists some conventions and guidelines to be followed.
Unfolds and Folds
- Unfolds are named as "read" or with a "read" prefix (e.g. readChunks).
- Folds are named as "write" or with a "write" prefix (e.g. writeChunks).
From and Put
- Immutable construction from some external source is named with a "from" prefix (e.g. fromList).
- Mutation of an existing container uses a "put" prefix instead of "from". When an API uses an existing container to write to and does not return a newly constructed container then use "put".
- "from" vs "put": "from" assumes creation of a new object, it may fail if the object being created already exists (e.g. the file exists), it may not take a lock as it assumes immutability. "put" may create a new object or overwrite an existing one, it may take a lock for writing as it assumes mutability.
To and Get
- Converting the complete object to an external representation is prefixed with "to" (e.g. toBytes).
- For mutable objects "get" APIs may be used instead of "to" APIs.
- "to" vs "get": "to" assumes immutable object so does not have to take a lock. "get" assumes mutable object so may take a lock.
Append
- Use "append" prefix for appending data at the end of a mutable container
Random Access (Arrays)
- getIndex (for arrays)
- getSlice/getRange/getIndices
- putIndex (for mutable arrays)
- append (for mutable arrays)
Key Access (Maps)
- getKey
- findKey (test existence)
- createKey (insert new key for mutable maps)
- putKey (insert or update for mutable maps)
- updateKey (update existing or fail)
- deleteKey (delete existing or fail)
- destroyKey (delete existing or not)
Points to Consider
The fold and unfold APIs can be used to express the to/from stream APIs. So we may not need both, it may just add to more APIs being proliferated.
We may need an "append" style fold as well? What would "stream" append operations be called then?
We may need locked version of "write" folds for mutable containers for concurrent access.