@ixv recently uncovered a bug (#2180) in Ford that caused certain
rebuilds to crash. @Fang- and I believe this change should fix the bug,
and we have confirmed that the reproduction that used to fail about two
thirds of the time now has not failed at all in the ten or so times
we've run it since then. @Fang- is still running more tests to confirm
the fix with more certainty.
It turned out the cause was that (depending on the rebuild order, which
is unspecified and should not need to be specified), Ford could enqueue
a provisional sub-build to be run but then, later in the same +gather
call, discover that the sub-build was in fact an orphan and delete it
from builds.state accordingly. Then when Ford tried to run the
sub-build, it would have already been deleted from the state, so Ford
would crash when trying to process its result in +reduce.
The fix was to make sure that when we discover a provisional sub-build
is orphaned, dequeue it from candidate-builds and next-builds to make
sure we don't try to run it. I'm about 95% sure this fix completely
solves the bug.
Strictly we just want to test the upgrade path for *Arvo* in this
script. Removing the 'make install' line makes sure that we use
whatever Vere version is accessible on our PATH.
There was a typo in the routing logic that was comparing equality
against a value where it should have been doing a pattern match. The
value compared against contained the literal * gate, which would never
match route.peer-state, so this condition was always true, meaning the
fix that had added this extra condition (5406f06) did not actually
change the behavior from what it been previously.
* origin/support-asan:
u3: enables ASan for u3i_molt and friends
u3: enable ASan for u3r_mean and friends
u3: skip RLIMIT_CORE under ASan
u3: specially defines c3_assert for ASan compatiblity
u3: moves loom base on linux-64 to accomodate ASan
Signed-off-by: Jared Tobin <jared@tlon.io>
16ae3b7 reinserted sh/test-whitespace into the Travis config to check
for the presence of spurious whitespace in source. While this is a fine
test to run, it should probably be run as a local pre-push git hook,
rather than in CI.
If we receive the naxplanation before the nack, the assertion in the gte
direction fails. The intent of the assertion is to make sure top of the
live queue never falls behind current.state, so it was simply in the
wrong direction.
Fixes a bug introduced in 4798b9d.
This, uh, fell into the same old case of using an arm from a |_ without
initializing that core with a sample first. In this case, that resulted
in the bowl in connect being the default bowl here. This is fine for
~zod, since it's the default ship, but gives incorrect behavior for
anyone else.
