Commit Graph

15750 Commits

Author SHA1 Message Date
Philip Monk
76b917f426
dojo: add tab completion
This is initial support for type-aware tab completion.  When you hit tab, it tries to complete the word you're in the middle of using a face or arm in the subject at that point in the code.  It also shows all possible matches and their associated types.  It's nearly instantaneous.  Notes:

- It advances to the longest common prefix, so if you hit tab on `ab` and the only possible results are `abcde` and `abcdz`, then it'll write `abcd` and print both out (with their types).

- If there are fewer than ten matches, it prints the type along with the face.  Printing types is too slow to use all the time, but with 10 it's essentially instantaneous.

- The match closest in the subject to you (i.e. smallest axis number) is displayed lowest (closest to your focus).

Examples below, where `<TAB>` represents me hitting tab while my cursor is at that position (the line with the `<TAB>` is not preserved in the actual output).

```
~zod:dojo> eth<TAB>
-----
ethereum        #t/<11.qcl {<3.ltb 27.ipf 7.ecf 36.uek 92.bjk 247.ows 51.mvt 126.xjf 41.mac 1.ane $141> <21.yeb 27.ipf 7.ecf 36.uek 92.bjk 247.ows 51.mvt 126.xjf 41.mac 1.ane $141>}>
ethereum-types  #t/<3.ltb 27.ipf 7.ecf 36.uek 92.bjk 247.ows 51.mvt 126.xjf 41.mac 1.ane $141>
~zod:dojo> ethereum
~zod:dojo> |=  zong=@ud  z<TAB>
-----
zing  #t/<1.dqs {* <126.xjf 41.mac 1.ane $141>}>
zap   #t/<1.iot {tub/{p/{p/@ud q/@ud} q/""} <1.rff {daf/@t <247.ows 51.mvt 126.xjf 41.mac 1.ane $141>}>}>
zuse  #t/$309
zong  #t/@ud
~zod:dojo> |=  zong=@ud  zo<TAB>
-----
zong  #t/@ud
~zod:dojo> |=  zong=@ud  zong
~zod:dojo> <TAB>
hoon-version
trel
quip
pole
unit
qual
lone
... about 600 more lines ...
unity
html
zuse
eny
now
our
~zod:dojo>
```

Functionally, this is in a state where I'd be comfortable shipping it.  It doesn't interfere with anything if you don't press tab, and it's perfectly OTA-able.  I do think its output is a little verbose, but that can be tuned over time as people try it and determine what feels good in practice.

Additional notes:

- There are plenty of similar systems for other languages, but my most direct inspiration is Idris's editor tools.  This is implemented for the dojo, but I actually want it in my editor, which is why the meat is all defind in a library.  I've only tested on dojo one-liners, so I don't know the performance on large blocks of code.

- The default type printer isn't great for this use case.  In particular,
	- Cores should not print anything about their context
  - The `#t/` should go away
  - If it looks like a gate, we should print its return value
  - Maybe special handling for molds, but if the above is done, then for example `bone` is  `* -> @ud`.

- The worst part about our wing ordering is that it really screws up tab completion.  You want to do `point.owner-address` instead of `owner-address.point` because that lets you type `point.ow<TAB>`.  I weakly prefer reading it how we do it now, but it's really not great.  You could do an (dojo-specific?) alternate syntax of `point;owner-address`; this is a simple transformation.

- Regardless of the above, this should handle the case where we're in the middle of defining a wing; it doesn't right now.

- When a variable is shadowed, we show both of them.  We should probably show the shadowed one with a `^`.

- We probably shouldn't print out hundreds of results.  Maybe just the closest 50 with ellipses.

- This gets you any face in your subject, regardless of whether its type is reasonable.  We could limit that some by copying the `gol` logic in mint, so that if the pseudo-backward-inference engine happens to know what type it should be, you can filter the tab results according to if they nest in that type.  This would be "strongly type-aware".
2019-10-30 23:19:25 -07:00
Jared Tobin
e77237d1a1
Revert "chat-hook: use sender's timestamp"
This reverts commit 22ddb712ff, which I
merged prematurely.  See later commentary in #1889.

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-10-29 15:20:28 +08:00
Jared Tobin
2a386d6c47
Merge branch 'chat-hook-when' (#1889)
* chat-hook-when:
  chat-hook: use sender's timestamp

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-10-28 04:20:10 +08:00
Fang
22ddb712ff
chat-hook: use sender's timestamp
No longer overwrite messages' timestamp on-receive, instead keeping whatever
timestamp was set by the sender.

This behavior matches that of the late Hall.
2019-10-27 13:43:26 +01:00
Jared Tobin
1f614c9fc3
Merge branch 'ohAitch/patch-1' (#1887)
* ohAitch/patch-1:
  eyre: fix wire=path terminology

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-10-26 17:57:14 +08:00
Jared Tobin
e313716b7f
Merge branch 'publish-fixes' (#1886)
* publish-fixes:
  publish: correctly set title and body when navigating with next/prev

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-10-26 17:55:32 +08:00
Jared Tobin
db85bccf84
Merge branch 'jt/release-pills' (#1877)
* jt/release-pills:
  build: add ropsten-pills target to Makefile
  build: add Ropsten derivations for arvo and pills
  vere: change default bootstrap pill URI

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-10-26 17:53:59 +08:00
Anton Dyudin
78d10f30cd
eyre: fix wire=path terminology 2019-10-25 16:04:29 -07:00
Isaac Visintainer
16364de935 publish: correctly set title and body when navigating with next/prev 2019-10-25 15:29:51 -07:00
Jared Tobin
7f124db8d9
Merge branch 'philip/jael-ames-full' (#1882)
* philip/jael-ames-full:
  jael: provide edge-triggered breach notification

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-10-25 14:05:01 +08:00
Jared Tobin
7add660077
Merge branch 'la-chat-sidebar' (#1885)
* la-chat-sidebar:
  chat-ui: fix image previews from url types
  chat-js: make clicking a url message open in a new tab
  chat-js: fix chat sorting and selection in sidebar

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-10-25 10:23:30 +08:00
Logan Allen
e06acb87be chat-ui: fix image previews from url types 2019-10-24 14:31:40 -07:00
Logan Allen
c8cca2f261 chat-js: make clicking a url message open in a new tab 2019-10-24 14:12:26 -07:00
Logan Allen
29fc32d11b chat-js: fix chat sorting and selection in sidebar 2019-10-24 14:04:48 -07:00
Philip Monk
9ddc04143a
jael: provide edge-triggered breach notification
Until now, clients of Jael have had to store the first-seen rift if they
want to reliably detect breaches.  Otherwise, they would get a false
positive if they heard an old message about a breach (eg if you kick
azimuth-tracker).  Clay and Gall did this correctly, but Ames did not.

Jael already maintains this state, so I added a notification to the
existing subscription that happens whenever it notices a breach (a diff
or full where the new rift is greater than the old one).

Because this is an issue on the live network, I wrote state adapters
for Gall and Clay.  The Gall one just removes the rift from our state,
but the Clay one is much more involved because we have to upgrade
instances of the clad monad that are possibly in progress.
Specifically, since more input is possible than before, we must wrap any
in-progress instances of the monad in a function that handles the
potential new input from Jael.  This temporarily preservers a copy of
the old kernel, but only until the current commit/merge/update has
completed.

The real solution for Clay is to factor out those IO-heavy instances to
userspace tapp/async/imp/threads, and if an upgrade happens in the
middle, you should simply restart them.

Fixes #1852
2019-10-23 21:40:34 -07:00
Jared Tobin
432a321e0c
build: add ropsten-pills target to Makefile
Adds a script for creating Ropsten pills, then adds it to the Makefile
under the 'ropsten-pills' target.
2019-10-24 10:03:52 +08:00
Jared Tobin
0bdced981e
build: add Ropsten derivations for arvo and pills
Arvo testnets typically use Ropsten's deploy of the Azimuth contract
instead of mainnet's.  This commit adds an 'arvo-ropsten' derivation for
Arvo as specialised to Ropsten.

In addition to using a different Azimuth address in %zuse, this also
configures %ames and :acme appropriately for running an alternate
network on Ropsten.  %ames has its protocol version incremented, and
:acme uses the Let's Encrypt staging API.

Included here are derivations for creating brass and ivory pills using
arvo-ropsten, to boot.
2019-10-24 10:03:52 +08:00
Jared Tobin
536e56d675
vere: change default bootstrap pill URI
Vere will attempt to download a pill from https://bootstrap.urbit.org if
not given one explicitly.  These pill filenames have traditionally had
the format:

  urbit-$URBIT_VERSION.pill

but this is inconsistent with the manner in which versions are referred
to elsewhere.  For example, release binaries are packaged in tarballs
with the names:

  urbit-linux64-v$URBIT_VERSION.tgz
  urbit-darwin-v$URBIT_VERSION.tgz

Note the 'v' prepended to URBIT_VERSION.

From v0.9.2 forward it is expected that bootstrap pills will also use
the 'v' prefix, i.e.

  urbit-v$URBIT_VERSION.pill

so this commit makes the appropriate change in the daemon.
2019-10-24 09:42:30 +08:00
Jared Tobin
03dd035ebb
Merge branch 'chat-cli-code-style' (#1880)
* chat-cli-code-style:
  chat-cli: minor code style fixes

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-10-24 09:31:17 +08:00
Fang
544d636701
chat-cli: minor code style fixes 2019-10-23 20:40:58 +02:00
Jared Tobin
150efffbd2
Merge branch 'jt/gall-ap-scry-fix' (#1868)
* jt/gall-ap-scry-fix:
  gall: fix bug in +ap-peek

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-10-23 08:36:36 +08:00
Jared Tobin
3fddf99260
Merge branch 'claz-invites-newline' (#1846)
* claz-invites-newline:
  claz: do invite file reading in +read-invites
  claz: ignore empty lines in invites file

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-10-23 08:36:07 +08:00
Jared Tobin
095a0a155a
Merge branch 'publish-fixes' (#1865)
* publish-fixes:
  publish: auto-resubscribe on quit, crash on failed subscription
  publish: added permission logic to %serve and import flows

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-10-23 08:35:01 +08:00
Jared Tobin
eddcbc4b08
Merge branch 'u3-errors' (#1872)
* u3-errors:
  u3: print messages for fatal errors to stderr
  u3: removes redundant memory fault assertion
  u3: use clearer assertions for loom corruption

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-10-23 08:34:02 +08:00
Joe Bryan
79aff11436 u3: print messages for fatal errors to stderr
u3l_log may send over a pipe, so message may not be delivered
if the error in question aborts the process
2019-10-22 13:00:09 -07:00
Joe Bryan
75dfcad6f7 u3: removes redundant memory fault assertion 2019-10-22 12:58:30 -07:00
Joe Bryan
9c7455f218 u3: use clearer assertions for loom corruption 2019-10-22 12:40:43 -07:00
Isaac Visintainer
0a5fcf8210 publish: auto-resubscribe on quit, crash on failed subscription 2019-10-22 10:18:34 -07:00
Isaac Visintainer
aed15a13b9 publish: added permission logic to %serve and import flows 2019-10-22 10:18:25 -07:00
Jared Tobin
050eff031a
Merge branch 'fix-tty-dimensions' (#1867)
* fix-tty-dimensions:
  vere: restore terminal dimensions measurement

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-10-22 15:44:00 +08:00
Jared Tobin
bdfc270b2f
gall: fix bug in +ap-peek
fc7901d2 refactored much of +ap-peek, but introduced a bug in the
process.  The relevant diff from that commit is as follows:

  -        =/  =path  [ren tyl]
  -        =/  =vase  !>((slag p.u.cug path))
  -        (ap-slam q.u.cug p.arm vase)
  +        =/  index  p.u.maybe-arm
  +        =/  term  q.u.maybe-arm
  +        =/  =vase
  +          =/  =path  [term tyl]
  +          =/  raw  (slag index path)
  +          !>  raw
  +        (ap-slam term p.arm vase)

Note that [ren tyl] was replaced with [term tyl], where 'term' and 'ren'
are not equal.  This commit merely rights that wrong.
2019-10-22 15:22:30 +08:00
Joe Bryan
645bde3f2d vere: restore terminal dimensions measurement 2019-10-21 22:41:02 -07:00
Jared Tobin
d8f5836876
Merge branch 'image-build' (#1856)
* image-build:
  build: simplify image build interface

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-10-22 10:25:55 +08:00
Brendan Hay
4813d9829b
build: simplify image build interface
This removes the baked in codedump inspection and wrapper scripts
in favour of downstream tooling overriding this as necessary by
using FROM <image> in their respective dockerfile.
2019-10-22 10:18:37 +08:00
Jared Tobin
71b27b0300
Merge branch 'pretty-userspace' (#1847)
* pretty-userspace:
  pills
  hoon: moves new pretty-printer back into userspace

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-10-22 10:12:05 +08:00
Jared Tobin
3210acd4de
vere: patch version bump (0.9.0 -> 0.9.1)
Also updates all pills.
2019-10-21 09:57:42 +08:00
Jared Tobin
7f25f26ac2
Merge branch 'worker-memory'
* worker-memory:
  u3: removes "worker_send_replace" printf
  u3: statically measure memory on startup if < 1/2 the loom is free
  u3: restore memory reclamation every 1k events
  u3: print the size of the free lists on |mass

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-10-21 08:29:22 +08:00
Jared Tobin
c0dafa16fa
Merge branch 'debug-symbols' (#1848)
* debug-symbols:
  build: always include debug symbols

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-10-21 08:28:38 +08:00
Jared Tobin
4ee03d4e6a
Merge branch 'chat-cli-join-prompt' (#1851)
* chat-cli-join-prompt:
  chat-cli: update prompt on ;join

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-10-21 08:28:16 +08:00
Jared Tobin
7be86ebd4f
Merge branch 'philip/ames-fix' (#1840)
* philip/ames-fix:
  ames: better stack traces
  ames: don't crash

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-10-21 08:26:21 +08:00
Jared Tobin
9522ba3b44
Merge branch 'philip/azt-fix' (#1838)
* philip/azt-fix:
  azimuth-tracker: fix |watch generator

Signed-off-by: Jared Tobin <jared@tlon.io>
2019-10-21 08:24:14 +08:00
Fang
9ed582b9c4
claz: do invite file reading in +read-invites
Ensures we read out the invite file in a consistent way
2019-10-18 16:15:11 +02:00
Fang
10b2643a50
chat-cli: update prompt on ;join
Fixes #1841.
2019-10-18 15:04:34 +02:00
Joe Bryan
10645a8d23 build: always include debug symbols 2019-10-17 18:20:23 -07:00
Joe Bryan
1c3b0adfb0 pills 2019-10-17 17:53:10 -07:00
Joe Bryan
fa01bfb0a5 hoon: moves new pretty-printer back into userspace 2019-10-17 17:52:45 -07:00
Fang
f0a4bd0369
claz: ignore empty lines in invites file 2019-10-18 02:10:39 +02:00
Philip Monk
be212ad54b
ames: better stack traces 2019-10-17 16:52:35 -07:00
Joe Bryan
85a656471f u3: removes "worker_send_replace" printf 2019-10-17 15:57:19 -07:00
Joe Bryan
1cfedf2273 u3: statically measure memory on startup if < 1/2 the loom is free 2019-10-17 15:50:28 -07:00