Commit Graph

18572 Commits

Author SHA1 Message Date
Elliot Glaysher
bf1f08e698 jets: Rebuild pills, the enabled jets here now don't leak memory. 2020-05-04 12:59:41 -07:00
Elliot Glaysher
1eb2e58bb7 jets: start trying to clean up memory leaks.
This cleans up memory leaks in the %ud/%da parsers/renderers,
while disabling everything else. There looks like there's a lot
of leaks in the +ob core.
2020-05-01 16:46:50 -07:00
Elliot Glaysher
e097bdda58 jets: first pass as (scow %da ...)
When trying to hook this up to +scot, I can reliably crash vere,
so there's still a bug here around memory.
2020-05-01 14:10:47 -07:00
Elliot Glaysher
d61a54d52a jets: implement (scow %p ...) for all ship types.
While working on this, realized there were bad reference counts in
my new +ob jets. This is likely to be a recurring problem here. I
tried replacing the +ob jets with hooks, but I ran into a bunch of
weirdness about calling these hooks from u3dc().
2020-04-30 16:28:30 -07:00
Elliot Glaysher
3f0e17bf70 jets: implement +fein:ob for the @p printer. 2020-04-30 13:17:44 -07:00
Elliot Glaysher
8e975917e8 jets: (scow %ud ...) is jetted, along with its +scot equivalent. 2020-04-30 13:07:20 -07:00
Elliot Glaysher
799c7e2ba3 jets: finish the %da parser and test it. 2020-04-30 11:08:23 -07:00
Elliot Glaysher
b947b569bb jets: implement partial %da parser.
This parses dates of the form '~2020.4.29', but not ones with time.
This uses a hook to call back to +year, since jetting that would be
a bit much.
2020-04-29 17:18:27 -07:00
Elliot Glaysher
1ef953c9ac jets: hand rolled c parser for (slaw %p ...)
This completes the c jetting for parsing %p strings in slaw.
2020-04-28 15:48:26 -07:00
Elliot Glaysher
91badd6376 jets: Rest of +ob that we're going to jet, and make +po callable.
All of the +ob jets that we need from the parsing jet are done.
Also changed how +po works to case based lookup tables so we can
call this code from other jets. (Also, linear search on every
syllable in a @p is kinda bad.)
2020-04-28 12:47:03 -07:00
Elliot Glaysher
ff86cbf12b jets: Implement most of +ob, minus the toplevel concealments. 2020-04-28 10:54:30 -07:00
Elliot Glaysher
bc9c4b67d6 jets: add the direct atom optimization to +mod
+mod was going to libgmp when both operands fit in 31-bits.
2020-04-27 17:41:34 -07:00
Elliot Glaysher
17d895241d jets: jet +fen:ob 2020-04-27 17:37:04 -07:00
Elliot Glaysher
716cd2013f jets: Start jetting +ob.
Since the most used parser in +slaw is the @p one, that's up next.
But first, we need to jet parts of +ob, which gets called through
+fed:ag.
2020-04-27 16:25:30 -07:00
Elliot Glaysher
55e9bd7056 jets: Add +slaw jet which parses %ud and %tas.
Falls back for other types.
2020-04-27 14:54:33 -07:00
Jared Tobin
55d2f555e9
Merge branch 'lf/chat-loading-indicator' (#2765)
* origin/lf/chat-loading-indicator:
  chat-fe: add backlog loading indicator

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-21 18:49:32 +04:00
Jared Tobin
2919b41675 meta: update issue templates
Adds a template for kernel/runtime bug reports.
2020-04-21 13:52:35 +04:00
Liam Fitzgerald
3ded8c9f68 chat-fe: add backlog loading indicator
Adds a backlog loading indicator that displays when we have not yet
received the backlog from the host.
2020-04-21 19:38:30 +10:00
Jared Tobin
0d897bd4de
Merge branch 'jt-boot-pill-deets' (#2771)
* origin/jt-boot-pill-deets:
  meta: add note re: announcing default pill

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-21 13:07:45 +04:00
Jared Tobin
995b92650e
Merge branch 'lf/unread-day-indicators' (#2768)
* origin/lf/unread-day-indicators:
  chat-fe: fix unreadnotice position on mobile
  chat-fe: add unread and day indicators

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-21 13:07:25 +04:00
Jared Tobin
bee001de26
Merge branch 'lf/contacts-separate-user' (#2766)
* origin/lf/contacts-separate-user:
  groups-js: seperate user's ship from rest of contacts

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-21 13:06:49 +04:00
Jared Tobin
358aa5025f
Merge branch 'liam-fitzgerald/lf/chat-markdown-input' (#2756)
* liam-fitzgerald/lf/chat-markdown-input:
  chat-js: revive # prefix for code messages
  chat-js: toggle code editor on icon click
  chat-js: disabled block level elements in messages
  chat-js: render markdown in messages
  chat-js: use CodeMirror for chat input
  chat-js: add CodeMirror dependency

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-21 13:06:18 +04:00
Jared Tobin
a9d10a5471
Merge branch 'liam-fitzgerald/lf/publish-del-edit' (#2734)
* liam-fitzgerald/lf/publish-del-edit:
  chat-fe: move cancel button below comment edit
  publish-js: lift editing state to comment list
  publish: fix check on edit-comment delta
  publish-js: avoid unnecessary scrollbars on note view
  publish-js: allow deletion and editing of comments
  publish: use @tas for comment ref in marks

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-21 13:05:57 +04:00
Jared Tobin
a5b9631c9e
Merge branch 'king-handle-ames-exception' (#2698)
* origin/king-handle-ames-exception:
  king: handle IOError from recvFrom in ames.
  king: increment version for new pill

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-21 13:05:29 +04:00
Liam Fitzgerald
2cec3c4e90 chat-fe: fix unreadnotice position on mobile 2020-04-21 16:58:30 +10:00
Liam Fitzgerald
0fc12b1456 Merge branch 'master' into lf/unread-day-indicators 2020-04-21 15:56:38 +10:00
Liam Fitzgerald
4083af515e Merge branch 'master' into lf/chat-markdown-input 2020-04-21 13:56:30 +10:00
Jared Tobin
39c707e596
Merge branch 'ed/chore-update-contributing' (#2380)
* origin/ed/chore-update-contributing:
  contributing.md: removed interface dev instructions from root-level doc, integrated into existing interface-specific doc
  contributing.md: added more pre-req detail to the beginning of the edit
  contributing.md: Added a new section outlining how to develop urbit's interface

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-20 13:17:27 +04:00
Jared Tobin
8306560a89
Merge branch 'liam-fitzgerald/mp/chat/firefox-take-2' (#2733)
* liam-fitzgerald/mp/chat/firefox-take-2:
  chat-fe: more FF scrollback fixes
  chat-fe: fix index issue with pending messages
  chat-fe: correct FF scroll behaviour
  chat: scrollToBottom on mount for FF
  chat: only scrolltobottom if first backlog grab
  chat: add firefox-specific chat window

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-20 12:41:51 +04:00
Jared Tobin
a2eaec6d6f
Merge branch 'm/link-perf' (#2728)
* origin/m/link-perf:
  link-listen-hook: partially revert 05e6519
  link fe: refactor message display into component
  link fe: more informative "empty list" display
  link-view: in pagination logic, only +lent once
  link: minimal initial view result
  link-view: add some hints to aid profiling

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-20 12:40:58 +04:00
Jared Tobin
2480a9514a
meta: add note re: announcing default pill
Resolves #2735.
2020-04-20 12:32:47 +04:00
Liam Fitzgerald
f10bf3c894 chat-fe: add unread and day indicators 2020-04-19 02:23:32 +10:00
Liam Fitzgerald
95edde5d27 groups-js: seperate user's ship from rest of contacts 2020-04-18 21:17:47 +10:00
Fang
dbc172af29
Merge pull request #2758 from urbit/m/chat-cli-order
chat-cli: account for reverse message ordering
2020-04-18 13:16:54 +02:00
Fang
0815c56d1d
Merge pull request #2746 from urbit/m/chat-hook-leave
chat-hook: on %remove, try our best to pull subs
2020-04-18 13:13:53 +02:00
Fang
9f42d420b3
chat-hook: remove incorrect comment
We do, in fact, use it. Implicitly, when reestablishing the subscription during
kick handling.
2020-04-18 13:13:08 +02:00
Liam Fitzgerald
4d118ce6c4 chat-js: revive # prefix for code messages 2020-04-18 15:10:19 +10:00
Liam Fitzgerald
535cace962 chat-js: toggle code editor on icon click
Toggles a code editor, to enable sending of 'code' type messages. 'me'
type messages are now sent by beginning a message with /me.
2020-04-17 21:46:17 +10:00
Liam Fitzgerald
11e69b7bd0 chat-js: disabled block level elements in messages 2020-04-17 21:13:58 +10:00
Liam Fitzgerald
5fbe955874 chat-fe: more FF scrollback fixes 2020-04-17 15:17:52 +10:00
Liam Fitzgerald
1b90328f39 chat-fe: fix index issue with pending messages
To produce message elements we iterate over pendingMessage ++ messages,
but to check whether they're adjacent to a message by the same author,
we index back into messages, which produces incorrect results when
pendingMessages is nonEmpty
2020-04-17 14:20:28 +10:00
Liam Fitzgerald
41be649764 Merge branch 'master' into mp/chat/firefox-take-2 2020-04-17 12:06:34 +10:00
Fang
6f13546e2d
chat-cli: account for reverse message ordering
#2618 changed the way chat-store orders messages. We need to account for that
when processing/printing. This is the minimum viable fix.
2020-04-16 16:52:40 +02:00
Jared Tobin
18878727b0
Merge branch 'liam-fitzgerald/lf/links-autoleave' (#2754)
* liam-fitzgerald/lf/links-autoleave:
  link: leave collection on leaving associated group

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-16 16:54:32 +04:00
Jared Tobin
e7984324be
Merge branch 'fix-pending' (#2751)
* origin/fix-pending:
  chat-js: fix chat ordering and pending messages

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-16 16:54:12 +04:00
Jared Tobin
6ef155b82b
Merge branch 'fix-chat-autojoin' (#2749)
* origin/fix-chat-autojoin:
  chat-js: fix auto-join and a chatSynced error
  chat-js: fix issue with autojoining

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-16 16:53:59 +04:00
Jared Tobin
b655105a38
Merge branch 'liam-fitzgerald/lf/link-ios-crash' (#2742)
* liam-fitzgerald/lf/link-ios-crash:
  link-js: fix pages disappearing on small screens

Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-16 16:53:36 +04:00
Liam Fitzgerald
a7a539bb24 link: leave collection on leaving associated group
Automatically leaves a collection when the user is removed from a group
2020-04-16 21:45:58 +10:00
Liam Fitzgerald
945fb3fca6 chat-js: render markdown in messages
Renders markdown in text messages but not url or code messages.
2020-04-16 20:21:29 +10:00
Liam Fitzgerald
9574765de6 chat-js: use CodeMirror for chat input
swaps out the textarea for a CodeMirror in markdown mode. Resolves an
issue related to the input shrinking with the content.
2020-04-16 20:21:29 +10:00