mirror of
https://github.com/ilyakooo0/vty.git
synced 2024-11-25 19:22:08 +03:00
f8f45c2af5
This change removes the aforementioned instances because they were misbehaved; merging Attr and MaybeDefault values with these instances resulted in field value losses. For example, before this change, (defAttr `withForeColor` blue) <> (defAttr `withBackColor` green) would result in just (defAttr `withBackColor` green) because the instances were designed to favor the right-hand arguments' fields even if they had not been explicitly set (a consequence of the MaybeDefault Semigroup instance). While that behavior was sensible specifically in the context of Graphics.Vty.Inline, it wasn't a useful user-facing API and it made for surprising instance behavior. Since there is actually no good way to handle this in a Semigroup instance for Attr -- some choices have to be made about how to merge two attributes' foreground colors, and that won't be much better than what we had -- the instance was just removed. I suspect that the risk of this impacting users negatively is very low, given that the instance behavior was not very useful. |
||
---|---|---|
.. | ||
Verify | ||
BenchImageFuzz.hs | ||
benchmark.hs | ||
BenchNoDiffOpt.hs | ||
BenchRenderChar.hs | ||
BenchVerticalScroll.hs | ||
ControlTable.hs | ||
current_benchmark_results.txt | ||
EventEcho.hs | ||
HereDoc.hs | ||
interactive_terminal_test.hs | ||
Issue18.hs | ||
Issue76.hs | ||
LICENSE | ||
Makefile | ||
MinimalExample.hs | ||
Rogue.hs | ||
Setup.lhs | ||
Test2.hs | ||
Verify.hs | ||
VerifyColor240.hs | ||
VerifyConfig.hs | ||
VerifyCropSpanGeneration.hs | ||
VerifyDisplayAttributes.hs | ||
VerifyEmptyImageProps.hs | ||
VerifyEvalTerminfoCaps.hs | ||
VerifyImageOps.hs | ||
VerifyImageTrans.hs | ||
VerifyInline.hs | ||
VerifyLayersSpanGeneration.hs | ||
VerifyOutput.hs | ||
VerifyParseTerminfoCaps.hs | ||
VerifySimpleSpanGeneration.hs | ||
VerifyUsingMockInput.hs | ||
VerifyUsingMockTerminal.hs | ||
VerifyUtf8Width.hs | ||
vty_inline_example.hs | ||
vty-examples.cabal | ||
YiIssue264.hs |