jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-12-23 17:53:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

Backport rules from elm-review-common

Browse Source
This commit is contained in:
Jeroen Engels 2021-04-06 17:32:30 +02:00
parent 9992afbff8
commit a26dd41382
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/NoExposingEverything.elm
View File

@ -84,7 +84,7 @@ declarationListVisitor declarations context =
( [ Rule.errorWithFix ( [ Rule.errorWithFix
{ message = "Module exposes everything implicitly \"(..)\"" { message = "Module exposes everything implicitly \"(..)\""
, details = , details =
[ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access it's internal details. Therefore, the API should be explicitly defined and ideally as small as possible." [ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access its internal details. Therefore, the API should be explicitly defined and ideally as small as possible."
] ]
} }
{ start = { row = range.start.row, column = range.start.column - 1 } { start = { row = range.start.row, column = range.start.column - 1 }

10
tests/NoExposingEverythingTest.elm
View File

@ -29,7 +29,7 @@ bar = 2
[ Review.Test.error [ Review.Test.error
{ message = "Module exposes everything implicitly \"(..)\"" { message = "Module exposes everything implicitly \"(..)\""
, details = , details =
[ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access it's internal details. Therefore, the API should be explicitly defined and ideally as small as possible." [ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access its internal details. Therefore, the API should be explicitly defined and ideally as small as possible."
] ]
, under = "(..)" , under = "(..)"
} }
@ -51,7 +51,7 @@ type Foo = Foo
[ Review.Test.error [ Review.Test.error
{ message = "Module exposes everything implicitly \"(..)\"" { message = "Module exposes everything implicitly \"(..)\""
, details = , details =
[ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access it's internal details. Therefore, the API should be explicitly defined and ideally as small as possible." [ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access its internal details. Therefore, the API should be explicitly defined and ideally as small as possible."
] ]
, under = "(..)" , under = "(..)"
} }
@ -72,7 +72,7 @@ type alias Foo = String
[ Review.Test.error [ Review.Test.error
{ message = "Module exposes everything implicitly \"(..)\"" { message = "Module exposes everything implicitly \"(..)\""
, details = , details =
[ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access it's internal details. Therefore, the API should be explicitly defined and ideally as small as possible." [ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access its internal details. Therefore, the API should be explicitly defined and ideally as small as possible."
] ]
, under = "(..)" , under = "(..)"
} }
@ -93,7 +93,7 @@ port foo : String
[ Review.Test.error [ Review.Test.error
{ message = "Module exposes everything implicitly \"(..)\"" { message = "Module exposes everything implicitly \"(..)\""
, details = , details =
[ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access it's internal details. Therefore, the API should be explicitly defined and ideally as small as possible." [ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access its internal details. Therefore, the API should be explicitly defined and ideally as small as possible."
] ]
, under = "(..)" , under = "(..)"
} }
@ -118,7 +118,7 @@ cons =
[ Review.Test.error [ Review.Test.error
{ message = "Module exposes everything implicitly \"(..)\"" { message = "Module exposes everything implicitly \"(..)\""
, details = , details =
[ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access it's internal details. Therefore, the API should be explicitly defined and ideally as small as possible." [ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access its internal details. Therefore, the API should be explicitly defined and ideally as small as possible."
] ]
, under = "(..)" , under = "(..)"
} }