mirror of
https://github.com/jfmengels/elm-review.git
synced 2024-08-17 03:50:24 +03:00
Backport rules from elm-review-common
This commit is contained in:
parent
9992afbff8
commit
a26dd41382
@ -84,7 +84,7 @@ declarationListVisitor declarations context =
|
|||||||
( [ Rule.errorWithFix
|
( [ Rule.errorWithFix
|
||||||
{ message = "Module exposes everything implicitly \"(..)\""
|
{ message = "Module exposes everything implicitly \"(..)\""
|
||||||
, details =
|
, details =
|
||||||
[ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access it's internal details. Therefore, the API should be explicitly defined and ideally as small as possible."
|
[ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access its internal details. Therefore, the API should be explicitly defined and ideally as small as possible."
|
||||||
]
|
]
|
||||||
}
|
}
|
||||||
{ start = { row = range.start.row, column = range.start.column - 1 }
|
{ start = { row = range.start.row, column = range.start.column - 1 }
|
||||||
|
@ -29,7 +29,7 @@ bar = 2
|
|||||||
[ Review.Test.error
|
[ Review.Test.error
|
||||||
{ message = "Module exposes everything implicitly \"(..)\""
|
{ message = "Module exposes everything implicitly \"(..)\""
|
||||||
, details =
|
, details =
|
||||||
[ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access it's internal details. Therefore, the API should be explicitly defined and ideally as small as possible."
|
[ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access its internal details. Therefore, the API should be explicitly defined and ideally as small as possible."
|
||||||
]
|
]
|
||||||
, under = "(..)"
|
, under = "(..)"
|
||||||
}
|
}
|
||||||
@ -51,7 +51,7 @@ type Foo = Foo
|
|||||||
[ Review.Test.error
|
[ Review.Test.error
|
||||||
{ message = "Module exposes everything implicitly \"(..)\""
|
{ message = "Module exposes everything implicitly \"(..)\""
|
||||||
, details =
|
, details =
|
||||||
[ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access it's internal details. Therefore, the API should be explicitly defined and ideally as small as possible."
|
[ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access its internal details. Therefore, the API should be explicitly defined and ideally as small as possible."
|
||||||
]
|
]
|
||||||
, under = "(..)"
|
, under = "(..)"
|
||||||
}
|
}
|
||||||
@ -72,7 +72,7 @@ type alias Foo = String
|
|||||||
[ Review.Test.error
|
[ Review.Test.error
|
||||||
{ message = "Module exposes everything implicitly \"(..)\""
|
{ message = "Module exposes everything implicitly \"(..)\""
|
||||||
, details =
|
, details =
|
||||||
[ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access it's internal details. Therefore, the API should be explicitly defined and ideally as small as possible."
|
[ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access its internal details. Therefore, the API should be explicitly defined and ideally as small as possible."
|
||||||
]
|
]
|
||||||
, under = "(..)"
|
, under = "(..)"
|
||||||
}
|
}
|
||||||
@ -93,7 +93,7 @@ port foo : String
|
|||||||
[ Review.Test.error
|
[ Review.Test.error
|
||||||
{ message = "Module exposes everything implicitly \"(..)\""
|
{ message = "Module exposes everything implicitly \"(..)\""
|
||||||
, details =
|
, details =
|
||||||
[ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access it's internal details. Therefore, the API should be explicitly defined and ideally as small as possible."
|
[ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access its internal details. Therefore, the API should be explicitly defined and ideally as small as possible."
|
||||||
]
|
]
|
||||||
, under = "(..)"
|
, under = "(..)"
|
||||||
}
|
}
|
||||||
@ -118,7 +118,7 @@ cons =
|
|||||||
[ Review.Test.error
|
[ Review.Test.error
|
||||||
{ message = "Module exposes everything implicitly \"(..)\""
|
{ message = "Module exposes everything implicitly \"(..)\""
|
||||||
, details =
|
, details =
|
||||||
[ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access it's internal details. Therefore, the API should be explicitly defined and ideally as small as possible."
|
[ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access its internal details. Therefore, the API should be explicitly defined and ideally as small as possible."
|
||||||
]
|
]
|
||||||
, under = "(..)"
|
, under = "(..)"
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user