Commit Graph

1060 Commits

Author SHA1 Message Date
Jeroen Engels
25cad184d0 Make Review.Test.expectConfigurationError work without run* functions 2021-03-10 17:09:16 +01:00
Jeroen Engels
d8de5557f1 Document configurationError 2021-03-10 17:09:16 +01:00
Jeroen Engels
f8f991d667 Simplify configurationError's ruleImplementation 2021-03-10 17:09:16 +01:00
Jeroen Engels
bd09b09530 Update @docs directives 2021-03-10 17:09:16 +01:00
Jeroen Engels
8ceb7e5c06 Check for configuration errors 2021-03-10 17:09:16 +01:00
Jeroen Engels
eafb0876f5 Report error when the details are empty 2021-03-10 17:09:16 +01:00
Jeroen Engels
3e884c8754 Don't report error when details are the same 2021-03-10 17:09:16 +01:00
Jeroen Engels
842f07b889 Report error that says details are different 2021-03-10 17:09:16 +01:00
Jeroen Engels
cfdc40f179 Don't report error when message is the same 2021-03-10 17:09:16 +01:00
Jeroen Engels
538597177e Report error that says message is different 2021-03-10 17:09:16 +01:00
Jeroen Engels
851be878a3 Extract configuration match check 2021-03-10 17:09:16 +01:00
Jeroen Engels
b2f04d3614 Compute whether the unsafeFunction is a valid function name 2021-03-10 17:09:16 +01:00
Jeroen Engels
efe502f52f Add details to the test expectation 2021-03-10 17:09:16 +01:00
Jeroen Engels
3e43ba80b3 Base configuration error off of buildTarget 2021-03-10 17:09:16 +01:00
Jeroen Engels
31a4dc53e0 Trigger configuration error in NoUnsafeRegexFromLiteral 2021-03-10 17:09:16 +01:00
Jeroen Engels
9e9ccf51ea Add Review.Rule.configurationError 2021-03-10 17:09:16 +01:00
Jeroen Engels
632104f357 Add configuration error property 2021-03-10 17:09:16 +01:00
Jeroen Engels
6d673e934d Hope for a configurationError property 2021-03-10 17:09:16 +01:00
Jeroen Engels
a0e288da13 Check for configuration errors in tests 2021-03-10 17:09:16 +01:00
Jeroen Engels
7a8fc67e08 Report an error if no configuration error was found 2021-03-10 17:09:16 +01:00
Jeroen Engels
33bbd18b0d Report an error if a configuration error happened 2021-03-10 17:09:16 +01:00
Jeroen Engels
fdc25443d1 Add configuration error 2021-03-10 17:09:16 +01:00
Jeroen Engels
35e9f76104 Remove unnecessary describe imports in documentation 2021-03-10 17:02:21 +01:00
Jeroen Engels
92e4aaca2d Remove odd documentation line 2021-03-10 17:02:21 +01:00
Jeroen Engels
dae294bca6 Report error when details for global errors is empty 2021-03-10 17:02:21 +01:00
Jeroen Engels
31518d9984 Take units as arguments 2021-03-10 17:02:21 +01:00
Jeroen Engels
7a2978925f Make emptyDetails take a String 2021-03-10 17:02:21 +01:00
Jeroen Engels
08cad45b99 Fix linting errors 2021-03-10 17:02:21 +01:00
Jeroen Engels
33d1d084d1 Disable NoUnsafeRegexFromLiteral 2021-03-10 17:02:21 +01:00
Jeroen Engels
f12ad9b7f1 Document expectGlobalAndLocalErrors and expectGlobalAndModuleErrors 2021-03-10 17:02:21 +01:00
Jeroen Engels
58a9974947 Document expectGlobalErrors 2021-03-10 17:02:21 +01:00
Jeroen Engels
e2f9cf74ea Remove outdated requirement for tests 2021-03-10 17:02:21 +01:00
Jeroen Engels
d2dae4cf7b Update @docs 2021-03-10 17:02:21 +01:00
Jeroen Engels
b28308e02b Document Rule.globalError 2021-03-10 17:02:21 +01:00
Jeroen Engels
a8b93bd94d Use left-pizza consistently for Expect.fail 2021-03-10 17:02:21 +01:00
Jeroen Engels
48da8cded0 Rename removeWhitespace function 2021-03-10 17:02:21 +01:00
Jeroen Engels
49025a5855 Fail when expected error could not be found 2021-03-10 17:02:21 +01:00
Jeroen Engels
adc4ab336e Report error message when details are different 2021-03-10 17:02:21 +01:00
Jeroen Engels
253b04187e Add unexpectedGlobalErrorDetails 2021-03-10 17:02:21 +01:00
Jeroen Engels
f1f97de257 Change error message for unexpectedDetails 2021-03-10 17:02:21 +01:00
Jeroen Engels
e50f753d31 Report an error when there are too many errors 2021-03-10 17:02:21 +01:00
Jeroen Engels
ec21dee1da Remove unused temp function 2021-03-10 17:02:21 +01:00
Jeroen Engels
5e112638f7 Change test breakage 2021-03-10 17:02:21 +01:00
Jeroen Engels
279ac055bb Remove handling of global error module name 2021-03-10 17:02:21 +01:00
Jeroen Engels
e7972faa3f Show correct failure message 2021-03-10 17:02:21 +01:00
Jeroen Engels
111ec4589b Additional branching 2021-03-10 17:02:21 +01:00
Jeroen Engels
f64684c02a tmp 2021-03-10 17:02:21 +01:00
Jeroen Engels
124748a3cf Fail when there are too many errors 2021-03-10 17:02:21 +01:00
Jeroen Engels
614f9d8a49 Outline happy path 2021-03-10 17:02:21 +01:00
Jeroen Engels
bbc4697d9f Duplicate 2021-03-10 17:02:21 +01:00