Commit Graph

604 Commits

Author SHA1 Message Date
Jeroen Engels
3e69688bd5 Add tests for phantom type tests to make sure we don't start allowing some constructs 2020-03-19 23:00:40 +01:00
Jeroen Engels
160cea7323 Remove module visitors for rules that didn't need them 2020-03-19 19:35:45 +01:00
Jeroen Engels
3077047e63 Make Scope add all visitors at once 2020-03-19 19:28:01 +01:00
Jeroen Engels
f076643150 Remove context and visitor argument for newProjectRuleSchema 2020-03-19 19:21:49 +01:00
Jeroen Engels
ef74ec5126 Use module context from moduleVisitor field 2020-03-19 19:11:45 +01:00
Jeroen Engels
d07676dd29 Use module visitors from moduleVisitor field 2020-03-19 19:03:12 +01:00
Jeroen Engels
ce7c6b7021 Move initial project context to an argument of Rule.newProjectRuleSchema 2020-03-19 19:03:12 +01:00
Jeroen Engels
2ab777e6f6 Add a moduleVisitor field to ProjectRuleSchema containing the module visitor data 2020-03-19 17:56:40 +01:00
Jeroen Engels
4b0a56dd21 Add withModuleVisitors function 2020-03-19 17:17:57 +01:00
Jeroen Engels
8b1050b2f8 Visit modules in project rule more efficiently and only if necessary 2020-03-19 00:21:45 +01:00
Jeroen Engels
f37b19d6ed Only compute the module visitors once 2020-03-19 00:06:58 +01:00
Jeroen Engels
8f83d4161f Prepare for being able to supply multiple moduleVisitors to a project rule 2020-03-18 23:56:52 +01:00
Jeroen Engels
3b2449af08 Allow to expect for README errors in tests 2020-03-18 23:25:56 +01:00
Jeroen Engels
8273322832 Allow elm.json visitors to report errors in project rules 2020-03-18 23:08:06 +01:00
Jeroen Engels
66a1f8cb3c Allow dependencies visitors to report errors in project rules 2020-03-18 23:01:04 +01:00
Jeroen Engels
550db23f0a Add visitor for the README.md 2020-03-18 22:49:42 +01:00
Jeroen Engels
735d45d6ce Simplify NoTodoComment 2020-03-18 22:31:33 +01:00
Jeroen Engels
7c76d8947a Add README support to Review.Project 2020-03-18 21:01:12 +01:00
Jeroen Engels
4263f35db9 Add dummy rule that will look at the README 2020-03-18 20:32:31 +01:00
Jeroen Engels
7f9435e887 Add NoTodoComment to review configuration 2020-03-18 17:50:32 +01:00
Jeroen Engels
c619e2c484 Improve the range for NoTodoComment 2020-03-18 17:35:11 +01:00
Jeroen Engels
d1e77c29bf Improve comment on NoTodoComment rule 2020-03-17 23:28:47 +01:00
Jeroen Engels
b0614b62c7 Improve documentation for newModuleRuleSchema 2020-03-17 23:00:02 +01:00
Jeroen Engels
cff1770300 Mention Direction in expression and declaration visitors 2020-03-17 22:42:10 +01:00
Jeroen Engels
f02095e960 Document fromProjectRuleSchema 2020-03-17 18:38:28 +01:00
Jeroen Engels
f9abd790a5 Add NoTodoComment rule draft 2020-03-16 23:03:19 +01:00
Jeroen Engels
22f4356953 Document with*Comments visitors 2020-03-16 23:02:43 +01:00
Jeroen Engels
034c99c750 Document withDependencies* visitors 2020-03-16 22:12:45 +01:00
Jeroen Engels
955110a26c Ignore .idea files 2020-03-16 21:04:02 +01:00
Jeroen Engels
5268628c0d Document withProjectFinalEvaluation 2020-03-16 21:03:34 +01:00
Jeroen Engels
f79471a626 Document withElmJsonProjectVisitor 2020-03-16 20:15:36 +01:00
Jeroen Engels
b375518183 Rename errorForFile to errorForModule and add documentation 2020-03-15 23:39:35 +01:00
Jeroen Engels
8013011d1a Handle phantom types outside of the module 2020-03-15 22:53:45 +01:00
Jeroen Engels
68eda525b5 Handle imports from other modules 2020-03-15 14:12:22 +01:00
Jeroen Engels
abcd73f0e4 Mark custom types... 2020-03-14 21:13:23 +01:00
Jeroen Engels
9b2bdb61c6 Update elm and elm-test version 2020-03-13 15:42:19 +01:00
Jeroen Engels
36b71557da WIP Mark custom type constructors from other modules as used. 2020-03-12 19:19:06 +01:00
Jeroen Engels
06f46e4690 NoUnused.CustomTypeConstructors: Use Scope 2020-03-12 18:00:20 +01:00
Jeroen Engels
ad2f929d7e Report custom type constructors that are exposed 2020-03-12 17:46:51 +01:00
Jeroen Engels
36a3478828 NoUnused.CustomTypeConstructors: Report unused exposed type constructors 2020-03-12 17:23:00 +01:00
Jeroen Engels
4117baf838 Rename NoUnused.CustomTypeConstructors temporarily 2020-03-12 17:05:36 +01:00
Jeroen Engels
ce1c059d4c NoUnused.CustomTypeConstructors: Transform into a project rule 2020-03-12 16:59:14 +01:00
Jeroen Engels
b2fd92f529 NoUnused.CustomTypeConstructors: Prepare looking at other modules 2020-03-12 16:50:03 +01:00
Jeroen Engels
ce4febc1ac Support phantom types in NoUnused.CustomTypeConstructors 2020-03-11 17:51:09 +01:00
Jeroen Engels
c67aa1321c WIP: Don't report custom type constructors used as phantom types 2020-03-09 22:42:16 +01:00
Jeroen Engels
e438da283d Copy over NoUnused.CustomTypeConstructors temporarily 2020-03-09 21:21:38 +01:00
Jeroen Engels
050f5e4958 Improve documentation for Review.Project.dependencies 2020-03-09 20:08:35 +01:00
Jeroen Engels
416357b236 Document the Review.Project.Dependency module 2020-03-08 20:07:37 +01:00
Jeroen Engels
c141fdb1ae Rename module rule's phantom fields to canCollectProjectData 2020-03-08 00:54:18 +01:00
Jeroen Engels
0d33ab05e7 Improve the error message when Review.Test.runOnModules is given an empty list 2020-03-07 20:11:07 +01:00