microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-01-05 19:04:43 +03:00
Code Issues Projects Releases Wiki Activity

fix(trace-viewer): report upload error as aria-role=alert (#29956)

Browse Source 
Turns out NVDA and Narrator work differently. This is a follow-up to
https://github.com/microsoft/playwright/pull/29838 which was not working
in NVDA before - looks like a NVDA bug. Using alert instead.

Relates
https://github.com/microsoft/playwright/issues/29095#issuecomment-1999332067
This commit is contained in:
Max Schmitt 2024-03-15 16:25:36 +01:00 committed by GitHub
parent 94348bb3c5
commit 3e78426acc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/trace-viewer/src/ui/workbenchLoader.tsx
View File

@ -162,7 +162,7 @@ export const WorkbenchLoader: React.FunctionComponent<{
</div>
</div>}
{showFileUploadDropArea && <div className='drop-target'>
<div className='processing-error' aria-live='assertive'>{processingErrorMessage}</div>
<div className='processing-error' role='alert'>{processingErrorMessage}</div>
<div className='title' role='heading' aria-level={1}>Drop Playwright Trace to load</div>
<div>or</div>
<button onClick={() => {