microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-12-15 06:02:57 +03:00
Code Issues Projects Releases Wiki Activity

test: update console tests (#223)

Browse Source
This commit is contained in:
Pavel Feldman 2019-12-12 08:58:37 -08:00 committed by Dmitry Gozman
parent 66e93ce2c0
commit cca2659578
2 changed files with 6 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/webkit/FrameManager.ts
View File

@ -413,7 +413,7 @@ export class FrameManager extends EventEmitter implements PageDelegate {
} }
return context._createHandle(p); return context._createHandle(p);
}); });
this._page._addConsoleMessage(derivedType, handles, { url, lineNumber, columnNumber }, handles.length ? undefined : text); this._page._addConsoleMessage(derivedType, handles, { url, lineNumber: lineNumber - 1, columnNumber: columnNumber - 1 }, handles.length ? undefined : text);
} }
_onDialog(event: Protocol.Dialog.javascriptDialogOpeningPayload) { _onDialog(event: Protocol.Dialog.javascriptDialogOpeningPayload) {

23
test/page.spec.js
View File

@ -240,22 +240,7 @@ module.exports.addTests = function({testRunner, expect, headless, playwright, FF
else else
expect(message.type()).toEqual('warn'); expect(message.type()).toEqual('warn');
}); });
it.skip(FFOX || WEBKIT)('should have location when fetch fails', async({page, server}) => { it('should have location for console API calls', async({page, server}) => {
// The point of this test is to make sure that we report console messages from
// Log domain: https://vanilla.aslushnikov.com/?Log.entryAdded
await page.goto(server.EMPTY_PAGE);
const [message] = await Promise.all([
waitEvent(page, 'console'),
page.setContent(`<script>fetch('http://wat');</script>`),
]);
expect(message.text()).toContain(`ERR_NAME_NOT_RESOLVED`);
expect(message.type()).toEqual('error');
expect(message.location()).toEqual({
url: 'http://wat/',
lineNumber: undefined
});
});
it.skip(WEBKIT)('should have location for console API calls', async({page, server}) => {
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
const [message] = await Promise.all([ const [message] = await Promise.all([
waitEvent(page, 'console'), waitEvent(page, 'console'),
@ -263,10 +248,12 @@ module.exports.addTests = function({testRunner, expect, headless, playwright, FF
]); ]);
expect(message.text()).toBe('yellow'); expect(message.text()).toBe('yellow');
expect(message.type()).toBe('log'); expect(message.type()).toBe('log');
expect(message.location()).toEqual({ const location = message.location();
// Engines have different column notion.
delete location.columnNumber;
expect(location).toEqual({
url: server.PREFIX + '/consolelog.html', url: server.PREFIX + '/consolelog.html',
lineNumber: 7, lineNumber: 7,
columnNumber: 14,
}); });
}); });
// @see https://github.com/GoogleChrome/puppeteer/issues/3865 // @see https://github.com/GoogleChrome/puppeteer/issues/3865