Simon Knott
f84539bf00
cherry-pick( #32145 ): doc(release notes): Fix 1.46 release notes typos ( #32145 )
2024-08-29 11:21:07 +02:00
Max Schmitt
e1c861cfa7
cherry-pick( #32021 ): test: fix failing client-certificate tests
2024-08-16 21:45:12 +02:00
Max Schmitt
20b0788101
chore: mark v1.46.1 ( #32194 )
2024-08-16 20:24:42 +02:00
Max Schmitt
57c324002a
cherry-pick( #32192 ): chore: generate self-signed certificates for socks proxy
2024-08-16 20:22:14 +02:00
Playwright Service
301f179735
cherry-pick( #32189 ): fix(only-changed): show nice error message about shallow clones ( #32190 )
...
This PR cherry-picks the following commits:
- 06ffdd61c9
2024-08-16 11:46:29 +02:00
Playwright Service
b2d6a0916e
cherry-pick( #32164 ): docs: release video and trace viewer video ( #32173 )
...
This PR cherry-picks the following commits:
- f927495
2024-08-15 13:16:32 +02:00
Simon Knott
7cf7aec97f
cherry-pick( #32094 ): fix(test runner): run project dependencies of --only-changed test files ( #32172 )
...
Closes https://github.com/microsoft/playwright/issues/32070 . We were
applying `additionalFileMatcher` not just to `filteredProjectSuites`,
but also to `projectSuites`. `projectSuites` is where we take dependency
projects from, though - so `--only-changed` led to empty dependency
projects, resulting in the reported bug.
The fix is to only apply `additionalFileMatcher` on
`filteredProjectSuites`.
2024-08-15 13:10:41 +02:00
Max Schmitt
d78ae0179d
cherry-pick( #32163 ): fix(client-certificates): stall on tls handshake errors
...
Extracted from https://github.com/microsoft/playwright/pull/32158 .
2024-08-15 10:26:04 +02:00
Max Schmitt
bd13da4132
cherry-pick( #32155 ): fix(client-certificates): when server does tls renegotiation
...
Certain https servers like Microsoft IIS aka. TLS servers do the TLS
renegotiation after the TLS handshake. This ends up in two
`'secureConnect'` events due to an upstream Node.js bug:
https://github.com/nodejs/node/issues/54362
Drive-by: Move other listeners like `'close'` / `'end'` to `once()` as
well.
Relates https://github.com/microsoft/playwright/issues/32004
2024-08-14 20:33:02 +02:00
Dmitry Gozman
30684a77e7
cherry-pick( #32066 ): fix(types): revert type changes made to support TS 5.5 ( #32080 )
...
Regressed in #31532 . The TS5.5 changes broke chaining of `extend`s where
the first `extend` did not specify any type arguments.
Fixes #32056 .
2024-08-08 09:11:44 -07:00
Max Schmitt
5e68061d49
cherry-pick( #32015 ): docs(release-notes): fix typo in .NET release notes
2024-08-06 07:20:54 +02:00
Dmitry Gozman
99a3631057
chore: mark v1.46 ( #32013 )
2024-08-05 06:35:35 -07:00
Max Schmitt
929fef348e
cherry-pick( #32012 ): chore(lint): bump Microsoft.CodeAnalysis for linting code snippets
2024-08-05 14:55:42 +02:00
Max Schmitt
cf31aa8b4c
cherry-pick( #32008 ): chore(client-certificates): rewrite error for unsupported PFX errors
2024-08-05 14:44:12 +02:00
Max Schmitt
ed9b4d9b9a
cherry-pick( #32007 ): fix(client-certificates): report error to the browser if incorrect passphrase
2024-08-05 14:43:58 +02:00
Max Schmitt
fca1fa0b95
cherry-pick( #31973 ): chore: run client-certificate tests in service mode
2024-08-05 14:43:44 +02:00
Dmitry Gozman
ff11273c7b
cherry-pick( #32010 ): docs: release notes for 1.46 update
2024-08-05 13:36:33 +01:00
Yury Semikhatsky
4953ac3072
cherry-pick( #31975 ): chore: remove bright counter from sidebar tab se… ( #31976 )
...
…lector
Removing the following icon:
HTML `options` element cannot be styled, so just removing the counter in
sidebar mode:
<img width="348" alt="image"
src="https://github.com/user-attachments/assets/d636dca2-5007-41f7-866e-3a0f604d46fc ">
2024-08-02 10:32:48 -07:00
Yury Semikhatsky
4c66f8aeda
cherry-pick( #31970 ): fix(trace): do not place expect into unfinished … ( #31974 )
...
…api calls based on time
Fixes https://github.com/microsoft/playwright/issues/31959
2024-08-01 14:47:37 -07:00
Dmitry Gozman
deba37b6b5
cherry-pick( #31960 ): feat(ui mode): linkify attachment names and content ( #31971 )
...
- Pass `contentType` to the CodeMirror.
- Support `text/markdown` mode.
- Custom mode for non-supported types that linkifies urls.
2024-08-01 13:24:14 -07:00
Max Schmitt
2cfe733e30
cherry-pick( #31961 ): fix(trace-viewer): make 'hide route actions' work for .NET
2024-08-01 21:03:45 +02:00
Dmitry Gozman
5fdf97658e
cherry-pick( #31945 ): feat(ui-mode): add annotations tab ( #31968 )
...
<img width="867" alt="image"
src="https://github.com/user-attachments/assets/7d714723-1d3f-49b2-944a-0a476d79aee8 ">
2024-08-01 11:53:04 -07:00
Dmitry Gozman
29ba72c06b
cherry-pick( #31952 ): fix(ui mode): api review feedback ( #31964 )
...
- Hide "Testing Options" as not ready.
- Update SettingsView margins.
- Include `page.route` and similar methods into "Show route actions".
2024-08-01 11:23:07 -07:00
Simon Knott
b20e154902
cherry-pick( #31958 ): fix(ui): only populate settings once ( #31963 )
...
Cherry-picks https://github.com/microsoft/playwright/pull/31958 into the
release.
2024-08-01 09:28:40 -07:00
Max Schmitt
876e0e4ba9
cherry-pick( #31955 ): feat(chromium): roll to r1129
2024-08-01 14:33:35 +02:00
Dmitry Gozman
3ab19c6229
cherry-pick( #31928 ): fix(trace): make sure the correct attachment name is used for downloads
...
When two attachments have the same content sha1, we used the first one's
name for the downloaded file, no matter which one the user clicked to
download. Now we pass the name explicitly.
References #31912 .
2024-08-01 06:44:55 +01:00
Dmitry Gozman
8d35c1b517
cherry-pick( #31920 ): fix(trace viewer): attachment download
...
- Update attachments tab margins.
- Make sure to pass `&download` in attachment urls. This makes them
downloadable, regressed in #28727 .
- Do not additionally list image diffs as screenshots.
Fixes #31912 .
2024-08-01 06:44:22 +01:00
Yury Semikhatsky
71b8e22501
cherry-pick( #31939 ): chore(trace-viewer): copy only file name without… ( #31942 )
...
… line number
As discussed in the meeting, copy only file name which is shown in the
same line, do not include highlighted line number.
2024-07-31 17:59:39 -07:00
Yury Semikhatsky
71e5eade8c
cherry-pick( #31940 ): chore(trace-viewer): less bright status code icon ( #31944 )
...
<img width="182" alt="image"
src="https://github.com/user-attachments/assets/8b381bcc-46e3-45c7-8fd2-e020436d1bff ">
<img width="206" alt="image"
src="https://github.com/user-attachments/assets/4ea02b47-a4da-44f7-9c26-13b05374e89d ">
<img width="213" alt="image"
src="https://github.com/user-attachments/assets/38b50e2a-f69c-4a78-abb2-2680453fc5fd ">
2024-07-31 17:58:25 -07:00
Yury Semikhatsky
7ff46d4596
cherry-pick( #31938 ): chore(trace-viewer): do not shrink metadata view ( #31943 )
...
Avoids the following effect:
2024-07-31 17:58:02 -07:00
Yury Semikhatsky
ca9ddff7ca
cherry-pick( #31934 ): chore: make sure error stack includes message as… ( #31935 )
...
… before #31691
This brings stack formatting to how it was prior to
1686e5174d
2024-07-31 11:07:45 -07:00
Max Schmitt
dfecfa5be1
cherry-pick( #31914 ): chore: various roll fixes for .NET
2024-07-30 19:10:50 +02:00
Dmitry Gozman
468b9b1e7a
cherry-pick( #31894 ): feat(ui mode): ui updates ( #31916 )
...
- Update copy to clipboard button.
- Reveal test source in the Source tab instead of external editor.
- New button to reveal in the external editor in the Source tab.
- Move the Pick Locator button next to snapshot tabs.
2024-07-30 09:23:19 -07:00
Max Schmitt
64e4a9b0eb
cherry-pick( #31913 ): fix(client-certificates): use matching origin for connections on :443
...
Motivation: When using client-certificates on a website on port `443`,
we would normalise the user input with `new URL` but still generate a
"bad" representation of the "origin" internally, since the just do
concatenated "host:port".
(The origin doesn't contain the port in case of :443)
We use `clientCertificatesToTLSOptions` in two places:
a) for APIRequestContext, there we pass one from the URL constructor
over and
b) from the socks proxy, there we **now** also pass a "good one" over.
Test plan: We don't want to run the tests on port :443, so only manually
validated the fix.
Relates https://github.com/microsoft/playwright/issues/31906
2024-07-30 12:31:50 +02:00
Max Schmitt
446de523c4
cherry-pick( #31898 ): fix(client-certificates): don't use proxy when using BrowserContext.request
2024-07-29 16:45:34 +02:00
Max Schmitt
2ea14ca2c4
cherry-pick( #31893 ): chore: add maxRetries to APIRequestContext.delete
2024-07-29 14:53:27 +02:00
Max Schmitt
185a2867c6
cherry-pick( #31897 ): fix(client-certificates): error response body Content-Length calculation
2024-07-29 14:53:12 +02:00
Max Schmitt
57c7d9e9bb
docs: add release notes for 1.46 ( #31875 )
...
Signed-off-by: Max Schmitt <max@schmitt.mx>
Signed-off-by: Dmitry Gozman <dgozman@gmail.com>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
2024-07-26 08:34:26 -07:00
Dmitry Gozman
9227d1c598
docs: explain a bit more about fixture boxing and custom titles ( #31877 )
2024-07-26 07:43:58 -07:00
Max Schmitt
6988194c97
test: unflake contextmenu recorder test ( #31749 )
2024-07-26 12:43:05 +02:00
Max Schmitt
b214941a01
chore: make it more clear that --only-changed is per file ( #31874 )
2024-07-26 12:41:33 +02:00
Max Schmitt
47e4e45bc2
chore: update WebKit version to 18.0 ( #31873 )
2024-07-26 11:32:51 +02:00
Max Schmitt
09581b615d
fix(client-certificates): return target errors on response when using http2 ( #31867 )
2024-07-26 11:28:45 +02:00
Max Schmitt
335d31bf65
devops: remove GHA todo in primary workflow for itest ( #31871 )
...
This TODO got added during our GHA refactoring a while ago, where I
thought it might make sense to run our itests in `bash`. We didn't do it
before the refactoring either. It seems good to keep them running in
`pwsh` instead, so lets just remove the TODO.
Investigation notes: Running in `bash` on Windows via `Git Bash` seems
like doing a lot of magic, especially with path handling. Things
[like](a02ed38e60/tests/installation/registry.ts (L143)https://sourceforge.net/p/mingw/mailman/mingw-users/thread/54CE104A.7060108@hccnet.nl/ ).
Signed-off-by: Max Schmitt <max@schmitt.mx>
2024-07-26 11:04:51 +02:00
Max Schmitt
81b3c0c402
fix(client-certificates): include socks-certs in npm package ( #31872 )
2024-07-26 11:04:38 +02:00
Max Schmitt
a02ed38e60
chore: reduce file reads in client-certificates internal TLS server ( #31865 )
2024-07-25 22:36:25 +02:00
Dmitry Gozman
a41cebc1c9
feat(ui mode): introduce Testing Options and Settings ( #31841 )
...
Testing Options control tests, while Settings are UI mode settings.
<img width="298" alt="Screenshot 2024-07-25 at 10 54 22 AM"
src="https://github.com/user-attachments/assets/7b6f5fff-687b-48d1-80b3-d1e6f2a257e8 ">
These sections are separately expandable, collapsed by default.
<img width="294" alt="Screenshot 2024-07-24 at 2 06 25 PM"
src="https://github.com/user-attachments/assets/5d35ac8c-9289-46ca-aaa2-ebc5419fa0c4 ">
References #31520 .
---------
Signed-off-by: Simon Knott <info@simonknott.de>
Co-authored-by: Simon Knott <info@simonknott.de>
2024-07-25 11:23:43 -07:00
Max Schmitt
a966abfd31
test: unflake happy-eyeballs tests ( #31861 )
2024-07-25 20:22:51 +02:00
Dmitry Gozman
d8d5289e86
fix(remote): make sure api calls reject before browser is closed ( #31858 )
...
Upon calling `browser.close()` or dropping remote connection, make sure
to reject api calls before resolving `browser.close()` and firing a
`disconnected` event.
This change aligns the order guarantee with non-remote case.
2024-07-25 09:57:34 -07:00
Max Schmitt
0c6ecf8df4
chore: use happy eyeballs for client-certificates ( #31859 )
2024-07-25 18:55:47 +02:00
