Pavel Feldman
f9b437a49e
chore: pull common functionality into the BrowserTypeBase ( #2312 )
2020-05-20 16:30:04 -07:00
Pavel Feldman
aa0d844c76
chore: introduce utility script for evaluate helpers ( #2306 )
2020-05-20 15:55:33 -07:00
Yury Semikhatsky
d99ebc9265
browser(webkit): fix mac compilation ( #2317 )
2020-05-20 15:48:31 -07:00
Dmitry Gozman
48440f7ed7
test: unflake fixtures test ( #2313 )
...
Drive-by: ensure we call onkill before manually exiting the process.
2020-05-20 14:58:27 -07:00
Yury Semikhatsky
9808d8bc03
browser(webkit): add Playwright enable/disable commands ( #2314 )
2020-05-20 14:54:47 -07:00
Dmitry Gozman
b17a73c184
test: try to unflake cookie test ( #2310 )
...
Happens on WebKit sometimes. There is probably a race between setting a cookie
and saving it in the cookie jar in another process.
2020-05-20 14:54:21 -07:00
Joel Einbinder
8e396fdac0
fix(types): add missing types for removing event listeners ( #2307 )
2020-05-20 07:34:36 -07:00
Pavel Feldman
e558f0516b
chore: print the launch error message to console ( #2304 )
2020-05-20 00:10:10 -07:00
Andrey Lushnikov
e658a3e48a
docs(click.md): update click.md documentation ( #2303 )
...
Updates according to 545c43d28d
2020-05-20 00:04:44 -07:00
Andrey Lushnikov
e312845ba9
fix: less confusing error message ( #2305 )
...
Fixes #2283
2020-05-19 17:47:46 -07:00
Andrey Lushnikov
545c43d28d
fix: better hittarget testing for clicking ( #2217 )
...
While checking for hittarget, we first bubble from a target element
up to find the first element without `pointer-events: none` style.
This bubbling does not make much sense: we risk desperately clicking
"body" element, when we were actually asked to click some deeply-nested
"span".
Additionally, in many cases the original intent is to click a button. In this
case, we should use the enclosing "button" as a hit target directly.
Fixes #2175
2020-05-19 16:27:56 -07:00
Dmitry Gozman
b8410bd19e
test: unflake headful window features test ( #2302 )
2020-05-19 16:27:28 -07:00
Dmitry Gozman
de606b9553
fix(chromium): handle various exception values in pageerror ( #2293 )
2020-05-19 15:20:49 -07:00
Dmitry Gozman
7efc22c062
fix(chromium): websocket wrapper leaks child sessions ( #2291 )
...
When a parent session is detached, we do not always get Target.detachedFromTarget
for child sessions. This is especially true when the socket disconnects, leaving
all child sessions in the maps.
Flakily reproducible by browserType.connect multiclient tests.
2020-05-19 15:02:13 -07:00
Dmitry Gozman
481643409e
feat(debug): persist devtools preferences in Chromium ( #2266 )
...
We store devtools-preferences.json file in the downloaded browser directory.
2020-05-19 14:55:11 -07:00
Dmitry Gozman
fbccd328cc
test: disable firefox crash tests ( #2301 )
2020-05-19 14:54:13 -07:00
Yury Semikhatsky
a010fcd620
feat(webkit): bump revision to 1238 ( #2299 )
2020-05-19 10:37:01 -07:00
Dmitry Gozman
5d0b5625fa
browser(firefox): set initial page url to about:blank ( #2300 )
2020-05-19 10:30:36 -07:00
Dmitry Gozman
8957c86837
feat(debug): add source maps to evaluates in debug mode ( #2267 )
...
When PLAYWRIGHT_DEBUG_UI is set, we try to find the source
of the function in the current file and source map it.
2020-05-19 08:40:45 -07:00
Yury Semikhatsky
0bc4906196
browser(webkit): use unsigned long instead of size_t to fix Win ( #2295 )
2020-05-18 23:38:54 -07:00
Yury Semikhatsky
96f9bbee71
browser(webkit): fix windows build ( #2294 )
2020-05-18 22:30:47 -07:00
Dmitry Gozman
82cab094e8
feat(logging): add logging to websocket transport ( #2289 )
2020-05-18 19:00:38 -07:00
Yury Semikhatsky
5a6973fe69
browser(webkit): support jpeg screencast frames on WPE and Win ( #2290 )
2020-05-18 18:23:03 -07:00
Andrey Lushnikov
f24696be62
feat: add page convenience methods for textContent and getAttribute ( #2235 )
...
This patch adds:
- `page.innerText()` / `frame.innerText()`
- `page.innerHTML()` / `frame.innerHTML()`
- `page.textContent()` / `frame.textContent()`
- `page.getAttribute()` / `frame.getAttribute()`
Fixes #2143
2020-05-18 17:58:23 -07:00
Dmitry Gozman
359cb3a740
fix(oopif): adopt main requests into oopifs ( #2284 )
...
Main request for an OOPIF starts in the parent session, and the oopif
session is create only after the response has been received. Therefore,
we should adopt the request after oopif session is created.
2020-05-18 17:13:51 -07:00
Pavel Feldman
2bd427ad1d
feat(exposeBinding): a more powerful exposeFunction with source attribution ( #2263 )
2020-05-18 14:28:06 -07:00
Dmitry Gozman
40ea0dd23b
browser(firefox): make default viewport work in default context ( #2277 )
2020-05-18 09:47:40 -07:00
David Gilbertson
9e2733d520
docs(test-runners.md): add WebStorm comment ( #2279 )
2020-05-17 20:43:00 -07:00
David Gilbertson
125312f78b
docs(core-concepts.md): fix typo ( #2273 )
2020-05-17 08:58:33 -07:00
Yury Semikhatsky
74ba03b195
feat(webkit): bump revision to 1235 ( #2262 )
2020-05-15 17:36:40 -07:00
Dmitry Gozman
4bf5742d47
fix(chromium): abort fetch requests that lack networkId ( #2254 )
...
These requests are usually internal ones, and we can safely abort them.
An example would be DevTools loading cached resources to show the content.
There will never be a matching Network.requestWillBeSent event, so we do not
report them to the user.
2020-05-15 15:22:29 -07:00
Pavel Feldman
99b7aaace8
chore: refactor injected script harness ( #2259 )
2020-05-15 15:21:49 -07:00
Yury Semikhatsky
9c7e43a83b
browser(webkit): roll to 05/15/20 ( #2260 )
2020-05-15 13:47:23 -07:00
Arjun Attam
73a2612793
docs: fix webkit badge
2020-05-15 11:42:26 -07:00
Joel Einbinder
04aae1c063
chore(electron): mark version 0.3.0 ( #2255 )
2020-05-14 23:13:06 -07:00
Joel Einbinder
5a883a5877
browser(firefox): support internal drag and drop ( #2243 )
2020-05-14 18:30:02 -07:00
Andrey Lushnikov
a38ac3fb62
fix: report hash in page.url() ( #2252 )
...
Fixes #2247
2020-05-14 17:23:19 -07:00
Andrey Lushnikov
e035bf3b33
fix: update webkit version ( #2250 )
...
Fix #2245
2020-05-14 16:47:18 -07:00
Yury Semikhatsky
4d27aadb13
browser(webkit): fix compilation on Mac ( #2253 )
2020-05-14 16:45:39 -07:00
Yury Semikhatsky
8fb2c7e8fa
browser(webkit): fix compilation on Win ( #2251 )
2020-05-14 16:29:07 -07:00
Yury Semikhatsky
2073bcb867
browser(webkit): fix compilation on Mac ( #2249 )
2020-05-14 16:14:09 -07:00
Yury Semikhatsky
f743cd9763
browser(webkit): introduce screencast agent in web process ( #2248 )
2020-05-14 15:48:05 -07:00
Dmitry Gozman
63cc126805
fix(webkit): do not swallow init errors ( #2242 )
...
This is a speculative fix to the following issue from the bots:
NON-TEST ERROR #0 : UNHANDLED ERROR
TypeError: Cannot read property 'url' of undefined
at WKPage._onTargetCreated (/Users/runner/runners/2.169.1/work/playwright/playwright/src/webkit/wkPage.ts:274:12)
at process._tickCallback (internal/process/next_tick.js:68:7)
I assume that _initializeSession did swallow an error, so we erroneously
consider Page to be fully initialized (and having main frame).
2020-05-14 15:43:23 -07:00
Dmitry Gozman
e8e761f77f
chore: use internal BrowserOptions to unify browsers ( #2230 )
2020-05-14 13:22:33 -07:00
Dmitry Gozman
696b40a508
docs: update click.md
2020-05-14 10:44:20 -07:00
Pavel Feldman
919659a66b
browser(webkit): roll to r1230 ( #2241 )
2020-05-14 10:41:52 -07:00
Pavel Feldman
17286ab712
feat(webkit): roll to r1228 ( #2232 )
2020-05-14 07:57:29 -07:00
Pavel Feldman
62ae079035
browser(webkit): destroy main window after the view ( #2233 )
2020-05-13 22:54:43 -07:00
Dmitry Gozman
76e106605f
fix(screenshot): use innerW/H instead of offsetW/H to determine viewport size ( #2229 )
...
When capturing a screenshot with null viewport, we determine the screenshot size
based on body.offsetHeight. This is a very large number for long pages. We should
use window.innerHeight instead.
2020-05-13 20:53:11 -07:00
Joel Einbinder
dbef7de42a
feat(electron): types ( #2231 )
2020-05-13 20:51:53 -07:00
