Max Schmitt
fca1fa0b95
cherry-pick( #31973 ): chore: run client-certificate tests in service mode
2024-08-05 14:43:44 +02:00
Dmitry Gozman
ff11273c7b
cherry-pick( #32010 ): docs: release notes for 1.46 update
2024-08-05 13:36:33 +01:00
Yury Semikhatsky
4953ac3072
cherry-pick( #31975 ): chore: remove bright counter from sidebar tab se… ( #31976 )
...
…lector
Removing the following icon:
HTML `options` element cannot be styled, so just removing the counter in
sidebar mode:
<img width="348" alt="image"
src="https://github.com/user-attachments/assets/d636dca2-5007-41f7-866e-3a0f604d46fc ">
2024-08-02 10:32:48 -07:00
Yury Semikhatsky
4c66f8aeda
cherry-pick( #31970 ): fix(trace): do not place expect into unfinished … ( #31974 )
...
…api calls based on time
Fixes https://github.com/microsoft/playwright/issues/31959
2024-08-01 14:47:37 -07:00
Dmitry Gozman
deba37b6b5
cherry-pick( #31960 ): feat(ui mode): linkify attachment names and content ( #31971 )
...
- Pass `contentType` to the CodeMirror.
- Support `text/markdown` mode.
- Custom mode for non-supported types that linkifies urls.
2024-08-01 13:24:14 -07:00
Max Schmitt
2cfe733e30
cherry-pick( #31961 ): fix(trace-viewer): make 'hide route actions' work for .NET
2024-08-01 21:03:45 +02:00
Dmitry Gozman
5fdf97658e
cherry-pick( #31945 ): feat(ui-mode): add annotations tab ( #31968 )
...
<img width="867" alt="image"
src="https://github.com/user-attachments/assets/7d714723-1d3f-49b2-944a-0a476d79aee8 ">
2024-08-01 11:53:04 -07:00
Dmitry Gozman
29ba72c06b
cherry-pick( #31952 ): fix(ui mode): api review feedback ( #31964 )
...
- Hide "Testing Options" as not ready.
- Update SettingsView margins.
- Include `page.route` and similar methods into "Show route actions".
2024-08-01 11:23:07 -07:00
Simon Knott
b20e154902
cherry-pick( #31958 ): fix(ui): only populate settings once ( #31963 )
...
Cherry-picks https://github.com/microsoft/playwright/pull/31958 into the
release.
2024-08-01 09:28:40 -07:00
Max Schmitt
876e0e4ba9
cherry-pick( #31955 ): feat(chromium): roll to r1129
2024-08-01 14:33:35 +02:00
Dmitry Gozman
3ab19c6229
cherry-pick( #31928 ): fix(trace): make sure the correct attachment name is used for downloads
...
When two attachments have the same content sha1, we used the first one's
name for the downloaded file, no matter which one the user clicked to
download. Now we pass the name explicitly.
References #31912 .
2024-08-01 06:44:55 +01:00
Dmitry Gozman
8d35c1b517
cherry-pick( #31920 ): fix(trace viewer): attachment download
...
- Update attachments tab margins.
- Make sure to pass `&download` in attachment urls. This makes them
downloadable, regressed in #28727 .
- Do not additionally list image diffs as screenshots.
Fixes #31912 .
2024-08-01 06:44:22 +01:00
Yury Semikhatsky
71b8e22501
cherry-pick( #31939 ): chore(trace-viewer): copy only file name without… ( #31942 )
...
… line number
As discussed in the meeting, copy only file name which is shown in the
same line, do not include highlighted line number.
2024-07-31 17:59:39 -07:00
Yury Semikhatsky
71e5eade8c
cherry-pick( #31940 ): chore(trace-viewer): less bright status code icon ( #31944 )
...
<img width="182" alt="image"
src="https://github.com/user-attachments/assets/8b381bcc-46e3-45c7-8fd2-e020436d1bff ">
<img width="206" alt="image"
src="https://github.com/user-attachments/assets/4ea02b47-a4da-44f7-9c26-13b05374e89d ">
<img width="213" alt="image"
src="https://github.com/user-attachments/assets/38b50e2a-f69c-4a78-abb2-2680453fc5fd ">
2024-07-31 17:58:25 -07:00
Yury Semikhatsky
7ff46d4596
cherry-pick( #31938 ): chore(trace-viewer): do not shrink metadata view ( #31943 )
...
Avoids the following effect:
2024-07-31 17:58:02 -07:00
Yury Semikhatsky
ca9ddff7ca
cherry-pick( #31934 ): chore: make sure error stack includes message as… ( #31935 )
...
… before #31691
This brings stack formatting to how it was prior to
1686e5174d
2024-07-31 11:07:45 -07:00
Max Schmitt
dfecfa5be1
cherry-pick( #31914 ): chore: various roll fixes for .NET
2024-07-30 19:10:50 +02:00
Dmitry Gozman
468b9b1e7a
cherry-pick( #31894 ): feat(ui mode): ui updates ( #31916 )
...
- Update copy to clipboard button.
- Reveal test source in the Source tab instead of external editor.
- New button to reveal in the external editor in the Source tab.
- Move the Pick Locator button next to snapshot tabs.
2024-07-30 09:23:19 -07:00
Max Schmitt
64e4a9b0eb
cherry-pick( #31913 ): fix(client-certificates): use matching origin for connections on :443
...
Motivation: When using client-certificates on a website on port `443`,
we would normalise the user input with `new URL` but still generate a
"bad" representation of the "origin" internally, since the just do
concatenated "host:port".
(The origin doesn't contain the port in case of :443)
We use `clientCertificatesToTLSOptions` in two places:
a) for APIRequestContext, there we pass one from the URL constructor
over and
b) from the socks proxy, there we **now** also pass a "good one" over.
Test plan: We don't want to run the tests on port :443, so only manually
validated the fix.
Relates https://github.com/microsoft/playwright/issues/31906
2024-07-30 12:31:50 +02:00
Max Schmitt
446de523c4
cherry-pick( #31898 ): fix(client-certificates): don't use proxy when using BrowserContext.request
2024-07-29 16:45:34 +02:00
Max Schmitt
2ea14ca2c4
cherry-pick( #31893 ): chore: add maxRetries to APIRequestContext.delete
2024-07-29 14:53:27 +02:00
Max Schmitt
185a2867c6
cherry-pick( #31897 ): fix(client-certificates): error response body Content-Length calculation
2024-07-29 14:53:12 +02:00
Max Schmitt
57c7d9e9bb
docs: add release notes for 1.46 ( #31875 )
...
Signed-off-by: Max Schmitt <max@schmitt.mx>
Signed-off-by: Dmitry Gozman <dgozman@gmail.com>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
2024-07-26 08:34:26 -07:00
Dmitry Gozman
9227d1c598
docs: explain a bit more about fixture boxing and custom titles ( #31877 )
2024-07-26 07:43:58 -07:00
Max Schmitt
6988194c97
test: unflake contextmenu recorder test ( #31749 )
2024-07-26 12:43:05 +02:00
Max Schmitt
b214941a01
chore: make it more clear that --only-changed is per file ( #31874 )
2024-07-26 12:41:33 +02:00
Max Schmitt
47e4e45bc2
chore: update WebKit version to 18.0 ( #31873 )
2024-07-26 11:32:51 +02:00
Max Schmitt
09581b615d
fix(client-certificates): return target errors on response when using http2 ( #31867 )
2024-07-26 11:28:45 +02:00
Max Schmitt
335d31bf65
devops: remove GHA todo in primary workflow for itest ( #31871 )
...
This TODO got added during our GHA refactoring a while ago, where I
thought it might make sense to run our itests in `bash`. We didn't do it
before the refactoring either. It seems good to keep them running in
`pwsh` instead, so lets just remove the TODO.
Investigation notes: Running in `bash` on Windows via `Git Bash` seems
like doing a lot of magic, especially with path handling. Things
[like](a02ed38e60/tests/installation/registry.ts (L143)https://sourceforge.net/p/mingw/mailman/mingw-users/thread/54CE104A.7060108@hccnet.nl/ ).
Signed-off-by: Max Schmitt <max@schmitt.mx>
2024-07-26 11:04:51 +02:00
Max Schmitt
81b3c0c402
fix(client-certificates): include socks-certs in npm package ( #31872 )
2024-07-26 11:04:38 +02:00
Max Schmitt
a02ed38e60
chore: reduce file reads in client-certificates internal TLS server ( #31865 )
2024-07-25 22:36:25 +02:00
Dmitry Gozman
a41cebc1c9
feat(ui mode): introduce Testing Options and Settings ( #31841 )
...
Testing Options control tests, while Settings are UI mode settings.
<img width="298" alt="Screenshot 2024-07-25 at 10 54 22 AM"
src="https://github.com/user-attachments/assets/7b6f5fff-687b-48d1-80b3-d1e6f2a257e8 ">
These sections are separately expandable, collapsed by default.
<img width="294" alt="Screenshot 2024-07-24 at 2 06 25 PM"
src="https://github.com/user-attachments/assets/5d35ac8c-9289-46ca-aaa2-ebc5419fa0c4 ">
References #31520 .
---------
Signed-off-by: Simon Knott <info@simonknott.de>
Co-authored-by: Simon Knott <info@simonknott.de>
2024-07-25 11:23:43 -07:00
Max Schmitt
a966abfd31
test: unflake happy-eyeballs tests ( #31861 )
2024-07-25 20:22:51 +02:00
Dmitry Gozman
d8d5289e86
fix(remote): make sure api calls reject before browser is closed ( #31858 )
...
Upon calling `browser.close()` or dropping remote connection, make sure
to reject api calls before resolving `browser.close()` and firing a
`disconnected` event.
This change aligns the order guarantee with non-remote case.
2024-07-25 09:57:34 -07:00
Max Schmitt
0c6ecf8df4
chore: use happy eyeballs for client-certificates ( #31859 )
2024-07-25 18:55:47 +02:00
Playwright Service
d3e2c6cbb2
feat(chromium-tip-of-tree): roll to r1244 ( #31856 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-07-25 18:54:24 +02:00
Max Schmitt
90af289ba2
test: use managed http2 server for client-certificates ( #31844 )
2024-07-25 18:53:38 +02:00
Simon Knott
b06a95dd75
feat(trace viewer): show baseURL in Metadata pane ( #31852 )
...
Resolves https://github.com/microsoft/playwright/issues/31847 by adding
playwright config's `baseURL` value to the `context-options` trace
event, and showing that in the Trace Viewer.
Because the added property is optional, I didn't increment the trace
format version.
I've also considered pulling the `baseURL` from the existing
`browser.newContext` step to get around modifying the trace format, but
that felt pretty hacky.
https://github.com/user-attachments/assets/ecaef747-727d-4937-9ca3-1605ca9907b9
---------
Signed-off-by: Simon Knott <info@simonknott.de>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
2024-07-25 17:14:46 +02:00
Simon Knott
4d4ed2a5c4
chore: enforce single quotes in JSX ( #31855 )
...
Discovered in
https://github.com/microsoft/playwright/pull/31852#discussion_r1691133106 :
We're not enforcing single quotes for JSX, and it shows! We need to
start enforcing it to prevent even greater damage from being done ;D
2024-07-25 13:06:26 +02:00
Playwright Service
3ce948e972
chore(driver): roll driver to recent Node.js LTS version ( #31854 )
2024-07-25 12:52:50 +02:00
Simon Knott
a1a4216b88
chore(ui): add test expectation that doesn't immediately pass on blank tree ( #31850 )
...
Followup to #31815
2024-07-25 12:21:24 +02:00
Playwright Service
bdbe4795f1
feat(chromium): roll to r1128 ( #31848 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-07-25 09:42:53 +02:00
Max Schmitt
7570c25b3d
chore: remove glob from client-certificate matching ( #31846 )
...
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
2024-07-24 19:13:03 +02:00
Max Schmitt
ca149be154
test: skip SharedArrayBuffer on macOS 12 ( #31845 )
2024-07-24 18:45:03 +02:00
Elio Struyf
1e94abb683
docs: added MS Teams and mail reporter ( #31579 )
2024-07-24 11:55:45 +02:00
Max Schmitt
c5b7ce86dc
feat(client-certificates): add http2 support ( #31786 )
2024-07-24 11:39:39 +02:00
Pavel Feldman
c74843a914
chore(fetch): pass flush and finishFlush options to brotli ( #31833 )
...
Fixes https://github.com/microsoft/playwright/issues/31814
2024-07-23 18:28:34 -07:00
Yury Semikhatsky
13b5510d57
docs(webkit): supprot for non-core features may differ between OSes ( #31831 )
...
Fixes: https://github.com/microsoft/playwright/issues/31017
2024-07-23 17:35:02 -07:00
Pavel Feldman
7735affef4
fix(ui): print the web server output in the ui mode ( #31824 )
...
Fixes https://github.com/microsoft/playwright/issues/31300
2024-07-23 16:52:32 -07:00
Yury Semikhatsky
1918ae5c4a
fix(webkit): reenable CrossOriginOpenerPolicy ( #31765 )
...
Depends on https://github.com/microsoft/playwright-browsers/pull/1160
Fixes: https://github.com/microsoft/playwright/issues/14043
2024-07-23 15:02:47 -07:00
