Tetsuo Kiso
4cdb89c6ec
Fix warning: array subscript is of type 'char' (-Wchar-subscripts).
...
According to gcc's documentation:
This is a common cause of error, as programmers often forget that
this type is signed on some machines.
2012-05-08 01:50:07 +09:00
Tetsuo Kiso
e2f01d7451
No copying allowed.
...
Check the return values of calloc().
2012-05-08 01:13:31 +09:00
Tetsuo Kiso
9cd8e0ce5f
Fix memory leak: free allocated memories that were not freed.
2012-05-08 01:01:09 +09:00
Tetsuo Kiso
355f871457
Add const to member functions.
...
Replace define macros with enum.
2012-05-08 00:58:44 +09:00
Tetsuo Kiso
31c4bf3371
Clean up headers.
2012-05-08 00:03:56 +09:00
Tetsuo Kiso
caa249d0f4
Clean up including headers; delete using namespace std in headers.
2012-05-07 23:41:18 +09:00
Tetsuo Kiso
dce212582f
Fix passing arguments by const reference; add error checking.
...
Please check the return values of fopen(), calloc(), and malloc().
2012-05-07 23:26:32 +09:00
Tetsuo Kiso
0ea2bc6fac
Use const instead of #define macros if possible.
2012-05-07 23:08:37 +09:00
Tetsuo Kiso
245be8f63d
Move/add #pragma once properly.
2012-05-07 22:59:37 +09:00
Tetsuo Kiso
85c91b87da
Fix "-Wreorder".
2012-05-07 21:45:30 +09:00
Kenneth Heafield
28b1fbcf5d
Only add -static to clang on linux
2012-05-06 20:13:19 -04:00
Phil Williams
9e626369f7
Merge pull request #13 from tetsuok/fix-warnings
...
Fix warnings: -Wreorder and -Wmismatched-tags.
2012-05-06 07:47:34 -07:00
Kenneth Heafield
f4faece269
Merge branch 'master' of github.com:moses-smt/mosesdecoder
2012-05-05 17:19:26 -04:00
Kenneth Heafield
044a602604
Stricter dependencies enforced by clang
2012-05-05 17:17:28 -04:00
Tetsuo Kiso
99c354e573
Base class destructors should be virtual.
...
See e.g., http://www.gotw.ca/publications/mill18.htm for details.
2012-05-06 06:11:25 +09:00
Tetsuo Kiso
df4586740d
Fix using directive refers to implicitly-defined namespace 'std'.
2012-05-06 05:27:04 +09:00
Tetsuo Kiso
4b5fe180ed
Fix using namespace "std" before including headers in *.h.
2012-05-06 01:31:04 +09:00
Tetsuo Kiso
89f23cfc08
Fix a warning of -Woverloaded-virtfual.
...
A function declaration hided virtual functions from a base class.
2012-05-06 01:04:41 +09:00
Tetsuo Kiso
1e5818d19c
Fix warnings: -Wreorder and -Wmismatched-tags.
2012-05-05 18:51:12 +09:00
Kenneth Heafield
c61390fb4e
KenLM b1daeaf for clang
2012-05-05 00:55:46 -04:00
Tetsuo Kiso
0c552e5be1
Fix compilation errors on clang.
...
Clang does not like default args allowed in template function
definitions. See e.g.,
http://www.mail-archive.com/llvmbugs@cs.uiuc.edu/msg08284.html
2012-05-05 11:49:42 +09:00
Kenneth Heafield
2e7e28092c
Apparently bjam doesn't pass -static to clang
2012-05-04 19:06:03 -04:00
Kenneth Heafield
70eff39eca
FactorFriend is a struct not a class. For clang.
2012-05-04 11:21:25 -04:00
Hieu Hoang
2bcaa00dbd
more comment for irst training wrapper
2012-05-04 11:09:12 +01:00
Oliver Wilson
8c551f56f0
Merge branch 'master' of github.com:moses-smt/mosesdecoder
2012-05-04 11:08:01 +01:00
Oliver Wilson
4c399be226
Update Jamfile for renamed RandLM libraries.
2012-05-04 11:07:09 +01:00
Tetsuo Kiso
e3022bbb2f
Replace string concatenations with File::Spec->catfile().
2012-05-04 15:44:20 +09:00
Tetsuo Kiso
b5be35fda4
Add whitespaces to mert-moses.pl.
2012-05-04 15:40:50 +09:00
Tetsuo Kiso
c55d14332b
Add error handling for Mac OS X users who have not installed MegaM.
...
OS X users (including Windows users) who want to run PRO for tuning
normally need to get the MegaM's source code and compile by hand
since Hal Daume III has released the precompiled binaries only for Linux.
2012-05-04 04:04:54 +09:00
Matous Machacek
141dd85c59
Merge pull request #12 from moses-smt/prefix-private-cderscorer-member
...
Prefix a private member of mert/CderScorer with "m_".
2012-05-03 09:36:06 -07:00
Tetsuo Kiso
63730d6d07
Fix comment.
2012-05-03 08:33:28 +09:00
Tetsuo Kiso
62a754dfbc
Add a global variable to store MegaM's default options for PRO.
2012-05-03 08:29:39 +09:00
Tetsuo Kiso
0550eacc89
Slightly improve mert-moses.pl portability; add checking mertdir.
2012-05-03 08:09:20 +09:00
Tetsuo Kiso
9e772a6690
Use warn() instead of print STDERR for debugging and bug reports.
...
Because warn() tells the file/line number as die() does.
2012-05-03 07:22:08 +09:00
Tetsuo Kiso
5a78d67c84
Fix handling default case.
2012-05-03 07:11:24 +09:00
Tetsuo Kiso
d1906fd066
Create subroutines for set up reference length types and case information.
2012-05-03 06:59:34 +09:00
Tetsuo Kiso
fc2f4d4ba1
Prefix a private member of mert/CderScorer with "m_".
2012-05-03 05:38:35 +09:00
Matous Machacek
370bf4e697
CderScorer compute both CDER and WER metric
2012-05-02 22:03:58 +02:00
phikoehn
f487eaa644
Merge branch 'master' of git://github.com/moses-smt/mosesdecoder
2012-05-02 03:48:13 +01:00
phikoehn
c145809b7f
check if feature info file is not empty before reuse
2012-05-02 03:47:48 +01:00
Tetsuo Kiso
9164745a00
Create a function not to repeat same things.
...
Add a global variable for "finished_step.txt" to avoid typos.
2012-05-02 05:25:00 +09:00
Tetsuo Kiso
6d4d88de13
Fix typo.
2012-05-02 05:10:12 +09:00
Tetsuo Kiso
7741eca48e
Use 3-argument open() to be safe; add close() to the missing regions.
...
Of course, you can use two-argument forms. Add more error checking
when calling open().
2012-05-02 05:07:14 +09:00
Tetsuo Kiso
0079d30097
Replace pwd
with Cwd::getcwd() to ensure portability.
2012-05-02 04:21:35 +09:00
Tetsuo Kiso
72982de9f6
Fix the indentation of some lines of mert-moses.pl.
2012-05-02 04:03:44 +09:00
Tetsuo Kiso
278cb087a6
Merge branch 'master' of github.com:moses-smt/mosesdecoder
2012-05-02 03:47:01 +09:00
Tetsuo Kiso
88a33ddad2
Delete trailing whitespace of mert-moses.pl.
2012-05-02 03:46:36 +09:00
Tetsuo Kiso
e43faccc48
Fix annoying warnings on mert-moses.pl.
2012-05-02 03:40:44 +09:00
Tetsuo Kiso
66992ed497
Add TODO to mert/Reference.h.
2012-04-26 05:44:05 +09:00
Phil Williams
38774b6cab
extract-rules: don't do scope pruning by default for
...
hierarchical rule extraction.
2012-04-23 22:47:18 +01:00