osm-search/Nominatim
1
1
Fork 0
mirror of https://github.com/osm-search/Nominatim.git synced 2024-11-27 10:43:02 +03:00
Code Issues Packages Projects Releases Wiki Activity
4,220 Commits 28 Branches 41 Tags 164 MiB
c7db69a30c
Commit Graph

4220 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sarah Hoffmann
36d068871d disable prepared statements 
Prepared statements do not work well with the partial indexes that
Nominatim uses because all Python constants are replaced with
parameters. A query like:

  placex.select().where(placex.c.rank_address.between(4, 25)

gets translated into a prepared query with two parameters:

  SELECT * FROM placex WHERE rank_address BETWEEN %s and %s

And this does not work with a partial index of:

  CREATE INDEX on placex(geometry) WHERE rank_address between 4 and 25
 2023-03-28 14:53:45 +02:00
Sarah Hoffmann
6c67a4b500 switch reverse CLI command to Python implementation 2023-03-26 18:09:33 +02:00
Sarah Hoffmann
86b43dc605 make sure PHP and Python reverse code does the same 
The only allowable difference is precision of coordinates. Python uses
a precision of 7 digits where possible, which corresponds to the
precision of OSM data.

Also fixes some smaller bugs found by the BDD tests.
 2023-03-26 16:21:43 +02:00
Sarah Hoffmann
300921a93e add server glue for reverse API call 2023-03-25 17:04:02 +01:00
Sarah Hoffmann
35b52c4656 add output formatters for ReverseResults 
These formatters are written in a way that they can be reused for
search results later.
 2023-03-25 15:45:03 +01:00
Sarah Hoffmann
878302a622 ignore NotImplementedErrors when compiling SQL 2023-03-24 11:16:02 +01:00
Sarah Hoffmann
55277738d4 factor out layer checks in reverse function 2023-03-24 10:08:01 +01:00
Sarah Hoffmann
2f54732500 python: implement reverse lookup function 
The implementation follows for most part the PHP code but introduces an
additional layer parameter with which the kind of places to be returned
can be restricted. This replaces the hard-coded exclusion lists.
 2023-03-23 22:38:37 +01:00
Sarah Hoffmann
41da298b18 add python implementation of reverse 
This adds an additional layer parameter and slightly changes the
queries to do more efficient lookups for large area features.
 2023-03-23 10:16:50 +01:00
Sarah Hoffmann
ebcf8c2b6b api: make details parameter optional 2023-03-23 10:16:50 +01:00
Sarah Hoffmann
1facfd019b api: generalize error handling 
Return a consistent error response which takes into account the chosen
content type. Also adds tests for V1 server glue.
 2023-03-23 10:16:50 +01:00
Sarah Hoffmann
00e3a752c9 split SearchResult type 
Use adapted types for the different result types. This makes it
easier to have adapted output formatting and means there are only
result fields that are filled.
 2023-03-23 10:16:50 +01:00
Sarah Hoffmann
d03fd3f883
Merge pull request #3013 from mtmail/changelog-4-2-x 
update ChangeLog to verison 4.2.2
 2023-03-23 09:20:25 +01:00
marc tobias
fa3d13ac7e update ChangeLog to verison 4.2.2 2023-03-22 23:45:59 +01:00
Sarah Hoffmann
434bd5a5bb
Merge pull request #3011 from lonvia/fix-flex-scripts 
Fix extra tag handling in some flex scripts
 2023-03-21 09:58:53 +01:00
Sarah Hoffmann
9aca389bda
Merge pull request #3010 from lonvia/adapt-zoom-for-reverse 
Minor adjustments to reverse zoom translation
 2023-03-21 08:56:25 +01:00
Sarah Hoffmann
69ce42b22c remove more tags from full style 
The full style should only save the necessary tags needed for
processing.
 2023-03-20 21:42:24 +01:00
Sarah Hoffmann
114cc776be fix handling of unused extra tags 
The tags can only be moved to extra tags after the main tags have been
handled.
 2023-03-20 21:20:27 +01:00
Sarah Hoffmann
5e5cff897f minor adjustment to reverse zoom translation 
Add a 'village' zoom level at 13 between town and neighbourhood
and a all locality-like objects for zoom 15. These zoom levels had
the same behaviour as the lower level so far. However, the distinction
for village and locality may be useful at times.
 2023-03-20 20:47:42 +01:00
Sarah Hoffmann
a8bedb6ab9
Merge pull request #3003 from lonvia/rework-bdd-api-tests 
Reorganize code around BDD API tests and extend reverse API tests
 2023-03-10 10:01:24 +01:00
Sarah Hoffmann
81430bd3bd bdd: be more fuzzy with coordinate comparisons 2023-03-09 22:37:45 +01:00
Sarah Hoffmann
93203f355a avoid recent Python dialect 2023-03-09 20:57:43 +01:00
Sarah Hoffmann
b730d286ad fix polygon simplification in reverse results 
polygon_threshold has never really worked for reverse.
 2023-03-09 20:24:07 +01:00
Sarah Hoffmann
3f2296e3ea bdd: extend reverse API tests for format checks 
Reorganise the API reverse tests and extend the checks for the
output format, testing for all expected fields.
 2023-03-09 20:20:50 +01:00
Sarah Hoffmann
2b7eb4906a bdd: add tests for valid debug output 2023-03-09 20:10:51 +01:00
Sarah Hoffmann
db1aa4d02e bdd: replace old formatting strings 2023-03-09 19:49:55 +01:00
Sarah Hoffmann
ad88d7a3e0 bdd: more format checks for reverse XML 2023-03-09 19:40:24 +01:00
Sarah Hoffmann
e42c1c9c7a bdd: new step variant 'result contains in field' 
This replaces the + notation for recursing into result dictionaries.
 2023-03-09 19:31:21 +01:00
Sarah Hoffmann
556bb2386d bdd: factor out computation of result to-check lists 2023-03-09 18:01:45 +01:00
Sarah Hoffmann
1e58cef174 bdd: replace property_list construct with standard check functions 2023-03-09 17:56:28 +01:00
Sarah Hoffmann
01010e443f bdd: remove special case for osm_type field 
The fuzzy field check hide cover formatting errors. Use 'osm' when
only caring about the conent.
 2023-03-09 17:44:34 +01:00
Sarah Hoffmann
da0a7a765e bdd: reorganise field comparisons 
Move comparision on Field values from assert_field() into a
comparator class. Replace BadRowValueAssert with a simpler
check_row() function.
 2023-03-09 17:05:05 +01:00
Sarah Hoffmann
9769a0dcdb bdd: use new check_for_attributes() function also in steps 2023-03-09 16:44:07 +01:00
Sarah Hoffmann
fbff4fa218 bdd: fully check correctness of geojson and geocodejson 
Parse code now checks presence of all required fields and exports
all fields for inspection.
 2023-03-09 16:36:46 +01:00
Sarah Hoffmann
d17ec56e54 bdd: remove OrderedDict 
dicts are guaranteed to keep insertion order by since Python 3.7, making
use of ORderedDict mute.
 2023-03-09 16:08:39 +01:00
Sarah Hoffmann
9a5f75dba7
Merge pull request #2993 from biswajit-k/delete-tags 
Adds sanitizer for preventing certain tags to enter search index based on parameters
 2023-03-09 14:31:45 +01:00
biswajit-k
ca149fb796 Adds sanitizer for preventing certain tags to enter search index based on parameters 
fix: pylint error

added docs for delete tags sanitizer

fixed typos in docs and code comments

fix: python typechecking error

fixed rank address type

Revert "fixed typos in docs and code comments"

This reverts commit 6839eea755a87f557895f30524fb5c03dd983d60.

added default parameters and refactored code

added test for all parameters
 2023-03-09 14:18:39 +05:30
Sarah Hoffmann
08f19e074b
Merge pull request #2999 from biswajit-k/fix-typos 
fixed typos in docs and code comments
 2023-03-08 08:55:27 +01:00
biswajit-k
36388cafe9 fixed typos in docs and code comments 2023-03-06 17:09:38 +05:30
Sarah Hoffmann
8191c747b9 add latest security incident 
Also removes 3.6 which is no longer supported.
 2023-02-22 11:24:04 +01:00
Sarah Hoffmann
d078763fa1 harmonize flags for PHP's htmlspecialchars 2023-02-20 16:46:53 +01:00
Sarah Hoffmann
412ead5f2d adapt PHP tests for debug output 2023-02-20 16:23:28 +01:00
Sarah Hoffmann
513175ce23 properly encode special HTML characters in debug mode 2023-02-20 15:43:03 +01:00
Sarah Hoffmann
8db6dd995a
Merge pull request #2986 from mtmail/add-more-languages-from-osm-wiki 
sp_wiki_loader: add more default languages
 2023-02-20 11:12:08 +01:00
marc tobias
4be6970bd4 sp_wiki_loader: add more default languages 2023-02-18 13:54:48 +01:00
Sarah Hoffmann
fa681ce246 add timestamp to debug SQL output 2023-02-18 09:49:30 +01:00
Sarah Hoffmann
dd5cd97713 add warning for reverse index migration 2023-02-18 09:43:37 +01:00
Sarah Hoffmann
89d47d26f0
Merge pull request #2985 from lonvia/fix-place-rank-inheritance 
Restrict place rank inheritance to address items
 2023-02-18 09:35:19 +01:00
Sarah Hoffmann
d574ceb598 restrict place rank inheritance to address items 
Place tags must have no influence on street- or POI-level
objects.
 2023-02-17 16:25:26 +01:00
Sarah Hoffmann
92e2f5ca8e
Merge pull request #2983 from lonvia/improve-reverse-place-node-lookup 
Improve reverse place node lookup
 2023-02-17 15:51:55 +01:00