primer/css
1
1
Fork 0
mirror of https://github.com/primer/css.git synced 2024-12-25 23:23:47 +03:00
Code Issues Projects Releases Wiki Activity

Move some form styles to base.scss (#2327)

Browse Source 
* Move fieldset + label styles to base.scss

* Create giant-boxes-vanish.md

* Move ::placeholder
This commit is contained in:
simurai 2022-12-02 10:59:15 +09:00 committed by GitHub
parent f0e6eabee7
commit 8cf13e984c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 21 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/giant-boxes-vanish.md Normal file
View File

@ -0,0 +1,5 @@
---
"@primer/css": patch
---
Move `fieldset` + `label` styles to `base.scss`

16
src/base/base.scss
View File

@ -34,6 +34,22 @@ strong {
font-weight: $font-weight-bold;
}
fieldset {
padding: 0;
margin: 0;
border: 0;
}
label {
font-weight: $font-weight-bold;
}
// Custom styling for HTML5 validation bubbles (WebKit only)
::placeholder {
color: var(--color-fg-subtle);
opacity: 1; // override opacity in normalize.css
}
// Horizontal lines
//
// TODO-MDO: Remove `.rule` from everywhere and replace with `<hr>`s

16
src/forms/form-control.scss
View File

@ -5,16 +5,6 @@
//
// Overrides for common inputs for easier styling.
fieldset {
padding: 0;
margin: 0;
border: 0;
}
label {
font-weight: $font-weight-bold;
}
.form-control,
.form-select {
// stylelint-disable-next-line primer/spacing
@ -96,12 +86,6 @@ textarea.form-control {
}
}
// Custom styling for HTML5 validation bubbles (WebKit only)
::placeholder {
color: var(--color-fg-subtle);
opacity: 1; // override opacity in normalize.css
}
// Mini inputs, to match .minibutton
.input-sm {
min-height: $size-4;