Commit Graph

2120 Commits

Author SHA1 Message Date
Corey Johnson & Nathan Sobo
13553f79bc Benchmark movement of cursor that scrolls the editor's scroll view 2012-05-14 15:44:23 -06:00
Corey Johnson & Nathan Sobo
550bd0a979 Run more trials in benchmark that opens a 9k line file 2012-05-14 15:43:53 -06:00
Corey Johnson & Nathan Sobo
e8838b95fc Don't load user configuration for benchmark, since it changes the performance curve 2012-05-14 15:43:26 -06:00
Corey Johnson & Nathan Sobo
513e15e369 Make editor tall so that all line numbers are rendered for this test 2012-05-14 15:42:51 -06:00
Corey Johnson & Nathan Sobo
d99a12b6cf Don't defer scroll after cursor changes position to make scrolling feel smoother 2012-05-14 15:42:31 -06:00
Corey Johnson
b35a2502c6 Gutter line numbers are rendered similarly to the scroll view's lines 2012-05-14 12:32:53 -07:00
Corey Johnson
5e4aef95d0 Only visible lines numbers are rendered by the gutter 2012-05-14 09:53:58 -07:00
Corey Johnson
95440cc9dc bufferRowsForScreenRows method on editor and renderer take start/end arguments 2012-05-14 09:53:58 -07:00
Corey Johnson
63e9af6109 LineMap.bufferRowsForScreenRows stops traversing line map when endScreenRow is exceeded 2012-05-14 09:53:58 -07:00
Nathan Sobo
73c51583e6 Add benchmark for inserting newline in big file 2012-05-11 18:44:15 -06:00
Nathan Sobo
f47abdead9 Merge branch 'render-visible' 2012-05-11 17:52:23 -06:00
Nathan Sobo
21438acc48 Merge branch 'render-visible' of github.com:github/atom into render-visible 2012-05-11 17:51:59 -06:00
Nathan Sobo
0c89db37a5 Editor scroll position is correctly restored on refresh.
When we attach the editor we need to scroll it to the correct position before rendering lines. But to scroll it to the right position, the lines container and the scrollbar need to be assigned a height that allows them to scroll. So now we call `prepareForVerticalScrolling` on attach, then set the scroll position based on the edit session and render the visible lines.
2012-05-11 17:51:47 -06:00
Corey Johnson & Nathan Sobo
af65bd785c fix test failures 2012-05-11 16:06:42 -07:00
Corey Johnson & Nathan Sobo
d51b229d56 When the editor buffer changes and the path is not visible in the TreeView, It selects the closes ancestor entry of that file. 2012-05-11 15:44:18 -07:00
Corey Johnson & Nathan Sobo
2f86a3a6e5 TreeView starts with root being selected 2012-05-11 14:31:48 -07:00
Corey Johnson & Nathan Sobo
9990fd7b98 Do not let xcode compile coffeescript in when PROJECT_DIR exists 2012-05-11 13:12:43 -07:00
Nathan Sobo
96d92be230 Rename Editor.scrollbar to verticalScrollbar for clarity 2012-05-11 13:45:57 -06:00
Nathan Sobo
b64e9ae10f Rename Editor.scroller to Editor.scrollView to distinguish it from the vertical scrollbar.
Also, base edit session scroll top on the scrollbar instead of the scrollView.
2012-05-11 13:42:57 -06:00
Corey Johnson & Nathan Sobo
38582a22d3 These tests shall pass 2012-05-11 11:25:27 -07:00
Corey Johnson & Nathan Sobo
c93c63d721 Editor.scroller WheelEvents are forwarded to Editor.scrollbar 2012-05-11 11:04:04 -07:00
Corey Johnson & Nathan Sobo
9427c82084 WIP: Getting specs passing with new stand-in vertical scrollbar 2012-05-11 11:52:03 -06:00
Corey Johnson & Nathan Sobo
e433e08c78 Revert "WIP: Don't actually scroll the lines… just play with their margin to make them look like they scroll"
This reverts commit b3206a5a8b.
2012-05-10 18:05:25 -06:00
Corey Johnson & Nathan Sobo
1a6ef9d7e2 Revert "Temporarily disable gutter. Add transition affect to margin-top."
This reverts commit 811e5264cf.
2012-05-10 18:00:58 -06:00
Corey Johnson & Nathan Sobo
811e5264cf Temporarily disable gutter. Add transition affect to margin-top. 2012-05-10 17:52:41 -06:00
Corey Johnson & Nathan Sobo
b3206a5a8b WIP: Don't actually scroll the lines… just play with their margin to make them look like they scroll 2012-05-10 17:30:06 -06:00
Corey Johnson & Nathan Sobo
f0d4999fa4 Nix console.log on scroll. 2012-05-10 17:13:00 -06:00
Corey Johnson & Nathan Sobo
502b463a72 WIP: Adding an artificial scrollbar so we can render content before we scroll. It's blue. 2012-05-10 16:59:46 -06:00
Corey Johnson & Nathan Sobo
02da32d372 Update visible lines when scrolling up 2012-05-10 16:11:05 -06:00
Corey Johnson & Nathan Sobo
43ac7edf0f Scrolling to bottom renders correct lines
When we scroll more than a single screen's worth of lines, the new first visible screen row ends up exceeding the previous last rendered screen row, so we need to use the maximum of the two when deciding which new rows to render.
2012-05-10 15:15:34 -06:00
Corey Johnson & Nathan Sobo
c5d2616155 WIP: Removing lines that are no longer visible 2012-05-10 12:08:58 -07:00
Corey Johnson & Nathan Sobo
3f8654c76d Benchmark moving to eof 2012-05-10 11:31:35 -07:00
Corey Johnson & Nathan Sobo
22548141d7 Editor updates lines when it is resized 2012-05-10 11:14:03 -07:00
Corey Johnson & Nathan Sobo
f6e9d99865 Editor only does not pre-build lines, it only builds them when they are visible on the screen 2012-05-10 10:40:16 -07:00
Corey Johnson & Nathan Sobo
d76cc521bd When no words are found, autocomplete does not raise an exception 2012-05-10 10:39:09 -07:00
Corey Johnson & Nathan Sobo
6eda0d345b 💄 2012-05-10 08:58:38 -07:00
Nathan Sobo
1e2d333a15 WIP: working on only rendering on-screen lines. still half-baked. 2012-05-10 09:27:04 -06:00
Corey Johnson & Nathan Sobo
5ae40a3cb8 Editor only renders lines when it is attached to the DOM 2012-05-09 19:19:54 -06:00
Nathan Sobo
b369c09fa0 Benchmark method takes an optional repeat count after the description. Refactor benchmark helper. 2012-05-09 18:11:31 -06:00
Corey Johnson & Nathan Sobo
13f89f5d96 Benchmark opening large file 2012-05-09 16:22:07 -07:00
Corey Johnson & Nathan Sobo
3fcc9b9a0c optimization: Use hash instead of _.unique when building autocomplete word list 2012-05-09 16:12:49 -07:00
Corey Johnson & Nathan Sobo
cfd8d5bf8e Add benchmarkOnce 2012-05-09 16:11:35 -07:00
Corey Johnson & Nathan Sobo
8f77211f04 Cursor.getBeginningOfCurrentWordBufferPosition only uses the previous 2 lines for its scan range.
previous: editor.9000-line-file.at-end.move-to-beginning-of-word: 4695 / 100 = 46.95ms
new:      editor.9000-line-file.at-end.move-to-beginning-of-word: 1618 / 100 = 16.18ms
2012-05-09 12:24:27 -07:00
Corey Johnson & Nathan Sobo
faa0ec2199 log benchmark reports 2012-05-09 12:24:27 -07:00
Corey Johnson & Nathan Sobo
d3127a2686 slowed cursor blink down 2012-05-09 12:24:27 -07:00
Nathan Sobo
5b7ea95a11 Meta+ and meta- change the editor font size 2012-05-09 10:57:25 -06:00
Nathan Sobo
f2f44b9ab6 Can match key patterns with the '-' character
Add a parser to parse keystroke patterns instead of splitting on '-' with a regex
2012-05-09 10:56:31 -06:00
Nathan Sobo
8b1ac28b89 Editor font sizes can be adjusted with RootView.proto.setFontSize 2012-05-09 08:34:08 -06:00
Nathan Sobo
71d80470ca Remove console.log 2012-05-09 08:33:34 -06:00
Nathan Sobo
6dda27e771 Go ahead and build a RootView in the editor spec 2012-05-08 20:20:56 -06:00