Nathan Sobo
32a1854b7c
Use TextEditorPresenter::state.content.indentGuidesVisible
2015-02-03 15:05:16 -07:00
Nathan Sobo
590391a0ce
Update .content.indentGuidesVisible when editor’s grammar changes
2015-02-03 15:05:15 -07:00
Nathan Sobo
d0b52538b2
Add content.indentGuidesVisible to TextEditorPresenter::state
2015-02-03 15:05:15 -07:00
Nathan Sobo
22942ae1bd
Remove unused local vars
2015-02-03 15:05:15 -07:00
Nathan Sobo
0a9f7586ae
Add top-level .content object to presenter state
...
It contains the .scrollWidth and then all the lines in a nested .lines
object. The .width has been removed from each line and replaced with
.content.scrollWidth.
2015-02-03 15:05:15 -07:00
Nathan Sobo
3ec4b632ba
Update TextEditorPresenter with scoped character widths in component
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
2015-02-03 15:05:15 -07:00
Nathan Sobo
115d764725
Handle scoped character widths in TextEditorPresenter
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
2015-02-03 15:05:14 -07:00
Nathan Sobo
20bb14da81
Start using TextEditorPresenter in LinesComponent
...
Removed shouldComponentUpdate because we will always update the
component manually once this is done, but I don’t want to accidentally
prevent the component from updating during the conversion process.
This commit has a failing spec due to the presenter not accounting for
individual character widths.
2015-02-03 15:05:14 -07:00
Nathan Sobo
a3fb8b3aaa
Disable spec until presenter approach stabilizes
2015-02-03 15:05:14 -07:00
Nathan Sobo
9e6aa8f873
Include more fields in line state
2015-02-03 15:05:14 -07:00
Nathan Sobo
e2693da225
Fix endRow calculation
2015-02-03 15:05:14 -07:00
Nathan Sobo
9a070e7f6d
Include endOfLineInvisibles in presenter state
2015-02-03 15:05:14 -07:00
Nathan Sobo
db5059626f
Use getters in TextEditorPresenter internally for consistency
...
::clientHeight is conditionally computed in the getter, so lets use them
everywhere for consistency.
2015-02-03 15:05:13 -07:00
Nathan Sobo
7095ccd32b
Make all lines visible if no external client height is assigned
2015-02-03 15:05:13 -07:00
Nathan Sobo
ac463143dd
Add 1 pixel to scrollWidth to account for cursor if not soft-wrapped
2015-02-03 15:05:13 -07:00
Nathan Sobo
2296d2d378
Account for overdrawMargin of startRow when computing the endRow
2015-02-03 15:05:13 -07:00
Nathan Sobo
143183aa25
🎨
2015-02-03 15:05:13 -07:00
Nathan Sobo
0f4bcac8d4
Add 1 to the last row to ensure it’s visible
2015-02-03 15:05:12 -07:00
Nathan Sobo
b09b54800f
Include line text in presenter state
2015-02-03 15:05:12 -07:00
Nathan Sobo
2120c3c298
Instantiate presenter in TextEditorComponent and update measurements
2015-02-03 15:05:12 -07:00
Nathan Sobo
f4d8ef8315
Add width to lines state based on the computed scrollWidth
...
This is based on the ::baseCharacterWidth property for now. To be fully
correct, we need to base the scrollWidth on the actual width of
individual characters.
2015-02-03 15:05:12 -07:00
Nathan Sobo
a1c2e1bb66
Update TextEditorPresenter when the editor’s content changes
2015-02-03 15:05:12 -07:00
Nathan Sobo
5a2bbc945b
Handle changing ::lineHeight in TextEditorPresenter
2015-02-03 15:05:12 -07:00
Nathan Sobo
9c2ed478cd
Handle changing ::clientHeight in TextEditorPresenter
2015-02-03 15:05:11 -07:00
Nathan Sobo
880e1ce1f0
Handle changing ::scrollTop in TextEditorPresenter
2015-02-03 15:05:11 -07:00
Nathan Sobo
f0920bf63b
Start on TextEditorPresenter with lines state
2015-02-03 15:05:11 -07:00
Kevin Sawicki
37a85bcdd0
⬆️ language-css@0.27
2015-02-03 13:50:45 -08:00
Kevin Sawicki
47bd093d68
🐎 Load 6to5 version directly from package.json
...
This prevents the entire library from being required just to check the
cache so when 6to5 is being used and all files are cached it should shave
~250ms off startup.
2015-02-03 13:36:26 -08:00
Kevin Sawicki
a788a7e9b7
⬆️ language-xml@0.28
2015-02-03 10:53:29 -08:00
Kevin Sawicki
9101da11ce
⬆️ update-package-dependencies@0.8
2015-02-03 10:41:26 -08:00
Max Brunsfeld
f7159181ac
📝 Tweak docs for new service APIs
2015-02-03 10:21:23 -08:00
Kevin Sawicki
1784a7f726
⬆️ Upgrade one themes
2015-02-03 10:20:23 -08:00
Kevin Sawicki
a28a8447a7
⬆️ language-json@0.12
2015-02-03 10:18:25 -08:00
Kevin Sawicki
197e74f18d
Prepare 0.178
2015-02-03 09:43:05 -08:00
Kevin Sawicki
5cae6f20c4
Merge pull request #5368 from atom/ld-jasmine-ref-fix
...
Fix link to wrong version of Jasmine
2015-02-03 09:06:11 -08:00
Kevin Sawicki
6ad704c1e4
Defer requiring 6to5 until it is used
...
It seems to have a require time of ~250ms
2015-02-03 09:05:34 -08:00
Ben Ogle
2b0cb11df3
Merge pull request #5374 from atom/ld-doc-composed-commands
...
Add section on "composed" commands to Advanced Keymap document
2015-02-03 09:04:29 -08:00
Lee Dohm
9aee7d4b38
📝 Add section about composed commands
...
Fix #5357
This is intended to address the commonly-asked question about making a keybinding execute multiple commands.
2015-02-03 04:50:38 -08:00
Lee Dohm
b6c86ea217
📝 Update command example for CommandRegistry
2015-02-03 04:31:23 -08:00
Lee Dohm
0d169f0516
Fix link to wrong version of Jasmine
...
Applies to #5354
2015-02-02 20:26:35 -08:00
Kevin Sawicki
5dea6e7d12
Link to all guides
...
Closes #5332
2015-02-02 18:20:53 -08:00
Kevin Sawicki
312e4e0e8a
Be graceful about pathsToOpen string value
...
Gently convert it to an array of strings before opening
Closes #5340
2015-02-02 18:17:15 -08:00
Kevin Sawicki
853ad9cee3
Re-throw stylesheet compile errors
...
This makes it consistent with other read errors. Previously a Notification
was returned in the error case causing errors downstream where the package's
stylesheets array was assumed to be a path/content tuple.
Closes atom/deprecation-cop#22
2015-02-02 17:55:36 -08:00
Max Brunsfeld
a5ccfa6299
Merge pull request #5346 from atom/ld-doc-updates
...
Some documentation updates
2015-02-02 17:26:08 -08:00
Lee Dohm
800ca5a37a
📝 Add a missing comma
2015-02-02 17:22:53 -08:00
Lee Dohm
23b8b15261
📝 Fix broken json-schema.org link
2015-02-02 17:22:29 -08:00
Lee Dohm
959aa08d62
📝 Atom 1.0 API is now frozen
2015-02-02 17:22:29 -08:00
Lee Dohm
6eed4e461f
📝 Give stronger recommendation on deactivate
...
Many packages don't clean up properly on update, causing strange
behavior until restart. Simply stating that the `deactivate` method is
optional is enough to let people know that it isn't required for the
common case.
2015-02-02 17:22:29 -08:00
Lee Dohm
00b79e69f1
📝 activationEvents are now activationCommands
2015-02-02 17:22:29 -08:00
Max Brunsfeld
3739995ddb
Merge pull request #5277 from atom/mb-package-json-services
...
Allow packages to specify services in their package.json files
2015-02-02 17:07:41 -08:00
