Antonio Scandurra
59cc10a1ee
Bring in @nathansobo PR changes
...
...as they were needed to pass specs
2015-02-19 21:09:06 +01:00
Antonio Scandurra
79c16a0d00
Use softWrapAtNewLines in moveDown and moveUp
...
/cc: @nathansobo
2015-02-19 20:01:37 +01:00
Antonio Scandurra
d3b7ea475f
Rename phantomTab to indentToken
2015-02-19 18:58:38 +01:00
Antonio Scandurra
ac6a7bb47f
Rename to Token#buildSoftWrapIndentToken
2015-02-19 18:06:20 +01:00
Antonio Scandurra
67ef17e0c8
💚 Fix soft wrapping scroll spec
2015-02-19 16:23:59 +01:00
Antonio Scandurra
85e202ee0a
Get rid of wrapAtPhantomTokens
2015-02-19 16:23:51 +01:00
Antonio Scandurra
8184ad9a77
✅ Ensure phantom tabs are correctly tokenized
2015-02-18 21:31:00 +01:00
Antonio Scandurra
bef1e862cc
✅ Fix failing specs (and add new ones)
...
When fixing failing specs, I adapted existing expectations to match the "soft
wrap indenting" behaviour: this means that there's no need to write a new spec
for it.
2015-02-18 21:20:04 +01:00
Antonio Scandurra
e5eaa25381
Wrap at phantom tokens only when moving cursor left
...
This prevents a weird behavior that affects selection. Before this commit, when
moving the cursor down, if it was inside a real (soft|hard)-tab of a soft
wrapped line, it would reach the end of the line rather than the beginning of
the next wrapped line.
/cc: @nathansobo
2015-02-18 18:58:43 +01:00
Antonio Scandurra
62434d9ad5
Move findWrapColumn into TokenizedLine
...
* 🐎 Check `isSoftWrapped` only once when updating screen lines
2015-02-18 10:05:48 +01:00
Antonio Scandurra
b0c670b80a
Better naming
...
...thanks @nathansobo
2015-02-18 09:52:23 +01:00
Antonio Scandurra
5e4221f91c
Don't show leading phantom tokens
...
...thanks @grizzilus 😄
2015-02-18 09:46:03 +01:00
Antonio Scandurra
88ca44d53b
Use guard clauses, instead of crappy ANDs
2015-02-16 17:56:36 +01:00
Antonio Scandurra
e62e26a3c2
Wrap on words, not chars
2015-02-16 17:45:57 +01:00
Antonio Scandurra
38118b66cb
Do not rely on text anymore, check phantom tokens instead
2015-02-16 15:49:00 +01:00
Antonio Scandurra
131048af65
Use intention-revealing method names
2015-02-16 15:48:59 +01:00
Antonio Scandurra
abd143a255
Extract phantom token recognition into TokenizedLine
2015-02-16 14:33:37 +01:00
Antonio Scandurra
469876161a
Improve TokenizedLine#clipScreenColumn
2015-02-16 12:53:09 +01:00
Antonio Scandurra
5ce01118be
Cover edge cases
2015-02-16 12:30:00 +01:00
Antonio Scandurra
46fca8360b
Use @tabLength instead of an arbitrary value
2015-02-16 11:58:21 +01:00
Antonio Scandurra
fb21cf6123
Wrap appropriately
2015-02-15 12:33:34 +01:00
Antonio Scandurra
7f1bb69580
Initial attempt
2015-02-14 19:04:53 +01:00
Max Brunsfeld
2dac7fd18e
Merge pull request #5475 from atom/mb-multi-folder-project
...
Allow project API to support multiple root directories
2015-02-12 22:28:16 -08:00
Max Brunsfeld
ac78cee584
🔥 ncp; use fs.copySync
2015-02-12 22:14:02 -08:00
Max Brunsfeld
30bd85d8cc
Add some waiting in integration test
...
* Give chromedriver a few millis to start up
* Wait for atom-workspace element to appear before querying
active panes.
2015-02-12 21:18:20 -08:00
Max Brunsfeld
8cc0372432
Avoid unhandled promise rejection warning
2015-02-12 21:18:20 -08:00
Max Brunsfeld
a5b28b2833
Rename test helper method
2015-02-12 21:18:20 -08:00
Max Brunsfeld
476876e479
Restore behavior of reusing focused window for opened files
2015-02-12 21:18:20 -08:00
Max Brunsfeld
e0aa8e7f5c
Move ncp dependency to build/package.json
2015-02-12 21:18:20 -08:00
Max Brunsfeld
29662efe7c
Don't re-use dev windows for non-dev or vise-versa
2015-02-12 21:18:20 -08:00
Max Brunsfeld
f7e1629cfc
Set multiple project paths for multiple cmd-line paths
...
Signed-off-by: Jessica Lord <jlord@github.com>
2015-02-12 21:18:18 -08:00
Max Brunsfeld
81d07e2804
Improve error-handling in integration spec
2015-02-12 21:18:17 -08:00
Max Brunsfeld
ba789800b7
Fix handling of args and env in atom-launcher script
...
Signed-off-by: Jessica Lord <jlord@github.com>
2015-02-12 21:18:16 -08:00
Max Brunsfeld
4ebfd22e3d
Add Project::addPath
2015-02-12 21:16:26 -08:00
Max Brunsfeld
8ab4ad54d8
Allow Project::setPaths to handle multiple paths
...
Signed-off-by: Jessica Lord <jlord@github.com>
2015-02-12 21:16:15 -08:00
Max Brunsfeld
ce02c74b76
Remove unused instance variable
...
Signed-off-by: Jessica Lord <jlord@github.com>
2015-02-12 20:37:40 -08:00
Max Brunsfeld
c732ae8774
Add atom.pickFolder
...
For showing the native file-picker dialog. The tree-view
will use this to add new root folders
Signed-off-by: Jessica Lord <jlord@github.com>
2015-02-12 20:37:35 -08:00
Nathan Sobo
6a36bdda25
Replace ::hasRequiredMeasurements() with specific criteria in presenter
...
Now each update method requires a list of specific variables to be
defined before running.
2015-02-12 19:48:06 -07:00
Nathan Sobo
5b6990f14c
Don’t update state in presenter unless prerequisites are defined
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
2015-02-12 19:39:11 -07:00
Kevin Sawicki
689e52de78
⬆️ text-buffer@4.1.4
2015-02-12 17:39:18 -08:00
Kevin Sawicki
dbf384f719
mkdirp -> fs.makeTree
2015-02-12 17:16:07 -08:00
Kevin Sawicki
05d28dd114
⬆️ archive-view@0.50
2015-02-12 17:06:09 -08:00
Nathan Sobo
01512989f7
Comment out json-diff module require
...
This is only for use locally to troubleshoot failing specs.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
2015-02-12 18:04:40 -07:00
Kevin Sawicki
08d7236125
⬆️ atom-space-pen-views@2.0.4
...
Adding this to core even though it is only needed by core packages
in order to ensure the version that gets bundled in Atom.
2015-02-12 16:42:08 -08:00
Kevin Sawicki
582b819efa
Remove unused guid dependency
2015-02-12 16:30:32 -08:00
Kevin Sawicki
865c58cc5b
⬆️ settings-view@0.181
2015-02-12 16:27:31 -08:00
Kevin Sawicki
80f82e189e
Defer runas require until it is used
2015-02-12 16:18:27 -08:00
Nathan Sobo
a7f2e89b2c
Merge pull request #5534 from atom/ns-mb-optimize-auto-indent-on-paste
...
Optimize auto-indent on paste
2015-02-12 17:06:23 -07:00
Kevin Sawicki
ef7726ba35
Uncomment env var check
2015-02-12 16:04:27 -08:00
Kevin Sawicki
44d54c28b3
⬆️ coffeestack@1.1.1
2015-02-12 16:02:55 -08:00
