Commit Graph

36146 Commits

Author SHA1 Message Date
Rafael Oleza
6c46cf9243 Fix remaining linter issues 2019-02-28 19:30:03 +01:00
Rafael Oleza
cd302135f0 Fix undefined variables from specs 2019-02-28 19:30:03 +01:00
Rafael Oleza
d7d6d0838f Remove unused vars from specs 2019-02-28 19:30:03 +01:00
Rafael Oleza
c35ec012b4 Run prettier on spec/ folder 2019-02-28 19:30:03 +01:00
Rafael Oleza
c4aa086024
Merge pull request #18917 from rafeca/rewrite-jasmine-globals
Override global jasmine spec functions
2019-02-28 16:35:57 +01:00
Rafael Oleza
7876e04e97 Override global jasmine spec functions
Currently, if a spec uses the global `it` function on an async test,
that test will always pass (since the jasmine version checked in Atom
does not natively support tests that return promises). This can be
confusing since the test behaviour is different between the
async-test-helpers methods and the global ones.

By overriding the global functions, we'll also be able to remove all the
imports from async-test-helpers since they won't be needed anymore.

More info: https://github.com/atom/atom/pull/18896#discussion_r260396102
2019-02-28 15:15:08 +01:00
Rafael Oleza
f4685ac7ff
Merge pull request #18924 from rafeca/finish-update-packages
Update versions of fuzzy-finder and snippets
2019-02-28 13:37:32 +01:00
Rafael Oleza
96b29fe3ce Update versions of fuzzy-finder and snippets
I forgot to update the second place on the `package.json` where its version is
specified
2019-02-28 12:13:16 +01:00
simurai
a5a5097a45
Merge pull request #18921 from atom/sm-update-welcome-2
Update welcome@v0.36.8 II
2019-02-28 19:39:16 +09:00
Rafael Oleza
e26f561543
Merge pull request #18923 from rafeca/update-snippets
⬆️ snippets@1.4.1
2019-02-28 10:55:07 +01:00
Rafael Oleza
c643d96fca ⬆️ snippets@1.4.1 2019-02-28 10:49:48 +01:00
simurai
e7ce8c3166 ⬆️ welcome@v0.36.8 2019-02-28 17:27:28 +09:00
Rafael Oleza
af591495ce
Merge pull request #18919 from rafeca/update-fuzzy-finder
⬆️ fuzzy-finder@1.9.2
2019-02-27 21:39:51 +01:00
Rafael Oleza
bd6a0fc37c ⬆️ fuzzy-finder@1.9.2 2019-02-27 20:35:12 +01:00
Jason Rudolph
2712b1f505
Merge #18908: Revert to Electron 2 until we can overcome crashes on Electron 3 2019-02-26 13:25:05 -05:00
Jason Rudolph
3b195122c4
Tell VSTS to build electron-* branches 2019-02-25 15:17:09 -05:00
Jason Rudolph
9ff5160b45
Update package-lock.json and script/package-lock.json 2019-02-25 15:14:53 -05:00
Jason Rudolph
c9e6d04e8c
Revert "Merge #18603 from atom/electron-3-0"
This reverts commit b92ae2ad04, reversing
changes made to d4fe5ccfeb.
2019-02-25 13:41:59 -05:00
Jason Rudolph
46fa62ac59
Revert "Merge #18815 from atom/electron-3.1.3"
This reverts commit e81f71318a, reversing
changes made to bded0c102a.
2019-02-25 13:37:35 -05:00
Rafael Oleza
042fb45a43
Merge pull request #18906 from rafeca/fix-git-diff-test
Fix git-diff package test
2019-02-25 16:30:28 +01:00
Rafael Oleza
9cf34c0e89 Fix git-diff package test 2019-02-25 15:08:51 +01:00
Rafael Oleza
b2c0028889
Merge pull request #18885 from rafeca/add-linting-to-packages
Add linter to packages/ folder
2019-02-25 13:35:04 +01:00
Rafael Oleza
034a05c8f4 Enable linter on packages/ folder 2019-02-25 13:05:02 +01:00
Rafael Oleza
ebf137954c Add comment and ignore rule on regular expression. 2019-02-25 13:05:02 +01:00
Rafael Oleza
3f1b965343 Lint fixture file from go-to-line package
The specs needed to be updated since they depended on the actual contents
of the fixture.
2019-02-25 13:04:54 +01:00
Rafael Oleza
20ec642da1 Lint fixture file from git-diff package 2019-02-25 12:58:59 +01:00
Rafael Oleza
e734434811 Small linter fixes 2019-02-25 12:50:18 +01:00
Rafael Oleza
11206eca76 Add curly braces around if statements 2019-02-25 12:50:18 +01:00
Rafael Oleza
f6db819485 Remove unused variables from specs 2019-02-25 12:50:18 +01:00
Rafael Oleza
7e23d4dc7a Run prettier on packages/ folder 2019-02-25 12:19:44 +01:00
Rafael Oleza
64d63b9d4a Fix syntax error in fixture 2019-02-25 11:10:22 +01:00
Rafael Oleza
f1aef0b42f
Merge pull request #18898 from rafeca/update-find-and-replace
⬆ find-and-replace@0.218.9
2019-02-25 11:06:37 +01:00
Rafael Oleza
07a0842c67 ⬆ find-and-replace@0.218.9 2019-02-25 10:31:45 +01:00
Rafael Oleza
679b4631e1
Merge pull request #18899 from rafeca/update-fuzzy-finder
⬆️ fuzzy-finder@1.9.1
2019-02-25 10:23:59 +01:00
Ash Wilson
e87e5562b3
Merge pull request #18900 from atom/aw/actually-dump-symbols
Actually dump minidump contents to .sym files
2019-02-22 16:15:13 -05:00
Ash Wilson
b5898b8e07
Actually dump minidump contents to the file 2019-02-22 15:02:47 -05:00
Rafael Oleza
1a79b39b2d ⬆️ fuzzy-finder@1.9.1 2019-02-22 17:40:57 +01:00
Lee Dohm
d07d854986
Merge pull request #16558 from lgeiger/async-git
Add async implementation of GitRepositoryProvider.repositoryForDirectory
2019-02-21 09:29:53 -08:00
simurai
41a180b9d0
Merge pull request #18844 from atom/sm-diff-icons
Align git-diff icons
2019-02-18 15:20:24 +09:00
David Wilson
d3a3859305
Merge pull request #18864 from atom/dw-bump-keymap
⬆️ atom-keymap@8.2.13
2019-02-17 20:12:52 -08:00
David Wilson
0a2ce1b38f ⬆️ atom-keymap@8.2.13 2019-02-17 17:58:05 -08:00
Ash Wilson
1acf91383c
Merge pull request #18863 from atom/aw/console-in-tests
Allow the use of console, stdout, and stderr in Jasmine tests
2019-02-17 18:36:02 -05:00
David Wilson
ce4180e9f1 Upload Windows delta nupkg artifacts in release builds 2019-02-17 15:12:07 -08:00
Ash Wilson
f0fb288849
Override console.(log|error) and process.std(out|err) when headless 2019-02-17 17:09:58 -05:00
Ash Wilson
402fa903fd
Merge pull request #18802 from atom/aw/jasmine-junit-xml
Report test result metadata to Azure DevOps
2019-02-16 11:02:20 -05:00
David Wilson
eadb900ab2
Merge pull request #18855 from atom/dw-fix-open-folder
Fix "Open Folder" menu item on Windows
2019-02-15 13:25:41 -08:00
Ash Wilson
13a6d43e61
Remove stdout noise 2019-02-15 16:10:21 -05:00
Ash Wilson
efd9151589
Revert temporary script/test changes 2019-02-15 16:09:27 -05:00
Ash Wilson
06a1a38d25
Oh. Right. That's interpreted as a .bat file 2019-02-15 14:56:39 -05:00
Ash Wilson
60aaca8ecc
Er, maybe no separator at all? 2019-02-15 13:02:25 -05:00