I'm assuming that `addError` displays an error.
I'm also logging the error on the console - for theoretical debugging in case the notification is dismissed - but maybe it's unnecessary.
I renamed `event` to `error` in the `onupgradeneeded` handler
- Four days of work to get those damn test to run again, just for a two character change to fix the tests.
- Now also added all other, minor changes to sane-indendation over the last five years since the PR for this change was opened.
Categories shouldn't include GNOME, as that's for GNOME core apps.
MimeType should include all default (i.e., with the default bundled
packages) supported file types for the editor.
add migration branch to list of triggers
revert pr trigger
set isReleaseBranch and isSignedZipBranch to true, this is temporary
fix lint
alter config files
set release branch to false
add @azure/storage-blob
This commit enables faster, more-reproducible installs of `apm`,
when bootstrapping/building Atom in `ci` mode.
(with `--ci` or env var `CI` set).
This only affects bootstrapping/building Atom; This should
not make any difference to the built Atom app, or to `apm`'s behavior
as a command-line tool/as a component of Atom.
Details:
As of apm 2.6.2, apm respects a `NO_APM_DEDUPE` env var on Windows.
(It was already supported on Linux and macOS before then.)
When set, this env var disables the deduping
normally performed at the end of apm's postinstall script.
This deduping doesn't work properly when installing apm with `npm ci`,
for unknown reasons. (The deduping algorithm deletes many needed
dependencies, without reconstructing a valid tree.)
Now that `apm` supports `NO_APM_DEDUPE` on all platforms,
we can safely allow installing `apm` with `npm ci`
during the bootstrap script.
Now bootstrapping apm in `ci` mode is faster in two ways:
- `npm ci` is generally faster than `npm install` for clean installs.
- Great for actual automated builds ("CI").
- The `npm dedupe` run is now skipped in `ci` mode.
- The `npm dedupe` was of dubious value in any case
- The `npm dedupe` command was also surprisingly slow
We also benefit from the stronger reproducibility of `npm ci`
compared to `npm install` (guaranteed, version-locked dependencies).
