Commit Graph

7395 Commits

Author SHA1 Message Date
Antonio Scandurra
34978bfeda Merge branch 'master' into ns-modernize-build 2016-08-26 16:20:46 +02:00
Antonio Scandurra
5b57669859 Disable telemetry on AtomApplication tests and smoke-spec.coffee
Unless a choice has been made by the user, this tab always shows up as
the first one when opening Atom, thus breaking some of the assumptions
we make in the main process tests.
2016-08-26 15:13:37 +02:00
Antonio Scandurra
194f927b87 Merge branch 'master' into ns-modernize-build
# Conflicts:
#	build/tasks/build-task.coffee
2016-08-26 13:25:02 +02:00
Wliu
bf463d59c8 Unfocus specs
/cc @damieng
2016-08-25 22:44:57 -04:00
Damien Guard
0f88949832
Remove all redundant separators 2016-08-25 12:49:29 -07:00
Damien Guard
d44dbb373d
Remove trailing context menu separator fixing #5390 2016-08-24 21:45:21 -07:00
Andres Suarez
4ca6eaff34 Add atom.project.observeBuffers
This makes `onDidAddBuffer` symmetrical with other `onDidAddX` methods and their `observeXs`. It also documents `onDidAddBuffer` and adds tests for it.

Released under CC0.
2016-08-22 18:00:54 -07:00
Antonio Scandurra
de6b836da4 Add test coverage for copying auto{Width,Height} 2016-08-19 14:10:59 +02:00
Antonio Scandurra
1f4cd6e00d Merge branch 'master' into ns-fix-editor-auto-height
# Conflicts:
#	src/text-editor.coffee
2016-08-19 13:27:26 +02:00
Antonio Scandurra
98fb29800a Don't use deprecate API in tests 2016-08-19 12:40:28 +02:00
Nathan Sobo
4b68e2f411 Remove trailing semicolon 2016-08-19 12:36:26 +02:00
Matthew Dapena-Tretter
fd29f96af9 Serialize active pane item using index instead of URI 2016-08-19 12:36:26 +02:00
Max Brunsfeld
d25f824020 Merge pull request #12469 from atom/mb-fix-tab-length-deserialization
Fix tab length deserialization
2016-08-18 21:46:20 -07:00
Max Brunsfeld
26c9e5ee78 Set editor's tokenized buffer's tab length on its display layer when deserializing 2016-08-18 17:06:26 -07:00
Wliu
af48a087c3 Merge pull request #12439 from remexre/master
Adds configuration option for large file warning threshold.
2016-08-18 17:32:36 -04:00
Nathan Sobo
dd82902bf2 Disable autoHeight on text editor pane items 2016-08-18 14:03:44 -06:00
Nathan Sobo
f723bccc29 Add test coverage for deprecated implicit disabling of autoHeight 2016-08-18 14:03:44 -06:00
Nathaniel Ringo
10b3cbc00c 💚 Hopefully fixes configurable-filesize-warning limit specs. 2016-08-18 14:54:23 -05:00
Nathan Sobo
9f8f03b10f Add test coverage for TextEditor autoHeight 2016-08-18 13:45:00 -06:00
Max Brunsfeld
90b699f5cc Remove some text editor ivars that are redundant w/ display layer properties 2016-08-18 10:41:11 -07:00
Nathaniel Ringo
05602a85ff 💚 Fixes tests for configurable large-file-warning. 2016-08-17 18:11:24 -05:00
Nathaniel Ringo
7be9ff527f 🎨 Improves customizable-size-warning spec styling. 2016-08-17 17:36:54 -05:00
Nathan Sobo
13c00995d4 Return default value of true from TextEditor.getAutoHeight
When we need to check for unassigned in the deprecated code path, we
can just read the instance variable directly to avoid getting the
deafult.

Signed-off-by: Antonio Scandurra <as-cii@github.com>
2016-08-17 15:52:51 -06:00
Nathan Sobo
106621e161 Deprecate automatic assignment of autoHeight for text editors
Previously, we attempted to automatically determine whether the editor’s
height should be based on the editor’s content or the height of its
container. Unfortunately, DOM APIs are insufficient to make this
determination in a complete way, leading to unpredictable behavior.

This PR deprecates the automatic determination of this behavior. By
default, editors base their height on their content. If an editor has
an explicit height assigned via its style or is positioned absolute with
an explicit top and bottom, we disable the content-based autoHeight and
log a deprecation warning telling the user to assign autoHeight
explicitly.

This paves the way to add an autoWidth setting, which will default to
false.
2016-08-17 15:52:51 -06:00
Nathaniel Ringo
324bf649ea Improves specs for configurable large file limit. 2016-08-17 15:14:22 -05:00
Nathaniel Ringo
5a1def03ac Updates spec for configurable large file limit. 2016-08-17 13:37:36 -05:00
Antonio Scandurra
1587dcbe89 Take the gutter width into account when sizing TextEditorElement 2016-08-17 19:21:56 +02:00
Antonio Scandurra
3642292302 🔥 debugger 2016-08-17 18:05:58 +02:00
Antonio Scandurra
e71027ed36 Ensure editors don't scroll or show scrollbars when autoWidth is enabled 2016-08-17 17:58:36 +02:00
Antonio Scandurra
e8f2e3a608 Size TextEditorElement according to the autoWidth property 2016-08-17 16:20:00 +02:00
Antonio Scandurra
2e37d7f0cf Change state.content.width based on autoWidth 2016-08-17 16:14:57 +02:00
Antonio Scandurra
683bf37907 Add autoWidth to TextEditor 2016-08-17 16:14:36 +02:00
Max Brunsfeld
c5a6e9c697 Merge branch 'master' into ns-mb-detangle-editor 2016-08-16 09:11:11 -07:00
Antonio Scandurra
f139c800e2 Merge branch 'master' into ns-modernize-build 2016-08-16 16:10:59 +02:00
Max Brunsfeld
8702b4ca47 Remove 'Some textSome textSome textSome text' 2016-08-15 17:12:40 -07:00
Max Brunsfeld
8018dc9d57 Allow ATOM_HOME to be reassigned if the new value is valid 2016-08-15 17:05:18 -07:00
Max Brunsfeld
4b0183d074 Remove extraneous TextEditor setter methods 2016-08-15 16:45:10 -07:00
Max Brunsfeld
0d099d2fd5 Serialize all TextEditor parameters needed for the DisplayLayer 2016-08-15 15:51:22 -07:00
Max Brunsfeld
4bcdbf4d2f Don't have registry update any editors before initial packages are loaded 2016-08-15 15:29:27 -07:00
Max Brunsfeld
1c99c399d1 Merge branch 'master' into ns-mb-detangle-editor 2016-08-15 11:17:07 -07:00
Antonio Scandurra
de7e6c977f Merge branch 'master' into ns-modernize-build 2016-08-13 10:40:53 +02:00
Nathan Sobo
ebb03f022b Merge branch 'master' into ns-mock-animation-frames-in-editor-spec 2016-08-12 16:16:09 -06:00
Nathan Sobo
7146a6bde9 Merge remote-tracking branch 'origin/master' into ns-modernize-build 2016-08-12 15:33:50 -06:00
Max Brunsfeld
bf644d1a6b Remove some unnecessary TextEditor accessor methods 2016-08-12 14:31:07 -07:00
Nathan Sobo
ced2174b5a Mock clock and animation frames in TextEditorComponent specs 2016-08-12 15:21:46 -06:00
Max Brunsfeld
94808303e5 Fix spec for preserving custom grammars when panes are split 2016-08-12 14:11:20 -07:00
Max Brunsfeld
a11a235ef1 Don't reset display layer twice in TextEditor constructor 2016-08-12 13:36:50 -07:00
Nathan Sobo
2710ce33d1 Merge pull request #12394 from atom/ns-as-switch-offset-test-to-mocha
Replace ChromeDriver integration tests main process Mocha tests
2016-08-12 14:17:16 -06:00
Nathan Sobo
b6ab5530b5 Fix focus issues on CircleCI 2016-08-12 13:35:08 -06:00
Max Brunsfeld
09d232ba41 Introduce TextEditorRegistry::build
This way, we can construct text editors with the right parameters from the start
2016-08-12 12:21:51 -07:00
Nathan Sobo
c861abc2a9 Fix timing issues in atom-application-test
Signed-off-by: Antonio Scandurra <as-cii@github.com>
2016-08-12 11:46:12 -06:00
Antonio Scandurra
9847c4fc24 Wait until the window is focused before interacting with it in tests
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-08-12 17:46:13 +02:00
Antonio Scandurra
87d684132c Extract timeoutPromise into async-spec-helpers
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-08-12 17:46:12 +02:00
Antonio Scandurra
82f0003302 Extract conditionPromise into async-spec-helpers
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-08-12 17:46:11 +02:00
Antonio Scandurra
ab3d0ba412 Rewrite async-spec-helpers in javascript
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-08-12 17:46:09 +02:00
Antonio Scandurra
4bd644bea2 Bump timeout to 1 minute on AtomApplication tests
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-08-12 17:45:59 +02:00
Antonio Scandurra
336f6425da Discourage people from using temp directly
It's better if we fs.realpathSync the path returned by the temp module.

Signed-off-by: Nathan Sobo <nathan@github.com>
2016-08-12 17:45:56 +02:00
Antonio Scandurra
04d8b9bb86 Ensure we don't reuse the same window when testing the offset distance
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-08-12 17:45:50 +02:00
Antonio Scandurra
753db274fc Clear storage data after each AtomApplication test
This, along with using a temporary directory as the ATOM_HOME, will make
sure that tests won't share any state with one another, possibly
increasing the level of resiliency of the suite.
2016-08-12 15:20:58 +02:00
Antonio Scandurra
a817a354dc Use project paths instead of tree view directories to test remote paths 2016-08-12 14:35:40 +02:00
Antonio Scandurra
fe8aabd908 Use spec reporter to know which specs hang 2016-08-12 12:22:36 +02:00
Antonio Scandurra
428106bcaa Add smoke test to ensure Atom runs and basic operations can be performed 2016-08-12 11:46:48 +02:00
Antonio Scandurra
7fe0f6b455 Move another integration test 2016-08-12 11:29:34 +02:00
Antonio Scandurra
da7b951c07 Move another integration test 2016-08-12 11:22:32 +02:00
Antonio Scandurra
02bc4282d0 Move another integration test 2016-08-12 10:58:59 +02:00
Antonio Scandurra
fff2ecd162 Extract a AtomApplication.prototype.launch method
...so that we can exercise loading previously opened windows stored
state after the application is restarted. In addition, this resembles
more what we run in production, and therefore allows us to have a better
coverage of the code paths we run in the real application.
2016-08-12 10:44:09 +02:00
Antonio Scandurra
e8c7b27af4 Move another integration test 2016-08-12 10:10:20 +02:00
Max Brunsfeld
0a1834079f Rename getSoftWrapIndentLength -> getSoftWrapHangingIndentLength 2016-08-11 16:38:34 -07:00
Joe Fitzgerald
f529ebb237 🎨 Update Describe / It Descriptions 2016-08-11 17:08:28 -06:00
Joe Fitzgerald
485cb71be7 🎨 envShouldBePatched > shouldGetEnvFromShell 2016-08-11 17:07:21 -06:00
Joe Fitzgerald
9ec63a8ffc 🎨 Cleanup
* shellShouldBePatched > envShouldBePatched
2016-08-11 16:45:19 -06:00
Nathan Sobo
3d99cde9e1 Move another integration spec to the main process tests 2016-08-11 16:43:26 -06:00
Max Brunsfeld
684952458f Remove new TextEditor setters; just use update 2016-08-11 15:34:54 -07:00
Nathan Sobo
a29db76073 Move another integration test 2016-08-11 16:33:36 -06:00
Nathan Sobo
b89c0cb415 Move another integration test 2016-08-11 16:33:25 -06:00
Nathan Sobo
29cf1025f1 Assert about tree view root directories rather than project directories
Since these are integration tests, making sure the user sees these
directories in their tree view seems like a good idea.
2016-08-11 16:20:29 -06:00
Nathan Sobo
f953588f91 Move opening multiple directories integration spec to main process tests
It was testing something that didn’t actually work, that opening a
directory that was already open in an existing window would recycle the
window. We explicitly don’t behave that way and the old test was passing
spuriously.
2016-08-11 16:12:41 -06:00
Nathan Sobo
dbfd0cc605 Move integration test of window persistence to main process tests 2016-08-11 15:28:11 -06:00
Nathan Sobo
3a3921709f Restore env guard in integration test 2016-08-11 15:27:44 -06:00
Nathan Sobo
5f414f4ea7 Move integration specs for reusing windows to main process tests 2016-08-11 15:10:38 -06:00
Nathan Sobo
15bb92f35e Move whitespace trimming integration spec to main process tests 2016-08-11 14:43:23 -06:00
Nathan Sobo
f80c800347 Move test for opening w/ a line:column from Chromedriver to main process 2016-08-11 14:36:47 -06:00
Nathan Sobo
4d4a2530ff Move test for opening w/ a line number from Chromedriver to main process 2016-08-11 14:33:54 -06:00
Nathan Sobo
52ea92803d Use parseCommandLine in atom-application-test.js 2016-08-11 12:45:54 -06:00
Joe Fitzgerald
b7a48967fa Fix Regression In #12317 For zsh
In Atom 1.7 and 1.8, the environment would be patched for users of the zsh shell on OS X. A whitelist of shells was established in #12317, which is extended here.
2016-08-11 12:45:02 -06:00
Max Brunsfeld
11463ef00b Merge remote-tracking branch 'origin/as-introduce-editor-update' into ns-mb-detangle-editor 2016-08-11 11:36:48 -07:00
Nathan Sobo
502339b830 Replace chromedriver test of window offset with main process mocha test
Signed-off-by: Antonio Scandurra <as-cii@github.com>
2016-08-11 10:33:12 -06:00
Nathan Sobo
5a8ab1a2b2 🎨
Signed-off-by: Antonio Scandurra <as-cii@github.com>
2016-08-11 08:16:18 -06:00
Antonio Scandurra
6bd9d1e4be Install webdriver io in script/package.json
So that we can control chromedriver without including that dependency in the final bundle.
2016-08-11 13:09:24 +02:00
Antonio Scandurra
6f9a8208db Download chromedriver and run integration tests 2016-08-11 12:40:40 +02:00
Max Brunsfeld
6d4e0f9b0a 🚱 Stop maintaining destroyed editors' grammar and config 2016-08-10 13:54:37 -07:00
Max Brunsfeld
38849474d0 Merge branch 'master' into ns-mb-detangle-editor 2016-08-10 13:23:32 -07:00
Antonio Scandurra
23f421154e Delete TokenizedBuffer.prototype.onDidChange
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-08-10 17:52:49 +02:00
Max Brunsfeld
5d24bcf19e Merge pull request #12237 from zertosh/cleanup-activation-hook-subscrtiptions
Cleanup activationHookSubscriptions when deactivating package
2016-08-09 17:08:49 -07:00
Max Brunsfeld
29096bde31 Don't update ATOM_HOME env var after launch
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-08-09 14:38:19 -07:00
Max Brunsfeld
d21c6f1482 Rename environment-helpers-spec -> update-process-env-spec 2016-08-09 14:26:51 -07:00
Nathan Sobo
e6514bf3d8 Merge pull request #12377 from atom/ns-stringify-temp-window-state
Stringify/parse temporary window state to avoid nulling out references
2016-08-09 15:20:30 -06:00
Nathan Sobo
dfc0910023 Stringify/parse temporary window state to avoid nulling out references
If the object passed via IPC contains any keys of the same reference,
all but one of these keys will be nulled out. Converting to/from a
string avoids this problem.
2016-08-09 14:43:38 -06:00
Max Brunsfeld
16a22b9f28 Merge branch 'master' into ns-mb-detangle-editor 2016-08-09 13:36:46 -07:00
Max Brunsfeld
52af31c511 Trigger grammar-used hooks no matter how text editors are created 2016-08-09 12:04:01 -07:00
Max Brunsfeld
6346d05505 Remove last use of atom.config in text editor spec 2016-08-09 10:20:49 -07:00
Max Brunsfeld
637e525807 Use fake document & window in atom environment serialization spec 2016-08-08 16:32:58 -07:00
Max Brunsfeld
5d83874725 Merge branch 'master' into ns-mb-detangle-editor 2016-08-08 15:39:24 -07:00
Max Brunsfeld
e8c834e483 Serialize & deserialize the TextEditorRegistry in AtomEnvironment 2016-08-08 15:38:17 -07:00
Max Brunsfeld
53574288ae Fix editor leaks in TextEditorRegistry 2016-08-08 15:02:01 -07:00
Max Brunsfeld
eb9d89f8c8 Observe grammar changes on editors in maintainConfig 2016-08-08 12:10:56 -07:00
Max Brunsfeld
ee2e18737e Fix maintenance of grammars for copied editors 2016-08-08 11:17:30 -07:00
Nathan Sobo
21de77b739 Merge pull request #12346 from atom/ns-fix-repository-status-updates
Avoid passing paths outside of repository to git status subprocesses
2016-08-06 08:30:46 -06:00
Nathan Sobo
cd8e4eb43e Avoid passing paths outside of repository to status subprocess 2016-08-06 07:00:24 -06:00
Nathan Sobo
6c6cb66e5b Rename git-spec to git-repository-spec to match class name 2016-08-06 06:34:38 -06:00
Max Brunsfeld
ddfb124cb8 Merge branch 'master' into ns-mb-detangle-editor 2016-08-05 09:39:43 -07:00
Yuya Tanaka
1ce2f6ce87 🐛 Fix window size is not updated on resize 2016-08-05 11:56:01 +09:00
Max Brunsfeld
6bbe60ab71 Add test for handling of null env load setting 2016-08-04 16:01:58 -07:00
Max Brunsfeld
0beb4bec42 Merge branch 'master' into ns-fix-decorated-layer-destruction 2016-08-04 13:30:59 -07:00
Max Brunsfeld
74f8890592 ⬆️ text-buffer for marker layer destruction fixes 2016-08-04 12:37:51 -07:00
Max Brunsfeld
4634091e9b Don't update the NODE_PATH when updating the environment on launch
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-08-03 15:50:21 -07:00
Max Brunsfeld
0a924a9e2f Hook TextEditorRegistry to editors created by splitting panes 2016-08-03 10:58:11 -07:00
Max Brunsfeld
368b677420 Merge pull request #12276 from pbiggar/master
Add ability to see passed specs via tooltips
2016-08-03 09:35:31 -07:00
Paul Biggar
0f8eb5c1ba Add ability to see passed specs via tooltips
It's not currently possible to see what specs pass. This adds the
description of the spec, as well as all it's parent suites, to a
tooltip so you can see what's passing and failing on mouseover.
2016-08-02 17:40:26 -07:00
Max Brunsfeld
a56db9a03e Merge pull request #12297 from atom/mb-pass-missing-softwrap-hanging-indent-param
Supply missing softWrapHangingIndent parameter to display layer
2016-08-02 17:02:59 -07:00
Max Brunsfeld
43f34f73da Supply missing softWrapHangingIndent parameter to display layer 2016-08-02 16:20:23 -07:00
Nathan Sobo
46b59906e0 Add on method to fake browser window in tests 2016-08-02 17:12:04 -06:00
Nathan Sobo
c029151322 Test that updateWindowSheetOffset can be called
Testing the wiring to themes isn't worth it, but this at least makes sure we don't break if Electron APIs change.
2016-08-02 16:16:27 -06:00
Nathan Sobo
1e81f0ca1c Test onDidChangeActivePaneItem observation in title-bar-spec 2016-08-02 16:08:25 -06:00
Nathan Sobo
0c83d9741f Don’t implement title bar via custom elements 2016-08-02 15:56:45 -06:00
Nathan Sobo
0240206d93 Merge branch 'master' into brumm-master 2016-08-02 15:39:57 -06:00
Max Brunsfeld
f3d486eb9c Merge branch 'master' into ns-mb-detangle-editor 2016-08-02 14:12:18 -07:00
Max Brunsfeld
c7b7eace22 Merge pull request #12292 from atom/mb-fix-incompatible-module-error
Fix exception when package requires an incompatible native module
2016-08-02 13:58:28 -07:00
Max Brunsfeld
9a72c7e65e Fix exception when package requires an incompatible native module 2016-08-02 12:14:00 -07:00
Max Brunsfeld
3e0334d88f In TextEditorElement spec, style scrollbar within shadow root 2016-08-02 11:26:09 -07:00
Nathan Sobo
2b5f1bda46 Always seek to specified position in TokenizedBufferIterator
Fixes #10350

Signed-off-by: Antonio Scandurra <as-cii@github.com>
2016-08-02 12:19:45 -06:00
Max Brunsfeld
97d791f728 Deprecate grammar override API on GrammarRegistry 2016-07-29 13:42:09 -07:00
Max Brunsfeld
e2e245aca1 Make TextEditorRegistry.setGrammarOverride take a scope name
Also, clear the stored grammar score for that editor when setting an override.
2016-07-29 13:40:29 -07:00
Antonio Scandurra
6d4102a098 Delete random-editor-spec.coffee
We are already extensively testing the same specs on text-buffer.
2016-07-29 17:15:06 +02:00
Antonio Scandurra
fd94acc2e8 Delete RowMap and its specs
After transitioning to `DisplayLayer` we don't need this object anymore.
2016-07-29 17:12:44 +02:00
Nathan Sobo
43caead392 Avoid test failure due to timing
Signed-off-by: Antonio Scandurra <as-cii@github.com>
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2016-07-28 17:34:57 -06:00
Max Brunsfeld
16c80f6eaf WIP - add local null grammar 2016-07-28 14:47:26 -07:00
Max Brunsfeld
f1a302a139 Merge branch 'master' into ns-mb-detangle-editor 2016-07-28 10:33:23 -07:00
Max Brunsfeld
738a2b90dc 🔥 useShadowDOM setting 2016-07-28 10:02:16 -07:00
Max Brunsfeld
e1f8a72995 Move ctrl-mousewheel handling out of TextEditorComponent
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-07-27 16:02:24 -07:00
Max Brunsfeld
ab30ecf994 Manage scroll sensitivity setting in TextEditorRegistry
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-07-27 15:39:03 -07:00
Max Brunsfeld
63a730253b Don't use config for scrollSensitivity in TextEditorComponent
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-07-27 15:35:56 -07:00
Max Brunsfeld
1c38dce3b2 Don't use font config settings in TextEditorComponent
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-07-27 15:23:59 -07:00
Max Brunsfeld
3f8b6138dc Don't use config in TextEditorPresenter
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-07-27 14:56:36 -07:00
Max Brunsfeld
3d796df401 Stop using GrammarRegistry in TextEditor 2016-07-27 14:09:17 -07:00
Max Brunsfeld
e6c83521c9 Move grammar serialization logic to TextEditorRegistry 2016-07-27 13:10:23 -07:00
Max Brunsfeld
e35c761246 Use setShowInvisibles in TextEditorPresenter spec 2016-07-27 11:23:39 -07:00
Max Brunsfeld
8bf60f9266 Don't call PackageManager::activate in workspace spec 2016-07-27 10:59:50 -07:00
Max Brunsfeld
1ab26c7e85 Pass TextEditorRegistry to Workspace constructor in spec 2016-07-27 10:39:59 -07:00
Max Brunsfeld
dfb48aa8da Get TextEditorComponent specs passing
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-07-26 16:04:09 -07:00
Max Brunsfeld
caab1dda63 Move grammar-used spec to workspace-spec
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-07-26 15:38:53 -07:00
Max Brunsfeld
d203610986 Set grammar manually in tokenized buffer specs
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-07-26 15:08:59 -07:00
Max Brunsfeld
a44d5833a8 Move grammar override logic into TextEditorRegistry
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-07-26 15:00:20 -07:00
Max Brunsfeld
455d3213ed Return token objects from tokensForScreenRow
Include the text of each token alongside its array of scopes.

Signed-off-by: Nathan Sobo <nathan@github.com>
2016-07-26 12:39:41 -07:00
Max Brunsfeld
20b54505f3 Move logic for assigning grammars to editors into TextEditorRegistry 2016-07-26 10:50:57 -07:00
Andres Suarez
d7378f0d6a Cleanup activationHookSubscriptions when deactivating package
Released under CC0.
2016-07-25 22:45:43 -07:00
Damien Guard
177c48dd11 Merge pull request #12123 from atom/windows-system-settings
Windows shell integration system settings
2016-07-19 17:23:02 -07:00
Damien Guard
23dfa392c9
Fix up Squirrel specs 2016-07-18 22:56:02 -07:00
Max Brunsfeld
4eb2f6631a 👕 Fix lint errors 2016-07-15 13:32:23 -07:00
Max Brunsfeld
4ad801b216 Merge branch 'master' into ns-mb-detangle-editor 2016-07-15 09:39:32 -07:00
Max Brunsfeld
58e7892492 Remove GitRepositoryAsync
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-07-13 14:03:29 -07:00
Max Brunsfeld
7b11c31e07 Remove synchronous GitRepository's dependency on GitRepositoryAsync
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-07-13 14:02:05 -07:00
Damien Guard
5a8ced324e
Fixup Squirrel installer spec tests 2016-07-12 18:11:59 -07:00
Max Brunsfeld
c0cbb59666 Don't use config in TokenizedBuffer 2016-07-12 14:31:05 -07:00
Max Brunsfeld
5adb087ab1 Move config handling out of LanguageMode 2016-07-12 14:19:35 -07:00
Max Brunsfeld
b1f5583c4e Remove stray usages of atom.config in text-editor-spec 2016-07-12 11:31:03 -07:00
Max Brunsfeld
58ec44f8ec Move handling of nonWordCharacters setting into TextEditorRegistry 2016-07-12 11:30:41 -07:00
Max Brunsfeld
5167dbca6f Move handling of undoGroupingInterval to TextEditorRegistry 2016-07-11 17:47:40 -07:00
Max Brunsfeld
9ab474a673 Move handling of scrollPastEnd setting to TextEditorRegistry 2016-07-11 17:41:06 -07:00
Max Brunsfeld
7a50aa9f9f Move handling of auto indent settings to TextEditorRegistry 2016-07-11 17:37:51 -07:00
Max Brunsfeld
6f764f86cf Move handling of backUpBeforeSaving to TextEditorRegistry 2016-07-11 17:16:41 -07:00
Max Brunsfeld
cdc9bdea61 Use setter methods instead of config settings in TextEditor test 2016-07-11 17:03:44 -07:00
Max Brunsfeld
66c56d2a72 TextEditorRegistry: test skipping comments when guessing soft tabs 2016-07-11 17:02:03 -07:00
Max Brunsfeld
25035d8fce Remove some config usages from text editor spec 2016-07-11 13:52:05 -07:00
Max Brunsfeld
f327a4f95d Test that maintainConfig uses scoped settings 2016-07-11 13:50:38 -07:00
Max Brunsfeld
5acab853cd Remove all config observation from text editor 2016-07-11 12:43:18 -07:00
Max Brunsfeld
d91895961e Move more config observation out of text editor 2016-07-08 17:54:24 -07:00
Max Brunsfeld
eec1b70967 Start moving config observation out of editor into editor registry
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-07-08 17:41:59 -07:00
Antonio Scandurra
de3b48b2d3 Use editor.update in tests 2016-07-08 10:07:37 +02:00
Antonio Scandurra
811ab26f61 Return an update promise in TextEditor.prototype.update() 2016-07-08 09:42:08 +02:00
Nathan Sobo
bb1516ee77 🎨
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2016-07-06 12:58:07 -06:00
Nathan Sobo
a5613cd7e4 Convert text-editor-registry and tests to JS
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2016-07-06 12:54:30 -06:00
Philipp Brumm
a9d554f1c4 remove leftover console.log 2016-07-06 14:22:17 +02:00
Philipp Brumm
4a61bef6fe add a test 2016-07-02 12:28:14 +02:00
Antonio Scandurra
7efb407d8a Write spec for TextEditorElement when autoHeight changes 2016-06-30 15:48:00 +02:00
Antonio Scandurra
b46ae1e681 Allow autoHeight to be updated in TextEditor.prototype.update 2016-06-30 15:30:05 +02:00
Antonio Scandurra
8cb0fbcc5c Allow autoHeight to be set from the editor 2016-06-30 15:27:47 +02:00
Antonio Scandurra
7325381fd6 🎨 2016-06-30 15:08:51 +02:00
Antonio Scandurra
ccf73189ee Allow scrollPastEnd to be updated in TextEditor.prototype.update 2016-06-30 15:07:20 +02:00
Antonio Scandurra
c769b169aa Allow scrollPastEnd to be set from the editor 2016-06-30 15:05:21 +02:00
Antonio Scandurra
7beafa2da6 Introduce TextEditor.prototype.update
This allows TextEditor objects to be used within an etch component
easily.
2016-06-30 12:42:15 +02:00
Antonio Scandurra
a5fdf3e18a Merge pull request #12008 from atom/as-ns-recreate-destroyed-repo
Recreate Repository if the same project is added after being removed
2016-06-21 11:40:49 +02:00
Antonio Scandurra
95932081b2 Recreate repository if the same project is added after being removed
🍐ed with @nathansobo.
2016-06-20 17:06:50 +02:00
Leo Lamprecht
0ceacf5c13 OSX -> macOS 2016-06-20 11:29:10 +02:00
Leonard Lamprecht
3a1ad3fd40 Replace OS X and Mac OS with macOS 2016-06-18 15:33:08 +02:00
simurai
4c6899a1e1 Merge branch 'master' of https://github.com/atom/atom into sm-spec-suite 2016-06-18 15:29:59 +09:00
Antonio Scandurra
5391907c49 Merge pull request #11998 from atom/as-fix-janky-specs
Don't test CSON.readFileSync behavior twice (here and in atom/season)
2016-06-18 00:17:19 +02:00
Antonio Scandurra
bdce8d15ab Rely on CSON.readFileSync to test caching behavior 2016-06-17 11:04:08 +02:00
Nathan Sobo
8a3d5f8534 Use preferred line length as a *maximum* for soft wrapping
...if the softWrapAtPreferredLineLength config setting is enabled.
2016-06-16 08:42:30 -06:00
simurai
b1f0cbb134 Make Spec Suite less flickery 2016-06-11 10:46:10 +09:00