Corey Johnson & Nathan Sobo
b31bef4ea0
When updating folds, don't modify the array over which we're iterating
2012-03-16 16:31:52 -06:00
Corey Johnson & Nathan Sobo
67d017f3f4
Fix bug where destroying a fold on last screen line of wrapped line caused an artifact.
2012-03-16 16:11:44 -06:00
Corey Johnson & Nathan Sobo
7336e8313c
Folds can be created on the penultimate screen line of a wrapped buffer line
2012-03-16 14:35:07 -07:00
Corey Johnson & Nathan Sobo
3b46ce84e6
expandBufferRangeToLineEnds works for ranges that are folded on screen
2012-03-16 13:33:11 -07:00
Corey Johnson & Nathan Sobo
45c825e76c
Report proper screen ranges on change events for folds created on wrapped lines
2012-03-16 13:33:11 -07:00
Nathan Sobo
0aeb826bbf
Don't display a margin below file-finder list when it's empty
2012-03-16 11:29:48 -06:00
Nathan Sobo
da75f8a6ff
Explicitly focus editor when file finder is closed.
...
Trying to catch focusout events on anything other than the editor was really error-prone and ultimately more abstraction than we need right now. This fixes a bug where we would lose the ability to input text after clicking on the editor element.
2012-03-16 05:58:12 -06:00
Nathan Sobo
5d1bde62a6
Ensure gutter drop-shadow always extends to bottom of window, even if file is shorter.
...
This is fragile. Had to apply a min-height of 100% to horizontal scroller. If I apply it to gutter it causes rendering artifacts. I think we're on the edge of the flexbox code here and may even be causing crashes.
2012-03-16 05:49:03 -06:00
Nathan Sobo
6003e5c2e1
Merge branch 'master' of github.com:github/atom
2012-03-16 05:41:56 -06:00
Nathan Sobo
174c4e18cc
Fix scrolling misbehavior and display artifacts.
...
Switching back to the new flexbox and re-introducing a scrollable-content node that the flexbox is applied to. This has no height settings so it grows to contains the gutter and lines. The editor outside of it has a width / height of 100% of its container plus overflow-y of scroll. Trying to apply flexbox AND a 100% height + scroll all to the editor causes display artifacts.
2012-03-16 05:41:43 -06:00
Corey Johnson
2332592a78
Benchmark after cibuild succeeds
2012-03-15 17:47:51 -07:00
Corey Johnson
f1003d1e3e
Send benchmark data to graphite
2012-03-15 17:47:51 -07:00
Corey Johnson & Nathan Sobo
fd5439f357
Simplify layout and prevent scrollbar flash when toggling file finder.
2012-03-15 17:18:26 -06:00
Nathan Sobo
0efee25ded
Cleanup keybindings after app spec.
2012-03-15 16:22:02 -06:00
Nathan Sobo
6bdba313d1
Don't add to the same window to the atom.windows array twice
2012-03-15 16:10:55 -06:00
Nathan Sobo
60056e57fb
Use an editor in the file finder instead of an input element.
2012-03-15 13:41:37 -06:00
Corey Johnson
a559e52352
Extract jasmine code into jasmine-helper
2012-03-15 10:46:40 -07:00
Corey Johnson
1a4ae397ad
rake benchmark uses --headless arg
2012-03-15 10:37:19 -07:00
Corey Johnson
300f030895
rake commands use /tmp/atom-build as the build directory
2012-03-15 10:25:41 -07:00
Corey Johnson
6b4f3b0386
Use --headless arg to enable console reporter and exit on finish.
2012-03-15 10:24:57 -07:00
Corey Johnson
80641636f9
rake tasks use console reporter
2012-03-15 10:15:06 -07:00
Corey Johnson
ef9673a145
jasmine-atom-reporter doesn't output any console data
2012-03-15 08:55:09 -07:00
Nathan Sobo
3515591d58
Fix bug where you couldn't use backspace, delete, arrow keys in file finder.
...
Bind all these movement keys only to editor for now, because they're interfering with the default input behavior.
2012-03-14 19:17:32 -06:00
Nathan Sobo
04fce8067f
Add some temporary logging to debug intermittent spec failure.
2012-03-14 19:15:59 -06:00
Nathan Sobo
8b0d79b589
Don't call shutdown on close event. The window is closing anyway.
2012-03-14 19:00:31 -06:00
Nathan Sobo
f88bfc1ab0
Use _.remove to remove windows from atom.windows array
2012-03-14 19:00:15 -06:00
Nathan Sobo
05699b9bb8
Merge branch 'master' of github.com:github/atom
2012-03-14 18:28:37 -06:00
Nathan Sobo
601cf41108
Fix bug where file-finder pushed editor up.
...
For now, I'm removing the flexbox treatment of #app-vertical because the file finder just needs to overlay the bottom and absolute positioning is simpler. I'm also using requireStylesheet to load the file finders CSS instead of a link tag.
2012-03-14 18:28:23 -06:00
Corey Johnson
5c2b8b8ed6
this commit fixes the previous failure
2012-03-14 16:40:44 -07:00
Corey Johnson
8bff0d91f7
this commit should fail
2012-03-14 16:39:48 -07:00
Corey Johnson
4428979a66
📣 💩
2012-03-14 16:38:24 -07:00
Corey Johnson
f5cc7fceb9
Get rid of newline in cibuild's sha var
2012-03-14 16:13:42 -07:00
Corey Johnson
709de13138
Add key for cibuild
2012-03-14 16:09:31 -07:00
Corey Johnson
154fa2fa92
Editor.save spec removes test files in afterEach method
2012-03-14 14:38:03 -07:00
Corey Johnson
a09c76e3b5
Terminate rake tasks when build fails
2012-03-14 12:57:03 -07:00
Corey Johnson
caaa8d110e
💄
2012-03-14 12:19:50 -07:00
Corey Johnson
eceb5aec33
Set permissions for cibuild
2012-03-14 12:17:25 -07:00
Corey Johnson
8a0a1f0e66
Add Janky build script
2012-03-14 12:15:05 -07:00
Corey Johnson
8e55df162c
rake test exits with same exitstatus as the atom app
2012-03-14 11:28:08 -07:00
Corey Johnson
c6e530e82f
Ignore std err for now. Xcode pipes out too much noise.
2012-03-14 11:27:33 -07:00
Corey Johnson
56fb238bf6
Failures cause app to exit with exitStatus != 1
2012-03-14 11:00:35 -07:00
Corey Johnson
117d9287e0
Allow AtomReporter to output text to console.
2012-03-14 10:48:53 -07:00
Corey Johnson
131d5775bf
Clean up line noise on console.log
2012-03-14 10:48:17 -07:00
Corey Johnson
ac61e18f2c
Format console log better
2012-03-14 09:59:36 -07:00
Corey Johnson
ae298cf409
Update rake tasks to use arguments
2012-03-14 09:59:36 -07:00
Corey Johnson
8af57e011e
Move main.mm to top of project
2012-03-14 09:59:36 -07:00
Corey Johnson
1b1e81c6cf
Running tests or benchmarks cause app to exit when finished.
2012-03-14 09:59:36 -07:00
Corey Johnson
638c0c625b
Rename TrivialReporter AtomReporter
2012-03-14 09:59:31 -07:00
Corey Johnson
8b62357c96
Add method that takes a block for modifying JS vars from objective-c
2012-03-14 09:52:08 -07:00
Nathan Sobo
5bf9925d0a
Unsubscribe from Buffer when an Editor is removed from the DOM.
2012-03-13 19:20:40 -06:00
