Commit Graph

5610 Commits

Author SHA1 Message Date
Antonio Scandurra
b68da1e19b 💚 Finish porting TextEditorPresenter specs 2015-06-06 10:51:35 +02:00
Antonio Scandurra
de766afee7 Start porting specs 2015-06-06 10:18:26 +02:00
Max Brunsfeld
688cc5ef9d Merge pull request #7023 from atom/mb-optimize-marker-observation
Optimize marker observation
2015-06-04 10:57:00 -07:00
Kevin Sawicki
91e3a76d17 Update spec for new deprecation data 2015-06-04 10:53:12 -07:00
Max Brunsfeld
f5895d8b0b presenter: use 'markers-updated' event for state updates
Signed-off-by: Nathan Sobo <nathan@github.com>
2015-06-03 17:58:44 -07:00
Kevin Sawicki
c9eb9d71cc Setup deprecated packages in dev mode 2015-06-03 16:11:16 -07:00
Kevin Sawicki
2523e72e50 🎨 2015-06-03 09:49:03 -07:00
Kevin Sawicki
df2bd62327 Load deprecated packages when including deprecated APIs 2015-06-03 09:47:13 -07:00
Kevin Sawicki
4bb6728784 Add atom.packages.getDeprecatedPackageMetadata 2015-06-03 09:19:57 -07:00
Kevin Sawicki
d557e78847 Add spec for deprecated packages 2015-06-03 09:19:57 -07:00
Max Brunsfeld
76c696f1a2 Merge branch 'master' into mb-optimize-marker-observation
Conflicts:
	src/text-editor-component.coffee
	src/text-editor-presenter.coffee
2015-06-03 09:12:07 -07:00
Nathan Sobo
dac39bdcd5 Merge pull request #6733 from atom/as-tiled-rendering
Render lines via tiles
2015-06-03 00:18:41 +02:00
Kevin Sawicki
82eb01d13e Move deserialize spec to text-editor-spec 2015-06-01 18:01:34 -07:00
Kevin Sawicki
34591d3542 Catch read errors during deserialization
Prevents Atom from failing to open because of a read error with a
serialized editor.
2015-06-01 17:54:43 -07:00
Nathan Sobo
e723b26eb0 Add maximumLength schema enforcer for strings 2015-06-01 18:45:38 +02:00
Nathan Sobo
b68902dd83 🎨 2015-06-01 18:45:38 +02:00
Kevin Sawicki
eaaa6b15e5 🚱 Prevent stdout/stderr data listener leaks
Old listeners were not cleaned up before new ones were being added
causing the following console message:

warning: possible EventEmitter memory leak detected.

Refs #7033
2015-06-01 09:38:10 -07:00
Max Brunsfeld
6f553f234c Add TextEditor::observeMarkers, use it in presenter
Signed-off-by: Nathan Sobo <nathan@github.com>
2015-05-29 17:21:23 -07:00
Max Brunsfeld
b59bec5f9d Add Set::isEqual method in specs
This allows us to use the .toEqual matcher to compare Set
objects.
2015-05-29 17:18:48 -07:00
Max Brunsfeld
686c72eebe Merge pull request #6978 from mostafaeweda/initial-paths-2
Initial paths shouldn't be normalized on save and restore [2]
2015-05-29 10:28:56 -07:00
Antonio Scandurra
9b4d62b687 🐛 Update cursors after model changes
/cc: @nathansobo
2015-05-29 15:21:00 +02:00
Antonio Scandurra
b4dfb2a31b Merge branch 'master' into as-tiled-rendering 2015-05-29 14:19:25 +02:00
Nathan Sobo
447dfd8bec If a keystroke is bound to ‘unset!’, omit it in the application menu
Fixes atom/atom-keymap#79

This is more general than I would like. If the keystroke is unset in
any context, we err on the side of caution and don’t add it to the
application menu for any command. Since our application menu isn’t
context aware, this should be good enough for now and solve the 80%
case. Someday we should make the application menu update / gray out
options when the focused element changes.
2015-05-28 22:59:10 +02:00
Nathan Sobo
31cf19a205 Use previous definition of scope selector match to fix API breakage
I switched to first-mate Selector because I didn’t want to replicate
the poorly-defined Token::matchesScopeSelector method now that tokens
are not stored on lines. However, the first-mate semantics are stricter
and that broke the API. Perhaps using selector-kit here would be better,
but I just wanted to put back exactly to how it was for now.

/cc @ypresto
2015-05-28 10:38:35 +02:00
Mostafa Eweda
4c9e6c5a27 Revert "Merge pull request #6977 from atom/revert-6813-local-initial-paths"
This reverts commit 0c66802278, reversing
changes made to bdce576ab9.
2015-05-27 11:18:15 -07:00
Max Brunsfeld
0dcdfa1e89 Revert "Initial paths shouldn't be normalized on save and restore (could contain uris)" 2015-05-27 10:26:59 -07:00
Max Brunsfeld
8dff5bbe4c Merge pull request #6813 from mostafaeweda/local-initial-paths
Initial paths shouldn't be normalized on save and restore (could contain uris)
2015-05-26 15:48:58 -07:00
Machiste Quintana
8ca1cf2c98 👕 Fix linter errors in text-editor-spec 2015-05-22 19:50:04 -04:00
Machiste Quintana
82958d5aa0 WIP: 👕 Fix even more linter errors 2015-05-22 17:03:06 -04:00
Machiste Quintana
d5bcc0433d WIP: 👕 Fix linter errors 2015-05-22 16:29:12 -04:00
Antonio Scandurra
80a3294f8e 💚 Fix wrong spec
@nathansobo: I just forgot to include an actually visible tile in this
test which, therefore, complained. “Production code”-wise the behavior
was consistent and correct.
2015-05-22 14:05:21 +02:00
Antonio Scandurra
538fcfece3 🎨 Better test naming 2015-05-22 14:01:52 +02:00
Nathan Sobo
1783415714 Fix spec failure
@as-cii this was just a typo, but there’s a failure later in the spec
that you’re probably in a better position to fix quickly.
2015-05-22 09:51:48 +02:00
Nathan Sobo
c02294c404 Merge branch 'master' into as-tiled-rendering 2015-05-22 09:46:00 +02:00
Nathan Sobo
865015e47d Correctly compute bufferDelta for last soft wrap line segment
Fixes #6885
2015-05-21 19:56:53 +02:00
Nathan Sobo
2379b3803f Revert "Revert "Merge pull request #6757 from atom/ns-less-memory-for-tokens""
This reverts commit 7cb0bc3bc2.
2015-05-21 19:56:52 +02:00
Nathan Sobo
7cb0bc3bc2 Revert "Merge pull request #6757 from atom/ns-less-memory-for-tokens"
This reverts commit 0cd1f110b5, reversing
changes made to d75d202d33.

Conflicts:
	package.json
2015-05-21 16:25:23 +02:00
Antonio Scandurra
490ab2c468 💚
Conflicts:
	spec/text-editor-presenter-spec.coffee
	src/lines-component.coffee
	src/text-editor-presenter.coffee
2015-05-21 11:07:03 +02:00
Antonio Scandurra
299ee5dbf3 Merge branch 'master' into as-tiled-rendering
# Conflicts:
#	spec/text-editor-presenter-spec.coffee
#	src/lines-component.coffee
#	src/text-editor-presenter.coffee
2015-05-21 10:46:52 +02:00
Antonio Scandurra
1a18cda000 💚 Fix remaining specs 2015-05-21 10:00:46 +02:00
Antonio Scandurra
752dbf2c6e Manually config tileSize
Dealing with a manually entered `tileSize` is actually easier to reason about,
therefore we no longer calculate it based on `tileCount.`
2015-05-21 09:59:58 +02:00
Nathan Sobo
0cd1f110b5 Merge pull request #6757 from atom/ns-less-memory-for-tokens
Use 70% less memory for TokenizedLines by using a different representation
2015-05-20 19:47:52 +02:00
Antonio Scandurra
329b5b4e02 Merge branch 'master' into as-tiled-rendering 2015-05-20 17:16:45 +02:00
Mostafa Eweda
e7064bfc9d Fix tests + add integration test 2015-05-19 19:13:19 -07:00
Mostafa Eweda
c3552c95bc Address comments + add tests 2015-05-19 19:05:45 -07:00
Max Brunsfeld
2bfbb7619e Fix bug w/ markers mutated inside of change listeners 2015-05-19 17:48:53 -07:00
Max Brunsfeld
a1cc35b270 Fix DisplayBuffer spec
Marker updates now happen after all buffer changes
2015-05-19 15:18:20 -07:00
Antonio Scandurra
350b306c33 Merge branch 'master' into as-tiled-rendering 2015-05-19 08:51:03 +02:00
Nathan Sobo
adb4988c02 Merge remote-tracking branch 'origin/master' into ns-less-memory-for-tokens 2015-05-19 01:52:10 +02:00
Kevin Sawicki
33ac25479b 🎨 Correct indentation 2015-05-18 15:39:57 -07:00