Commit Graph

15474 Commits

Author SHA1 Message Date
Aurelio Jargas
ca164a0b0b Fix link for TextMate's GitHub Organization 2014-05-12 15:56:06 -03:00
Corey Johnson
e011becc1a Upgrade to language-ruby-on-rails@0.13.0 2014-05-12 11:26:14 -07:00
Corey Johnson
25f5717ccf Merge pull request #1971 from abe33/feature_proper_multiselections_copy_paste
Implements multiple selections clipboard paste
2014-05-12 11:10:37 -07:00
Ivan Žužak
3f0640f4c3 Merge pull request #2162 from teddybradford/development
Remove duplicate . from default nonWordCharacters
2014-05-12 16:31:04 +01:00
Cheng Zhao
c1ed25d5dc Merge pull request #2189 from atom/atom-shell-v0.12.4
Upgrade to atom-shell@0.12.4
2014-05-12 23:10:38 +08:00
Cheng Zhao
f731769afd 📝 No more need of libudev hack on Linux. 2014-05-12 22:28:03 +08:00
Cheng Zhao
c466cef7d1 Upgrade to atom-shell@0.12.4 2014-05-12 22:27:22 +08:00
abe33
b2e86c80c4 Change test to cover all Selection::copy branches 2014-05-12 00:06:13 +02:00
abe33
b77ea04056 💄 Remove unnecessary double conditions 2014-05-12 00:06:01 +02:00
probablycorey
7cdaaf2f78 Upgrade markdown packages 2014-05-11 13:52:36 -07:00
Corey Johnson
6caf60bd6b Merge pull request #2160 from dyross/dyr-dev-builds
append git hash to version for dev builds
2014-05-11 12:58:39 -07:00
Teddy Bradford
1519dda294 Remove duplicate . from default nonWordCharacters 2014-05-11 02:10:30 -04:00
David Y. Ross
a7efca8bb4 append git hash to version for dev builds 2014-05-10 20:50:20 -07:00
Corey Johnson
dbe15f7dda Merge pull request #2142 from aureliojargas/patch-1
Remove unused 's' option from getopts
2014-05-10 15:53:21 -07:00
Corey Johnson
c81a6737ad Merge pull request #2144 from aureliojargas/patch-2
Use $(...) for command substitution, not backticks
2014-05-10 13:06:42 -07:00
Paul Betts
5b0d974b43 Merge pull request #2074 from dertuxmalwieder/master
+FreeBSD, -bullshit
2014-05-10 08:37:16 -07:00
Aurelio Jargas
2b73dff0f4 Use $(...) for command substitution, not backticks
Currently both \`...\` and `$(...)` are used for command substitution. It's better to chose just one and stick to it, to avoid confusion.

Some arguments favoring `$(...)`:

* **Easier to read.** The backtick is easily confused with apostrophes and quotes.
* **Easier to nest.** Nesting backticks commands is an escaping nightmare. Using parenthesis is natural: `$(foo $(bar))`
2014-05-10 09:15:53 -03:00
Aurelio Jargas
adf0ff0a67 Remove unused 's' option from getopts
This option is not handled by the next `case` command.
2014-05-10 08:41:30 -03:00
Corey Johnson
c79ef0473d Merge pull request #2133 from aaronhalford/updatedocs
Update docs and fix typos
2014-05-09 17:19:07 -07:00
Aaron Halford
d51b955e09 Update linux.md 2014-05-09 15:22:43 -07:00
Aaron Halford
774d7ec0af Update docs and fix typos 2014-05-09 15:16:13 -07:00
probablycorey
d6f4b00e16 🔥 whitespace 2014-05-09 11:40:27 -07:00
probablycorey
9d81df8670 Remove x86 instructions because they aren't supported.
Based on comment by https://github.com/atom/atom/pull/2117/files#r12489527
2014-05-09 11:40:18 -07:00
Corey Johnson
14a430b939 Merge pull request #2128 from alfredxing/body-fullscreen-class
Add `fullscreen` class to body when in full screen
2014-05-09 11:36:39 -07:00
Corey Johnson
07de4a70a1 Merge pull request #2117 from sophearak/master
Add troubleshoot document libudev in Ubuntu 14.04
2014-05-09 11:30:39 -07:00
Corey Johnson
eb84ac829b Merge pull request #2114 from Someguy123/master
Add troubleshooting to Windows build instructions
2014-05-09 11:29:50 -07:00
Corey Johnson
b8db56a77b Merge pull request #2113 from MitchelSBlake/patch-1
Add more sublime parity keybindings
2014-05-09 11:25:46 -07:00
Corey Johnson
1036f16d1e Merge pull request #2111 from Locke23rus/update-linux-keymaps
🐧 Fix #2103, #2100 Update platform bindings for linux/win.
2014-05-09 11:13:13 -07:00
Nathan Sobo
5ed1cfc259 Merge pull request #1923 from atom/ns-fix-scrollbar-overlap
Refine scrollbar interactions
2014-05-09 11:46:35 -06:00
Nathan Sobo
ce5c29fb47 Base the visible lines on the height instead of the clientHeight
Because overlay scrollbars are invisible unless scrolling and even
regular scrollbars can be transparent.
2014-05-09 11:33:04 -06:00
Nathan Sobo
f0fd48202c Refresh scrollbars when overlay/classic style preferences changes 2014-05-09 11:33:04 -06:00
Nathan Sobo
d5eb8c21b2 Only refresh editor scrollbars on stylesheet changes that require it
If a stylesheet is added or removed, we check if it contains a selector
for scrollbars before refreshing anything.
2014-05-09 11:33:04 -06:00
Nathan Sobo
76b9982e04 Emit stylesheet-added/removed from ThemeManager w/ CSSStyleSheet objects
This enables subscribers to detect not just that stylesheets have
changed, but specifically how they have changed. This is used by the
React editor component to only refresh scrollbars when a stylesheet
that actually contains selectors for scrollbar elements is added or
removed.
2014-05-09 11:33:04 -06:00
Nathan Sobo
ca7f11f7d0 Default scrollbar height/width to 15 when it's measure as 0
A 0 measurement indicates that overlay scrollbars are enabled, so we
just fall back to 15px in that case so the user can hover directly over
the scrollbar to scroll.
2014-05-09 11:33:04 -06:00
Nathan Sobo
1c1ace90db Hide and show scrollbars before measuring them after stylesheet changes
We measure the scrollbar-corner node when there's a stylesheet change,
but Chromium won't apply the new style if it was already visible before
the change. This commit hides and shows it before measuring so we get
accurate values.
2014-05-09 11:33:04 -06:00
Nathan Sobo
bdd605e85b Explicitly assign dummy scrollbars to the correct width/height
Previously, dummy scrollbars were always 15px wide/tall. This caused
them to obscure the ability to click for the entire 15px region, even if
the actual scrollbar was styled to be much thinner. Now we explicitly
measure the size of scrollbars on mount and when the stylesheets change
and set the height/width explicitly.
2014-05-09 11:33:04 -06:00
Nathan Sobo
e1b4b921ba Hide scrollbar when not scrollable in a given direction 2014-05-09 11:33:04 -06:00
Nathan Sobo
ab1ede5fe6 Add a dummy scrollbar corner
Horizontal / vertical scrollbars render a 'corner' on the lower right
when they would otherwise overlap. I previously relied on drawing both
dummy scrollbars at their full width/height so the corner got rendered,
but that interfered with the display of the horizontal scrollbar in
certain circumstances because it was too wide to scroll. This commit
provides that behavior with an absolutely positioned div with the same
dimensions as the intersection of scrollbars when both are visible.
2014-05-09 11:33:04 -06:00
Nathan Sobo
5e6d91d66c Don't allow spec window size to interfere with the size of the editor 2014-05-09 11:33:04 -06:00
Nathan Sobo
dbd271f70a Don't obscure last character of long lines with vertical scrollbar
This entailed quite a few changes to dial in scrollbars. The scrollbars
are now adjusted in size to account for the width of the opposite
scrollbar. If the width or height are not explicitly constrained and we
are scrollable in the opposite direction that is constrained, we account
for the width of the opposite scrollbar in assigning a natural height
or width based on the content.
2014-05-09 11:33:04 -06:00
Nathan Sobo
527ada47f9 Account for gutter width in scrollWidth of horizontal scrollbar
Because the scrollbar now spans the entire editor but the scrollable
area does not include the gutter, we need to add the current width of
the gutter to the scroll width of the horizontal scrollbar to allow
it to scroll to the end of the longest lines.
2014-05-09 11:33:03 -06:00
Nathan Sobo
afb70d0a95 Remove stray return in spec 2014-05-09 11:33:03 -06:00
Nathan Sobo
b5f910ad06 Update line number padding when max digits changes 2014-05-09 11:33:03 -06:00
Nathan Sobo
e412371b88 Remove logging 2014-05-09 11:33:03 -06:00
Nathan Sobo
7b4bc16531 Fix specs that broke when accounting for horizontal scrollbar height 2014-05-09 11:33:03 -06:00
Nathan Sobo
e6df30e94c Respect horizontal scrollbar when rendering the vertical, and vice versa
We set overflow to hidden in the opposite scroll direction only if we
can't actually scroll in that direction, causing the white square where
neither scrollbar overlaps to appear at the lower right corner.
2014-05-09 11:33:03 -06:00
Nathan Sobo
d9ba9262bf Update scrollTop to valid position when scrollbar disappears 2014-05-09 11:33:03 -06:00
Nathan Sobo
c4be32a5dd Revert "Revert "Don't obscure the last line of the editor with the horizontal scrollbar""
This reverts commit 1d634e471e.
2014-05-09 11:33:03 -06:00
Corey Johnson
0a32f6b5f0 Merge pull request #2050 from Spice-King/win-cmd-spawn-fix
Fix running .cmd stubs through BufferedProcess
2014-05-09 09:12:31 -07:00
Kyle Filz
f9fe5efbb0 Fix running .cmd stubs through BufferedProcess
ChildProcess.spawn only will run .exe files on Windows, not .cmd, .bat,
.anythingElse.

See joyent/node#2318 for more information.
2014-05-09 09:04:36 -05:00