Commit Graph

24041 Commits

Author SHA1 Message Date
Antonio Scandurra
d7156ff387 Remove event listeners from orphaned gutters 2015-06-19 10:24:48 +02:00
Antonio Scandurra
26b1d166fd Merge pull request #7320 from atom/as-remove-gutter-from-view-registry
Fix TextEditorComponent Race Condition
2015-06-19 09:01:59 +02:00
Antonio Scandurra
c8f24d2358 Revert "🐛 Remove Gutter from ViewRegistry"
This reverts commit b0d93accf7.
2015-06-18 19:54:37 +02:00
Kevin Sawicki
4675fc52e2 ⬆️ language-go@0.27 2015-06-18 08:35:27 -07:00
Kevin Sawicki
68cc5154d6 ⬆️ language-text@0.7 2015-06-18 08:33:51 -07:00
Kevin Sawicki
309410f3f4 Prepare 0.211 2015-06-17 14:42:32 -07:00
Ben Ogle
17235e706b ⬆️ notifications@0.56.0 2015-06-17 14:11:35 -07:00
Nathan Sobo
8890f78fae ⬆️ exception-reporting 2015-06-17 23:04:38 +02:00
Ben Ogle
fae42ca107 ⬆️ autocomplete-plus@2.17.4 2015-06-17 13:59:56 -07:00
Ben Ogle
2f41fb300f ⬆️ notifications to fix error 2015-06-17 13:59:29 -07:00
Max Brunsfeld
7b10d9bf3b Merge pull request #7324 from atom/mb-tweak-auto-indent
Fix some issues with auto-indent
2015-06-17 12:41:59 -07:00
Max Brunsfeld
64dfda572d Use raw buffer text (w/o invisibles) when testing decreaseIndentRegex 2015-06-17 12:07:42 -07:00
Max Brunsfeld
3cdeaa8b51 Don't auto-indent when pasting text w/ no line breaks 2015-06-17 10:57:21 -07:00
Antonio Scandurra
b04b0a8dc4 🐛 Fix race condition as well 2015-06-17 13:48:31 +02:00
Antonio Scandurra
b0d93accf7 🐛 Remove Gutter from ViewRegistry
Closes #7306

We started noticing that when a `TextEditor` pane got split, the same view for
`Gutter` was being shared amongst several models, thereby making the same DOM
element accessible simultaneously by more than one object. This made us
experience *orphaned line numbers*, caused by two instances of
`LineNumberGutterComponent` mutating `.line-numbers` at the same time.

This is a typical race condition which I would normally address by understanding
and possibly locking the correct order in which operations should happen.
However, I believe in this situation we shouldn’t actually care about ordering
at all, since I think views should be kept “local”, thus avoiding to expose them
to the world and/or reusing them across other views (either accidentally as in
this case or on purpose).
2015-06-17 12:28:10 +02:00
Machisté N. Quintana
62dc15a697 Merge pull request #7310 from atom/mq-resize-cursor
Fix pane resize cursors on Windows
2015-06-16 21:09:21 -04:00
Machiste Quintana
1bd94c670f Fix copypasta selector 2015-06-16 20:23:41 -04:00
Machiste Quintana
fe4654c9ea 🐛 Fix pane resize cursors on Windows 2015-06-16 20:18:16 -04:00
Max Brunsfeld
dbb1200e1b 🔥 unused method 2015-06-16 14:54:01 -07:00
Max Brunsfeld
1bbeca6801 ⬆️ snippets 2015-06-16 14:29:37 -07:00
Max Brunsfeld
7a80849d67 Merge pull request #7294 from aki77/fix/leak
DisplayBuffer::decorateMarker leak subscriptions
2015-06-16 14:26:51 -07:00
aki
449c03cb35 Fix destroy listeners 2015-06-16 18:05:45 +09:00
Max Brunsfeld
ebc5758d79 Merge pull request #7290 from atom/mb-fix-save-state-race
Fix incorrect state save when exiting
2015-06-15 14:40:37 -07:00
Max Brunsfeld
41773b0861 Fix incorrect state save when exiting 2015-06-15 14:14:08 -07:00
Max Brunsfeld
749e894070 ⬆️ text-buffer 2015-06-15 13:46:14 -07:00
Max Brunsfeld
fcf45ea0ce ⬆️ find-and-replace 2015-06-15 11:13:39 -07:00
Kevin Sawicki
9affa8d6dd ⬆️ symbols-view@0.99 2015-06-15 07:47:13 -07:00
Machisté N. Quintana
b79b5338d7 Merge pull request #7284 from atom/mq-bump-autosave
autosave@0.21.0
2015-06-15 09:27:03 -04:00
Machisté N. Quintana
d075a64e62 ⬆️ autosave@0.21.0 2015-06-15 07:41:25 -04:00
Max Brunsfeld
abca152fba Merge pull request #7258 from atom/mb-add-by-clauses-to-for-loops
Add by clauses to for loops to avoid complex loop increments
2015-06-12 16:58:41 -07:00
Max Brunsfeld
715238c3cd Add by clauses to for loops to avoid complex loop increments 2015-06-12 16:38:07 -07:00
Max Brunsfeld
6282e7e533 Merge pull request #7234 from atom/mb-keep-state-when-auto-updating
Avoid saving state when closing windows due to auto-update
2015-06-12 10:50:57 -07:00
Max Brunsfeld
c43233892b Merge pull request #7225 from lpommers/add-remove-cursor-when-there-are-multiple-cursors-if-cmd-clicking-on-it
Add remove cursor when there are multiple cursors and cmd clicking on it
2015-06-12 10:41:17 -07:00
Luke Pommersheim
8521b81051 spec - getCursorAtScreenPosition checks cursors instead of cursor.marker 2015-06-12 19:21:37 +02:00
Kevin Sawicki
5dee3ce595 ⬆️ language-sass@0.39 2015-06-12 09:03:55 -07:00
Luke Pommersheim
9f0f4c0530 refactor getCursorAtScreenPosition to avoid temporary array 2015-06-12 08:38:25 +02:00
Luke Pommersheim
63e491affa spec now checks if the cursors are the same, not their markers 2015-06-12 08:37:40 +02:00
Luke Pommersheim
3b3dc83a38 📝 updating docs for getCursorAtScreenPosition - can also take an {Array} 2015-06-12 08:36:44 +02:00
Machisté N. Quintana
01be252348 Merge pull request #7243 from atom/mq-bump-notifications
notifications@0.54.0
2015-06-11 22:12:12 -04:00
Machisté N. Quintana
4306d38169 ⬆️ notifications@0.54.0 2015-06-11 21:42:59 -04:00
Max Brunsfeld
e47221bc3f Never save window state in the middle of quitting 2015-06-11 17:24:12 -07:00
Kevin Sawicki
7a6a48d7ea Move getSaveDialogOptions near other save methods 2015-06-11 15:31:43 -07:00
Kevin Sawicki
a0778217df Merge pull request #7145 from FoldingText/Item-provides-save-panel-options
Item provides save panel options
2015-06-11 15:28:24 -07:00
Kevin Sawicki
48bf4203e1 Merge pull request #7237 from ssorallen/git-repository-docs
Add missing docs for GitRepository
2015-06-11 15:22:47 -07:00
Kevin Sawicki
1b20354931 Merge pull request #7239 from viddo/fix-native-cut
Handle native cut command in render process too
2015-06-11 15:21:04 -07:00
Machisté N. Quintana
a80a07cc63 Merge pull request #7235 from atom/mq-bump-tabs
tabs@0.81.0
2015-06-11 18:00:06 -04:00
Nicklas Gummesson
51dcc84fce Bind core:cut to native action
Using same pattern as the others
2015-06-11 23:10:26 +02:00
Ross Allen
51016550c3 Add missing docs for GitRepository
Add argument and return type docs to fill in the documentation site.
2015-06-11 13:45:06 -07:00
Machisté N. Quintana
b27a56df8a ⬆️ tabs@0.81.0 2015-06-11 16:27:38 -04:00
Max Brunsfeld
844cfcb7ae Avoid saving state when closing windows due to auto-update 2015-06-11 12:51:36 -07:00