Commit Graph

2352 Commits

Author SHA1 Message Date
Nathan Sobo
e167afd794 Rename Cursor to CursorView in preparation for a Cursor model in EditSession 2012-06-06 18:01:08 -06:00
Nathan Sobo
c6fa2313ca 💄 2012-06-06 17:47:29 -06:00
Nathan Sobo
00b9c6db81 Active edit session 💄 2012-06-06 17:46:00 -06:00
Nathan Sobo
d07f3008c6 Merge branch 'edit-session-refactor' 2012-06-06 17:01:28 -06:00
Nathan Sobo
ff52993c9e Fix bugs when switching between EditSessions 2012-06-06 17:00:02 -06:00
Corey Johnson
196aab1690 $native is now created once and registered as a CEF Extension. 2012-06-06 15:20:54 -07:00
Nathan Sobo
1344d42061 Add spec to ensure we unsubscribe from every buffer when we remove editor 2012-06-06 12:48:45 -06:00
Nathan Sobo
024618b69a Build Renderer in EditSession and assign it when switching to that EditSession 2012-06-06 12:42:53 -06:00
Nathan Sobo
4885af4fa8 Merge branch 'master' of github.com:github/atom 2012-06-06 12:11:00 -06:00
Nathan Sobo
5a28656259 Introduce EditSession class, which replaces edit session hashes 2012-06-06 12:10:49 -06:00
Corey Johnson
3792d24c9f Mini editor's don't toggle active-editor-path-change event 2012-06-05 13:43:03 -07:00
Corey Johnson
4b68fa3cae Remove detach recursion from autocomplete cancel.
miniEditor.focusOut was causing cancel to be called multiple times.
2012-06-05 13:43:03 -07:00
Corey Johnson
33053b08b4 💄 2012-06-05 13:43:02 -07:00
Nathan Sobo
e6af7a9515 Adjust the width of rendered lines to account for the longest line 2012-06-05 14:26:06 -06:00
Nathan Sobo
e433d106b8 Remove unnecessary construction of new editor 2012-06-05 14:25:32 -06:00
Nathan Sobo
3a776347ff Avoid leaking window resize subscriptions in editor spec 2012-06-05 14:25:08 -06:00
Nathan Sobo
e7ffaa1757 Merge branch 'master' of github.com:github/atom 2012-06-05 12:48:16 -06:00
Nathan Sobo
700c6d757a Fix call to renamed method 2012-06-05 12:47:53 -06:00
Nathan Sobo
911a417cb8 Rename maxLineLength to softWrapColumn 2012-06-05 12:47:39 -06:00
Corey Johnson
4f364e8cd8 Add newline-below event 2012-06-05 11:30:29 -07:00
Corey Johnson
afab19938e Use wasReversed instead of isReversed to show the local variable stores some temporal state. 2012-06-05 11:30:29 -07:00
Nathan Sobo
4dc41dcc21 💄 2012-06-05 11:09:40 -06:00
Nathan Sobo
e8705b7807 Merge branch 'master' of github.com:github/atom 2012-06-05 10:59:41 -06:00
Nathan Sobo
c24b8a90b2 If lines are removed after a renderer change, update padding appropriately 2012-06-05 10:59:11 -06:00
Corey Johnson
ce25b33c25 Inserting a newline before a top-level c-style statement (starting with a '{') no longer auto-indents it. 2012-06-05 09:09:20 -07:00
Nathan Sobo
9cfbce826d WIP: Don't allow impossibly high scroll top values.
It fixes the move to bottom issues, but breaks some other tests. Not sure why yet...
2012-06-04 21:57:10 -06:00
Nathan Sobo
3c2facc7be Add a disabled failing spec for text rendering when moving to the end of the file 2012-06-04 21:11:32 -06:00
Nathan Sobo
4eb4c95a86 Constrain the end of the old screen range to the lastRenderedScreenRow, not maxScreenRow
Constraining the end of the new range max screen row instead of the last rendered row is what allows the buffer to get longer when the last rendered screen row is smaller than the last visible screen row. But constraining the end of the old range to this was causing artifacts. The old range should always be constrained to what is rendered on screen now, not what "could be". What "could be" is the domain of the new range.
2012-06-04 20:48:29 -06:00
Nathan Sobo
de1086639d Add failing spec for folding more than a screen of text to less than a screen 2012-06-04 20:45:28 -06:00
Nathan Sobo
8f9d066d99 Restore reverted rename. clearLines -> clearRenderedLines 2012-06-04 20:32:50 -06:00
Nathan Sobo
c3a157a544 Revert "Use renderTo and renderFrom (instead of firstVisible/lastVisible) to adjust visible lines."
This reverts commit 419d7b1dec.

Conflicts:

	spec/app/editor-spec.coffee
2012-06-04 20:29:40 -06:00
Corey Johnson
0cfb2e9ef4 Rename Editor.visibleLines to Editor.renderedLines 2012-06-04 17:53:58 -07:00
Corey Johnson
419d7b1dec Use renderTo and renderFrom (instead of firstVisible/lastVisible) to adjust visible lines.
Fix specs that had wrong assumptions,
2012-06-04 17:48:11 -07:00
Corey Johnson
7364ea79cc TreeView serializes its attached state 2012-06-04 16:02:50 -07:00
Nathan Sobo
ded6281e0f Merge branch 'master' into toggle-comments 2012-06-04 12:07:54 -06:00
Nathan Sobo
d2a1da7ba6 Window spec no longer nukes the jasmine stylesheet 2012-06-04 12:07:37 -06:00
Nathan Sobo
a033d13c1a Merge branch 'master' of github.com:github/atom into toggle-comments 2012-06-04 11:55:15 -06:00
Nathan Sobo
b667ba4262 If selection is empty when toggling a line comment, keep it empty 2012-06-04 11:50:48 -06:00
Corey Johnson
2f6dd085ee Editor toggle-fold event toggles the largest fold at the cursor position 2012-06-04 09:44:20 -07:00
Corey Johnson & Nathan Sobo
86316c2115 Use last buffer row instead of last screen row to calculate gutter width. 2012-06-02 09:24:27 -07:00
Corey Johnson & Nathan Sobo
fd152ef2a9 When a fold is created inside an existing fold, don't trigger change events or update line map. 2012-06-02 09:21:06 -07:00
Corey Johnson & Nathan Sobo
433a4db5ae Add Fold.isContainedByFold(fold) 2012-06-02 09:19:37 -07:00
Corey Johnson & Nathan Sobo
daa96d8332 Remove triggering of 'fold' and 'unfold' events when fold is created/destroyed.
They aren't being used
2012-06-02 09:17:37 -07:00
Corey Johnson & Nathan Sobo
2f435e08f3 Add regression test for "can't create multiple folds over same region".
Am I using the term regression test correctly?
2012-06-02 08:56:02 -07:00
Nathan Sobo
14e399fdf0 Meta-/ comments out selected lines 2012-06-01 19:38:33 -06:00
Nathan Sobo
9219a1f30b Merge branch 'master' into toggle-comments 2012-06-01 18:09:03 -06:00
Corey Johnson & Nathan Sobo
74a873999e Fix tests that blow up when number of files in fixture directory increased 2012-06-01 15:54:28 -07:00
Corey Johnson & Nathan Sobo
3a8ac78a99 Comments aren't allowed in xcconfig 2012-06-01 15:53:38 -07:00
Corey Johnson
ca4371d9ce The solution to all build problems 2012-06-01 15:35:38 -07:00
Corey Johnson
c4a75492f4 Describe what ResourceConfig does 2012-06-01 15:27:52 -07:00