git.iko.soy/reflex-dom
on develop help sign in
PR review: Fix typos and fully qualify changelog
commit0dc8d80ed379db1da6973828d6158e580875441f authorTom Smalley <tfsmalley@gmail.com> dateWed 1 Apr 2020, 20:13 (7 years ago) parentd2d4ec1
2 files changed+4−4
compare with develop
unifiedsplit
reflex-dom-core/ChangeLog.md+2−2 reflex-dom-core/src/Reflex/Dom/Builder/Immediate.hs+2−2
reflex-dom-core/ChangeLog.md+2−2
@@ -20,8 +20,8 @@
2020* Fix bug in hydration when dealing with unexpected HTML ([#361](https://github.com/reflex-frp/reflex-dom/pull/361)).
2121
2222* Export attributes used for controlling hydration at the element level
23− * "data-ssr" is now available as `hydratableAttribute`
24− * "data-hydration-skip" is now available as `skipHydrationAttribute`
23+ * "data-ssr" is now available as `Reflex.Dom.Builder.Immediate.hydratableAttribute`
24+ * "data-hydration-skip" is now available as `Reflex.Dom.Builder.Immediate.skipHydrationAttribute`
2525
2626## 0.5.3
2727
reflex-dom-core/src/Reflex/Dom/Builder/Immediate.hs+2−2
@@ -778,7 +778,7 @@ hydrateElement elementTag cfg child = do
778778 wrapResult <- liftIO newEmptyMVar
779779 let -- Determine if we should skip an element. We currently skip elements for
780780 -- two reasons:
781− -- 1) it was not produced a static builder which supports hydration
781+ -- 1) it was not produced by a static builder which supports hydration
782782 -- 2) it is explicitly marked to be skipped
783783 shouldSkip :: DOM.Element -> HydrationRunnerT t m Bool
784784 shouldSkip e = do
@@ -800,7 +800,7 @@ hydrateElement elementTag cfg child = do
800800 Just node -> DOM.castTo DOM.Element node >>= \case
801801 Nothing -> go (Just node) -- this node is not an element, skip
802802 Just e -> shouldSkip e >>= \case
803− True -> go (Just node) -- this element is should be skipped by hydration
803+ True -> go (Just node) -- this element should be skipped by hydration
804804 False -> do
805805 t <- Element.getTagName e
806806 -- TODO: check attributes?